From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Revert "mm/compaction: fix set skip in fast_find_migrateblock""
Date: Wed, 26 Apr 2023 16:33:31 +0100 [thread overview]
Message-ID: <20230426153331.dfqagb47i4xo3ouv@techsingularity.net> (raw)
In-Reply-To: <c48c4da5-9de5-f060-b6ad-5373ced87d0a@suse.cz>
On Wed, Apr 26, 2023 at 05:10:14PM +0200, Vlastimil Babka wrote:
> On 4/26/23 17:03, Baolin Wang wrote:
> > This reverts commit 95e7a450b8190673675836bfef236262ceff084a.
> >
> > When I tested thpscale with v6.3 kernel, I found the compaction efficiency
> > had a great regression compared to v6.2-rc1 kernel. See below numbers:
> > v6.2-rc v6.3
> > Percentage huge-3 81.35 ( 0.00%) 32.97 ( -59.47%)
> > Percentage huge-5 89.92 ( 0.00%) 41.70 ( -53.63%)
> > Percentage huge-7 92.41 ( 0.00%) 34.08 ( -63.12%)
> > Percentage huge-12 90.29 ( 0.00%) 41.10 ( -54.49%)
> > Percentage huge-18 82.38 ( 0.00%) 41.24 ( -49.95%)
> > Percentage huge-24 80.34 ( 0.00%) 35.99 ( -55.20%)
> > Percentage huge-30 88.90 ( 0.00%) 44.20 ( -50.28%)
> > Percentage huge-32 90.69 ( 0.00%) 79.57 ( -12.25%)
> >
> > Ops Compaction stalls 113790.00 207099.00
> > Ops Compaction success 33983.00 19488.00
> > Ops Compaction failures 79807.00 187611.00
> > Ops Compaction efficiency 29.86 9.41
> >
> > After some investigation, I found the commit 95e7a450b819
> > ("Revert mm/compaction: fix set skip in fast_find_migrateblock") caused
> > the regression. This commit revert the commit 7efc3b726103 ("mm/compaction:
> > fix set skip in fast_find_migrateblock") to fix a CPU stalling issue, which
> > is caused by compaction stucked in repeating fast_find_migrateblock().
> >
> > And now the compaction stalling issue is addressed by commit cfccd2e63e7e
> > ("mm, compaction: finish pageblocks on complete migration failure"). So
>
> IIRC at that time I was pointing out some scenarios that could make the
> problem appear even after that commit, and we wanted to revisit that
> when Mel is back.
>
Yes, I've prototyped the fix against 6.3-rc7 and the revert is at the
end but the revert on its own has the potential for causing problems. The
series needs to be rebased, retested and posted. What I last tested
should show up shortly at
https://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git/ mm-follupfastmigrate-v1r1
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2023-04-26 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 15:03 Baolin Wang
2023-04-26 15:10 ` Vlastimil Babka
2023-04-26 15:33 ` Mel Gorman [this message]
2023-04-27 0:57 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426153331.dfqagb47i4xo3ouv@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox