From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D4FC7618E for ; Wed, 26 Apr 2023 04:42:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9774C6B0071; Wed, 26 Apr 2023 00:42:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 927436B0072; Wed, 26 Apr 2023 00:42:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83CD96B0074; Wed, 26 Apr 2023 00:42:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7895C6B0071 for ; Wed, 26 Apr 2023 00:42:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4D3CC1C5EB2 for ; Wed, 26 Apr 2023 04:42:26 +0000 (UTC) X-FDA: 80722295892.04.F69997E Received: from r3-23.sinamail.sina.com.cn (r3-23.sinamail.sina.com.cn [202.108.3.23]) by imf22.hostedemail.com (Postfix) with ESMTP id BA3A4C0008 for ; Wed, 26 Apr 2023 04:42:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.23 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682484144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9a0cZ68KKAxhwFO4W/86ZGd2diYbJhMYyO26x1IUj3w=; b=qJygNIyOpqj7rNd18Is5PKnr+1nBZirHUGXYiEyNMcUBBwBNSlmAckCf4snHPh+Qcng3oP XU9nZo2l7IOEYmMiMcXi065J27O3aebk9iYKnV+a0ZwG/1LRDtVit9bfj6OcWbT4EtT+3V hQx/o1b2mLHk4Vi0qW8MFGCMbzR3Aso= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.23 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682484144; a=rsa-sha256; cv=none; b=gQMBcJ0sQJncFLr9boU549tBjQk2YvmDY1W6XbTnbJXbB25zHjibiLnhWBmR2LPpfyyziY 54FN64reaDjdTf4G5MIXzDVsGZt8hV2e1nR4dpZpYQo6u/0yEyWu6XqkLy5GNMJC7GNJCC IDgUH3TyUwzeMpYGPoT8ynJcqYQJVi4= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.59.75]) by sina.com (172.16.97.23) with ESMTP id 6448ABA9000186A2; Wed, 26 Apr 2023 12:42:18 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 71437531457770 From: Hillf Danton To: Doug Anderson Cc: Andrew Morton , Mel Gorman , Alexander Viro , Christian Brauner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yu Zhao , Matthew Wilcox Subject: Re: [PATCH v2 1/4] mm/filemap: Add folio_lock_timeout() Date: Wed, 26 Apr 2023 12:42:07 +0800 Message-Id: <20230426044207.2378-1-hdanton@sina.com> In-Reply-To: References: <20230421221249.1616168-1-dianders@chromium.org> <20230421151135.v2.1.I2b71e11264c5c214bc59744b9e13e4c353bc5714@changeid> <20230422051858.1696-1-hdanton@sina.com> <20230425010917.1984-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BA3A4C0008 X-Rspam-User: X-Stat-Signature: 4j14ed9f8nwo3ipmqa5y8it45e65uzt4 X-HE-Tag: 1682484142-966708 X-HE-Meta: U2FsdGVkX18nj8RIMSy9zusD2AR/qCZJEtvYPsv8ljx9iZEK40bpIh5qaDQujmtKTSy+QB5AfJf4XIqULgf+0kmawsxftz51W3hKv6UMH0DhlgQkrx/KeJUrRC/Cmv9XjiVOJByBcgSqFfcPTKDIUliADS6Mck/570arVbj42oHeX9MaZa2/o0Ua/WfzCxZm85jknRxNlej9BYMD+gkS/zhWpoQHYrTFpmMIcIZgU6GlMyv697YPSJhRiraHwyzUotBgacQyNbccZ0M42y/gzEhzPXcw7UsUcQFPKPd06zuArUNNLSWFH5JEO5CW6isrxurGcaeInvFN7QS6dgeiDpam1Ub6cNkMKSQwFtBgdczdwkPhUT3Nm/jsmUSKN6sUqcPqXc0NDWEo7POayLgpIizFlmIB8vOERj/Y4FBQv1jj+50wGAxevlVf/LpepFtZCypcwjWJFmdu1YGW+df7wvMzwbnJsnbDuBHJ2jg24CLMfQjHqJ86DsW+Ntlj+J1jcGoI6amctwmxEOexrS5X5DHP+E6ag2TiFUDYiU03d7eUJisnIbUBlYXoL1Vm0m0QPkgB27H/QlbZ7qTYR6W5KX2vItq+KQ/dZUeKj38VcmZBVOpXfYYkuM7nL5Iv6U/6UiT/+/XxrKVikzi+KEoBT314/h1yiqfxithvAiku+vT+R0S207dpyAQJRdZ3RQ4F1nWAD4U16xV+g4xILeUfnTXGPNi6BSViwXWK622fqYj4X23unhKt8exLTfcWE2hC/xAOKiu3n0bcvp0ozFRjNtwnHSYX6dCg6m/uy6QYIQK9M/+E/l1M7fzAo0g1fn0H2nak+wp/XibeXdVFcmmyWPwREKjsQgaEB0G8jEFgie8QsRKJ1chVc8kaxN3JTJwniab9OiJMJoYzKNwEPoCXSE6JPJLzufc2h6jvFJGxuWtJfDpP5kmTcjgjwJOHmSukLipjsXeCkHIvsbj6Hsv mOHfXkhx jvA74Vtw+pRLrTLBKhkJqD8Xe6v/iOXgLz/pVYgoD0cCcHaqY3UqoUsmnQdZI0AZMS+kaTRyizyqrA7obfJ2UBwl+OX6mVtUohDupuvbz5vwgq9d9lNAevNq3dMbAR8xsz4wfmd2PAXEplQtqAhylKim+ZmJ9XBCDzsX/77NTr9KYsA3B6a6MQmxing== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25 Apr 2023 07:19:48 -0700 Douglas Anderson > > So is this an explicit NAK on this approach, then? Ah I see your point. You misunderstood because I dont think NAk is needed in 99.999% cases, given the fact that 1) your patch will never be able to escape from standing ovation 2) every mutex_trylock() hints the straws in mind.