From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1EE8C7EE21 for ; Tue, 25 Apr 2023 22:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 795466B0074; Tue, 25 Apr 2023 18:25:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 746086B0075; Tue, 25 Apr 2023 18:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 597C56B0078; Tue, 25 Apr 2023 18:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CBC36B0074 for ; Tue, 25 Apr 2023 18:25:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 19A2AA0163 for ; Tue, 25 Apr 2023 22:25:01 +0000 (UTC) X-FDA: 80721344802.22.A854018 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf17.hostedemail.com (Postfix) with ESMTP id 5D06A40009 for ; Tue, 25 Apr 2023 22:24:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=RSolNWsD; spf=pass (imf17.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682461499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TXOb1MmhlAoVWm22dO7Ned0kntNJ0+QdEkvlYiRO8xA=; b=qYnowLTlFe68X/BMCJeEtwnCPo+mNGilRzRcDBqaOklqMURtAyONFKy18u8CM24Ckn2BO4 SQWauJ4Ps3IxopBBmQxwQgYmql3ElPmWsNmzCahR+ckn+8qpm2LZjP3vMpTCY4IeMPBd+j BLARoRXJ9pWUrOHvgUp37MVf02iO27s= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=RSolNWsD; spf=pass (imf17.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682461499; a=rsa-sha256; cv=none; b=ki8mllUQPuN3+IuJ6vpvx50gTH81bG+gUR5liJQcSuwxwUXP0nC0CWH4hAw36gM0c2OcDX 0QWbAv2gUanExAwKa+mEzsu29vIpe/AqE0glUE70B7bsiAodTZTcZle/0ePeem1an0y5jZ ZKz8LU7hBWxD2Gh/XuvFYkRF+MXTS04= Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-32b482bbc26so50603765ab.1 for ; Tue, 25 Apr 2023 15:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682461498; x=1685053498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TXOb1MmhlAoVWm22dO7Ned0kntNJ0+QdEkvlYiRO8xA=; b=RSolNWsDX05r6oRrt5+eJqmWdrVwAmNRi9zxyf653BaUcu+Zh+gZUpq+hE1wmXauy9 0BufCSc7LVvut6niFuxMZH4XcR92id++1QaUSppYAndIdoDfhyXGCK1zJtSEgi/DjBDN I5LoRZEna6SzLRyfTrYjDvGuljaTEeGaYSZL/6yCnvBsZ9h9426h+rXIXm5UC+Ob4cdk vYXkM7jwJm5Q+1iZRfjqhNm1rPv/OvHwOiEXtscTLyzP3YRNJ9V1XrlxsEoXoI4tgp+7 R/lUPIPBXMIUL7As62iCcoFHA4fakx+A917kIXClKosrPGCNlQzgbtKMFAirVmc3TMOo tRDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682461498; x=1685053498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TXOb1MmhlAoVWm22dO7Ned0kntNJ0+QdEkvlYiRO8xA=; b=T1i8AuuKHZzfwLbs9qXMBCOoEU7S9lDI5Y7QgFbD7+mp3g+3PnP/ktuvNFvM58OV75 PDy4ksp0TSO3hsC72tjtF1YW8RfGG8qSuxqqIuHGhQaGp6kpIeNg1y0WYnd0y2apufyX a4lOc0yus3xzqhJ4db3u1kq8bOCkU2MNetqzVzGvTmFTjlEocz65kOcfXIfBYI/TxtcC 2ri7hafYy/V9FlwYiJHxsdy09I4ZJb5/8u6z70VIPNb+8lrAw1uGJnel7oSCncEglW5g VlMsxzcoXprtCsI71xoKCMu+gWG3MTCosMRZZY+vjvQe7z3cFcdHIY/lNF/V4ZjIwIkA Dxag== X-Gm-Message-State: AAQBX9f9MsQ/o+5QtDG0v+Ighaapsd6m9LjTupvB2MPLLNECQmrNh9Q1 Q5WHAlJPhtdbkezs2SW3s60IC21iX84= X-Google-Smtp-Source: AKy350bNDxVaIAbb5KoO8K8L1Tr0hSOZa7eWM9p0+82r/RyyxUO8IyY1rAUQbZ4knS5NwuOaugKxXg== X-Received: by 2002:a92:cf43:0:b0:325:b15b:88a3 with SMTP id c3-20020a92cf43000000b00325b15b88a3mr9277786ilr.13.1682461498466; Tue, 25 Apr 2023 15:24:58 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 13-20020a92180d000000b003244d7f2292sm3833008ily.32.2023.04.25.15.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 15:24:57 -0700 (PDT) From: Jim Cromie To: catalin.marinas@arm.com, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Jim Cromie Subject: [PATCH 3/3] kmemleak-test: drop __init to get better backtrace Date: Tue, 25 Apr 2023 16:24:46 -0600 Message-Id: <20230425222446.170486-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230425222446.170486-1-jim.cromie@gmail.com> References: <20230425222446.170486-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: u6q768ott6bkaygfcp6e4sf4qtzkj8j9 X-Rspamd-Queue-Id: 5D06A40009 X-HE-Tag: 1682461499-922038 X-HE-Meta: U2FsdGVkX18ODw6UcQlIHOfHKBeHhKz+wuc7G0oPPLV6rbDcZFeBMpkG6iQuuywXHOYAjQQyQO726cDm1dRuo2QKNfzId/bJDLfe1RL6ZsWNN2UI7Wb2ml3R15E3kgJnQVK9NXznO8A7UMieX/IIZUBxYo6CKQFekQk6mOGpSfgiCjCA2kfRA1/MEZ0XNH2Pn4ZP6ZdHPBFKf4PGOTyWrVz/tkUICDCPZ8u+JVvZUkhaplyl1MGQk/c1weY+24rFBxE3H8qVrl2MCrtlght1zzDFuxbMq+m+9RxLU4bYk+DbaSveWK/5GrnEsB9z4THW5lJSyz0jXdXXTJMTA4hW4g5wcU8jxzfnIvms/L68Fn+6W+Diq188mi1xm7ihA/YclitIkNIuU1qlLmcF2jTPYeyI3hKTiIZO0jTtc1s+iUdDuIMz7K2D0GY8lJ+CRx23g3FgtwP2VB/pCGRFHxHPd7mQxrCUXN86Kb9LNnsFhpbj0Wkwn1AEKzHy++VqjDU/WpvSoUOeRogESShn1cmQHZtY6jAZmd889iGh4r4Gn7hXuqqcCufUOnFABicWbm1idhKCanRogIv83uPUy+M2paV8Jh42ObSpIXva+Jb86Jpr+HxN1UWy2Hwwp77dbYtG89DfFGhcPq+FmaG5/xRfAcojMooeH41HFOooa6oC5xA26K8SaPAGH3811TNMg4kvHRt9LI4IsASvmLakQdIerYgGRrcP59MfvZU6v//CJXr5BPXB/uWCymRkChWbcGmcRz+eAAFKwxxOoQs2Yk7yjEtj3LhSDW7Z247hhgAhKipOzqxWMmwBUcFutISI9LO7e/WZkhkt0YvpNEX26RE8x2LXbYXi4T2XpcjPJtXOhKdCPU/ugkExeBzaQqO+zRgc6J7CLARjYXkYfbzdaMWEHAXg83RbrTgix0NpGVxVHJrkztdqKWj809HWMevtjz71QXpfylTN7Y1z25P0Tn+ 3KnDIgVN VsXuox5+u53ojORR0ei3Us+h7XBqJDsjI+nz6CYsEpDZZaZcJJ6wCa0xmJQbCWWOJyba1I+QOds3wLtnLM473UlggkPHcC5ri8XUV/2lnrVIMNjVxA4sJCkYhPnc3RXriOYFRCQYkQhN2p5Q/dnehsM1b++VGkyje8aWAnFmM/LTfc6a+rDcuW0v/dQdD3KM49bfukT1IOGhh/KfjyyU085gVhH3GGLFA9wX7oVBI1mo+B+23fCDfFZZKtwzrqnnIszovHfUSZAXSXiYkP8M2GOg81Mxw6UerARWcUllaEwENCzv8yzFU9ZTwdnjbVqgKx2rs4nXe2TrVVfUV13P4o6eMvlgh9Gk4b3kDCKdqcLB20E+m6PN+opvfaIBCXEYGGBYTg+8y3RliqpXzhv6a7eK/TtCCbp6nNMDBvDbr0j7A7EuJcF0gxrcugllaASnnC+YB40sWmPB1f3ZTyZ88bJLV7PDNwoLjZprqjIyvvfzthufdqr5JjLKVk8KiU7+6xO13hinDufBT2tU9bqWmtdvD0nuRRb7ju87id8Gg+0NWoRd/sjzvL0wwpjMTS7qg8uvw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Drop the __init on kmemleak_test_init(). With it, the storage is reclaimed, but then the symbol isn't available for "%pS" rendering, and the backtrace gets a bare pointer where the actual leak happened. unreferenced object 0xffff88800a2b0800 (size 1024): comm "modprobe", pid 413, jiffies 4294953430 hex dump (first 32 bytes): 73 02 00 00 75 01 00 68 02 00 00 01 00 00 00 04 s...u..h........ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace (ck 603070071): [<00000000fabad728>] kmalloc_trace+0x26/0x90 [<00000000ef738764>] 0xffffffffc02350a2 [<00000000004e5795>] do_one_initcall+0x43/0x210 [<00000000d768905e>] do_init_module+0x4a/0x210 [<0000000087135ab5>] __do_sys_finit_module+0x93/0xf0 [<000000004fcb1fa2>] do_syscall_64+0x34/0x80 [<00000000c73c8d9d>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 with __init gone, that trace entry renders like: [<00000000ef738764>] kmemleak_test_init+/ --- samples/kmemleak/kmemleak-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/kmemleak/kmemleak-test.c b/samples/kmemleak/kmemleak-test.c index 7b476eb8285f..6ced5ddd99d4 100644 --- a/samples/kmemleak/kmemleak-test.c +++ b/samples/kmemleak/kmemleak-test.c @@ -32,7 +32,7 @@ static DEFINE_PER_CPU(void *, kmemleak_test_pointer); * Some very simple testing. This function needs to be extended for * proper testing. */ -static int __init kmemleak_test_init(void) +static int kmemleak_test_init(void) { struct test_node *elem; int i; -- 2.40.0