From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A1DFC77B61 for ; Tue, 25 Apr 2023 22:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A55206B0072; Tue, 25 Apr 2023 18:24:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A05CE6B0074; Tue, 25 Apr 2023 18:24:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A50A6B0075; Tue, 25 Apr 2023 18:24:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7C3FF6B0072 for ; Tue, 25 Apr 2023 18:24:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5360316030F for ; Tue, 25 Apr 2023 22:24:59 +0000 (UTC) X-FDA: 80721344718.01.06AF5CE Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf08.hostedemail.com (Postfix) with ESMTP id 8D87C160004 for ; Tue, 25 Apr 2023 22:24:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Grk8Bdno; spf=pass (imf08.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682461497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=72+eO6KwavTo94Q3dwD5X6q19DNV6pOCYjiHiYVA/Vw=; b=Xxd3A+xI+ZNfsJE8eBKuqY7mrYPc4GT/Raaejnlr9YP0POyobnyTbpIhW9XSc4uspQ4Il8 rPmc2PqHLQPuai+HQYQA8kIi2WILYeT+Q/eljk5xSwM7zND9zmAuOoxvSXXwEeQqtimLlz G7dD3h/lVw4aMl1QvYIpo72iZh34SrM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Grk8Bdno; spf=pass (imf08.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682461497; a=rsa-sha256; cv=none; b=P8w1SI3a+T/uOi19u6QGogDuxT0uo7U/lkrbPfGPLC5bd7zYGipOyntmHb9y6ddXa129/Q QgQcSlmI4jzehVXCn+oHeWenXa8Xftsg6j2aIQPFtR9yDZeBqWBIjcTPqKAqDqhkUkIhzc 0nG2MZamZ2SMmAdZdGMUEETMy6Dxr3M= Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-32b482bbc26so50603595ab.1 for ; Tue, 25 Apr 2023 15:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682461496; x=1685053496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=72+eO6KwavTo94Q3dwD5X6q19DNV6pOCYjiHiYVA/Vw=; b=Grk8BdnodSaCw+q2KEGxiYiB/BWivAhKBG3jYwZhxGLowfMkRBXpthNBz0x+pd+T3P 6CAtDSNrOHaEJsadCy0ZB8775sPskCbqboCd8pgull+tCAZAhHrSBr2yYvnChZ429l1W aNLhgWELCQPxiDcM9nKlOy4UJVJqEDTGoYpug3z4DVq5egXl9vztA77qAbCwgUwqoInQ 7ZYsWmtZ80pXz/WM7d2RuwccAsEaNdfmcMISDUD4XhhkFwyBq8TeJFRqYqN9kxZlR3KB 5bD+ekaggIS6DwCjFeDGRUXZP6rxMkCM3/nmhEJGxgEO4NP6+N5SRHHBKImsVGhgq95e SMMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682461496; x=1685053496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=72+eO6KwavTo94Q3dwD5X6q19DNV6pOCYjiHiYVA/Vw=; b=Kf5An0dXrpB7Fum3P+kZYylRktJwWqPIKNv7Naf+EDW1gDHf5bi/YMFYgeRNuy3W70 EFjVCHspaxZR2FOnDCGjrYzbelDBtjs8S/bzktB8z6I5+jPspSQkFFAN+AhPAsskrr5Q wKUBSjQPcgsyonBWLqr03p3YmoRxEJfAIcCv16+ujNxu+ORaUkwdC/FhmeiRs30mZAQq /otE1UEZZmb9V+U0rqraVawiTBqkFeOtulPklMQG5U8OWAhK3WSxv72QTgHlxXpb0Z5d +YskjdB1Wswg66/vC7TfJpiiO4DbbMxtlY775ObrMUNPy2FDPCYZwRzlpQspBYvD3QYz Zs8A== X-Gm-Message-State: AAQBX9e+p8FP3Blta2BFnPFxDnWrVTtWu7YsQz1QoOFuMoPBq1bPj1PK ywSkQ/6QI9aPbOUJkfMSkBE= X-Google-Smtp-Source: AKy350bcOPFaqZU/Q8Y4YjEKceAGvIRSYtdv5UXWCB8wrA6JhTBamchaYYBw4d9VwQnkTuRpNfmbdA== X-Received: by 2002:a92:c809:0:b0:328:bfbd:1e87 with SMTP id v9-20020a92c809000000b00328bfbd1e87mr8356225iln.27.1682461496560; Tue, 25 Apr 2023 15:24:56 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 13-20020a92180d000000b003244d7f2292sm3833008ily.32.2023.04.25.15.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 15:24:56 -0700 (PDT) From: Jim Cromie To: catalin.marinas@arm.com, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Jim Cromie Subject: [PATCH 1/3] kmemleak: drop (age ) from leak record Date: Tue, 25 Apr 2023 16:24:44 -0600 Message-Id: <20230425222446.170486-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230425222446.170486-1-jim.cromie@gmail.com> References: <20230425222446.170486-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8D87C160004 X-Stat-Signature: 7xa7pjsjbnw7zpawt1ewpdjsgs3okdzp X-Rspam-User: X-HE-Tag: 1682461497-231446 X-HE-Meta: U2FsdGVkX19yJ9DUJ6KNz6XFN/r+FMICnRG29Q0PwAQu/CtouMXgtSeWTSkIqPInJwIn1xUYQQh+5jlrrTKQtJwgJkJ7tvFKXs5DxV7f6FN3Zpg8hSxtOqxcAHqxPSJWvFmMNLkxYBt++zgNV1mVXkFGCOC9tG7HMWurZN2Taolv/2L9FF7ajQz+kIFA90TSIIIPu8CHChzEeRbMblcutmmGU3JAY+QbUkTln5w+MuaNdftSb1K8BzdMm1KwIcudIj757wsJXYmv1vFxqCwcYR9cfd3p6YAM1n44kbKsfVUTSrHlhOD7DdQsxGanVjrncWUeeKnj1urNu3LOeACvUk98bv0v38oyWGbJdDABU4vLscUgcm/2RWindlhOiUhtcPPloODgtta0t9L+tczlN0Ijkv7expCZavWxMUQqgPtF/Nc1bLbSLYL94FAeMqIn881BZICiivwSLx9eEYwnodvP41ZqSrXNc92bhdC+Xwuhw2ww4xG9X3kh4ocWmQinvUdsetlJtZDRCvMCy0Fjb/6M212zwLyjg9awTZwJNsbnwQv6SXVvajHc8gIMWs7MFzxkAr4y4LqetXV5LxcljBIz5s/if9Iswl9VI20rPHbaonEr3JygwZD+/LmeT7kl7zzOHBrVh0uk5/ZJv4bmds1HZknrqjXgmj9c3D8cVU9Jo2wygQu/2tNXw/gVrXl561ZiWKHnQKc1D7JrqUC3NarUI8EOWCSZJoD+tw64rxJ7bhYGmCB3EpDaIoNAwBa2wew0ERHx/7xRmgHUk9tqmEJZbpeb/CjMqh0HdAzkhqhnpasiIiRvxnJJtQQ8HQYbxXpE508VOwiwsPNsPi9xrIKy6i0skAWtyE/RTytxQgYLsg0uihGgKytZxknxKQrGrNjuSPgfc7SYsHUmtiHkHahHZ+uVL+LScisGChKKYGA/NxJzNrcGpi8sYt6YddAZBfpuij1TNSgI5oRKvqn sGiuiAJ2 oSFtfFy9/FymIG1W0RVzGc+zspSQ8UcsdrnXqKDrLuPDDpDbNTnXmUhK/g1oHzYxB8wJqVknBsSMQklgW+rLYaH4e+tlZ7CSfM7pD88PGlvOc7k7C0QCPTEQKZ3qeykTo44xly26Xvyt/X2imd8M5mPj258L4ecuE8togWjs5gDAl/Y4GjFKncfCg5UUHka9G9i/xdqbu4CR5gqTi5ExTOI5GqskQPpx6DPPISqxvYgvtyEMUnoCGI/G7PYFjVWaEybxnUdT34fd2bvsXCwzgIAggs4HXKoGAT63uiwhIc/KToukd81v90RD5ukfyexytM1QJwxVWVzP+e15eC6sBdMmSpUpOMn2bCXVeaEsIcVkbhdVC9tjynI/m5VtE3IvwxgG+oOgB3N+0dvUExpXuUnN+uOrOHy2mm0jhZbzEFzi0dXpQXmUdJYIfJdg+qXw7uZOfaJHVLjxX2RJuiuvFjicG4UAQOtdNkfe1s37g1QHycllKtGudD4NQQYyFQjAmSzTfyRpbKG8GJMBYvbO2LAl6i6Yp1dI7nqUHBBGf0kChQUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Displaying age is pretty, but counter-productive; it surrenders idempotency of the output, which breaks simple hash-based cataloging of the records by the user. The trouble: sequential reads, wo new leaks, get new results: :#> sum /sys/kernel/debug/kmemleak 53439 74 /sys/kernel/debug/kmemleak :#> sum /sys/kernel/debug/kmemleak 59066 74 /sys/kernel/debug/kmemleak and age is why (nothing else changes): :#> grep -v age /sys/kernel/debug/kmemleak | sum 58894 67 :#> grep -v age /sys/kernel/debug/kmemleak | sum 58894 67 Further, age is not an intrinsic property of the leak, its an artifact of when it was scanned, and relative age is embedded in leak order. While userspace could work around the always-changing output, ISTM none could be relying upon age in any important way, and having idempotent output is just better. Signed-off-by: Jim Cromie --- mm/kmemleak.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index a2d34226e3c8..f025c7bc845b 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -355,14 +355,12 @@ static void print_unreferenced(struct seq_file *seq, int i; unsigned long *entries; unsigned int nr_entries; - unsigned int msecs_age = jiffies_to_msecs(jiffies - object->jiffies); nr_entries = stack_depot_fetch(object->trace_handle, &entries); warn_or_seq_printf(seq, "unreferenced object 0x%08lx (size %zu):\n", object->pointer, object->size); - warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu (age %d.%03ds)\n", - object->comm, object->pid, object->jiffies, - msecs_age / 1000, msecs_age % 1000); + warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu\n", + object->comm, object->pid, object->jiffies); hex_dump_object(seq, object); warn_or_seq_printf(seq, " backtrace:\n"); -- 2.40.0