From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8419C77B61 for ; Tue, 25 Apr 2023 16:14:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E9FA6B0071; Tue, 25 Apr 2023 12:14:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69A826B0072; Tue, 25 Apr 2023 12:14:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 561D56B0074; Tue, 25 Apr 2023 12:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 43B886B0071 for ; Tue, 25 Apr 2023 12:14:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0D74F1C6712 for ; Tue, 25 Apr 2023 16:14:01 +0000 (UTC) X-FDA: 80720409882.01.CF9D8E1 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf16.hostedemail.com (Postfix) with ESMTP id D6875180006 for ; Tue, 25 Apr 2023 16:13:58 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WFfs6WxK; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682439239; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XhT3n3uvVNiweRdZg9pUZ8/lOKMThAVg4Q85EU6X5VE=; b=oVSeB5MZLLmBFwePdAqW93TSrK+KjbxcSZGD6NmwxuJnZ129WKa7Tnd4yU/zygD6u+PVe3 wKVDIbRHYi/rToiccw7dnY0LjqZB0/TAPFvFzk49tGlosI8q32rO1NgcPu/MGipyYgfEOR GEIpqEaLdFnoPNKTCdGQyovWiwkVr0I= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WFfs6WxK; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682439239; a=rsa-sha256; cv=none; b=OvIp+0trVIwNQ+F3Dlk5zCCfBweF7aqNDRKCqwWaQ+nUg4Dvhrp61/wiqiLmtLhdD8phep raeUZxrFh6fHJ9oRU3tb7xbAjNYTXu8CPdmOEOQQWXzX4/JTvvj1YroEKcexHaW/px6flR +xVG6S0CF5hW5vr6USEAEnjESxbQOMk= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-94eee951c70so946682666b.3 for ; Tue, 25 Apr 2023 09:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682439237; x=1685031237; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XhT3n3uvVNiweRdZg9pUZ8/lOKMThAVg4Q85EU6X5VE=; b=WFfs6WxKY1IQFGgDPzf2iHSWqrenokOc5Gt4EFNBJCATVwkBuNSKk8RfPWXzsygHj3 a8Bg6AWXaz3GvPqyrnaaEv9N253Le/BkpCxcx5AAB7dWLjCFDeU0rOab3M2oi+yA+FSS 8cBYrzaoV1VWNbSniYDgsLLCg81zPXgDXtLVvHkkmEzgN7VpiqHboUotZuLVb2jfrWD8 U0+ipdpWSQTM55pjMR64xGo3RIT3h/kVw7vlqjXerAqL9e+c/iohxMmwUs4nDy7B59qH JrkwWwxtOArHeevA+K1jZquAY3eNOgFsbEJ530+NxU9ww6AkpJeZ7VdlvsXqKY8sEFvj vmoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682439237; x=1685031237; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XhT3n3uvVNiweRdZg9pUZ8/lOKMThAVg4Q85EU6X5VE=; b=Aa9yE8jx+xxIPUh4Yoc6gwf1D6jJ6JiMxwTjQaZJTPBedhFoajKazPmLJ24b30Zwnp 0dq7l08ZBSSLK4/uVW0z/o9D9ufP6GQu2Xhk3JYNcLmwC4yPlah6PcPTzLSimAy9lSKS IpaDvveXk46CK4WPb+YSg5R32lJ7wlIl1LxNKGSifrYzDxxhXEEG0OqwPghdyEmhTuK2 CfPe7QgBXVQ5ZkhAxy49E/iadaoFz9mjShQyQIJcBvIbre3rK3h1sKNg1pOAuNBPEVcu xSL4qFytUxBzeXatY2RN/dsStYw6qkrC9cwdZ4GNgqXHq2VM4ynWFEOY+6XNtzWEJvnN 9GiA== X-Gm-Message-State: AAQBX9d1VmU3nHOXGohJqNZmor4NM8dnmlLxUOZUw06YtCiAidxy9ys4 7QYk/LJyS0KStBm1tt4e0NE= X-Google-Smtp-Source: AKy350apXHXANa6lU99sj9JOBLwy3DdpJ+lJXgTkFgVLybI2PXebggl09hdoFLNDuyzfwuS7xrcUvw== X-Received: by 2002:a17:907:168d:b0:953:4775:baa7 with SMTP id hc13-20020a170907168d00b009534775baa7mr16049654ejc.52.1682439237379; Tue, 25 Apr 2023 09:13:57 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id s22-20020a170906169600b0094f3132cb86sm6897083ejd.40.2023.04.25.09.13.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Apr 2023 09:13:56 -0700 (PDT) Date: Tue, 25 Apr 2023 16:13:56 +0000 From: Wei Yang To: "Liam R. Howlett" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, Wei Yang Subject: Re: [PATCH 02/34] maple_tree: Clean up mas_parent_enum() Message-ID: <20230425161356.yfjhn2uoq32pbp6r@master> Reply-To: Wei Yang References: <20230425140955.3834476-1-Liam.Howlett@oracle.com> <20230425140955.3834476-3-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425140955.3834476-3-Liam.Howlett@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D6875180006 X-Stat-Signature: kpfetbo3q87dgr8dj9tu5rq6sc5patf3 X-HE-Tag: 1682439238-816689 X-HE-Meta: U2FsdGVkX19HM3jjKyOxFdAStLxoi58lTf480LUFwDLgWG5GrJHMnOB3qzMUfwNhsY0uSE9/iB73pxzjR4Q//6TVl8tv4V3nhBuHOYrB25xm7SGlAWpcaI7S4S/JaxOhwPdugnRo+30cm0YBP+yAHiBRhR8uaiV06RKtb/6vZRSwHP7UU1lkjYkLGjASYRSuIpnqEPtaNocOHhJqomM2jGhBYkyMeKQuvV4ohElnP5IgS6F11neVTsktbekrj5iyU2OUJ3tfuKFUT3JC3gWPP1CbnHkpFeoN5u/CWVXAdYmhsgZRcqPIwQ1ZJz/eT/wMj58+sVUccqN90KyBULzow8/m3zoxxgb3/ExH5clPkuUT0jVkxsc77VgNYh6an0zZJLplPfjIBwpmPy1721cen+Z8nVBA5CQsSPK6oYLHJJp6aP5nekMvFXrIkFFUppW3b3cTYSUfCFGUCvOugk6+iaZtg3xYz44U3S907Ggn9bqxBnsgMvq1W9tpFWu07p0++TfS67b/jRj57P8sQ8Nz2BDfI/YB0CrcZrxFYZS50CiLMn23MsajX79TbEa6pvghGo5JzghSIFsPXsA621DwShMucxQtiknUgQM85H1XDY+7jQkbYi5OaxCe7gB2RPVX6+7jYT0ahlxVaT3/kThZPADHkrYPy7DyRPzBKG2fPyIU6ggG9fukI+0m/GBzCcB+2CQc+MtzKWTQ2AqNQDTjbFYraAT5bcnG1LYTOBjsvCOo9x3yCoPw8o3gvhLwORizYpfcbLphKPU+blTVNxIMzKc2HgLaV9aiCmg+e+YrsN0At5iPsVAjpjLLGonZrLaXbFelOR70Lg+ASjrv4mgrDFgVZcV62BecGP16jz7UqQpVNjjhgr6hSHpx5aJWymJIMyu6tVZQhyxxm8W31X2j7+F7rteR+j4Yp2jyX9uxICGb526dk39GX5JzuJr3Zq0yDJHIT4UTNQ8GWKRbuHZ HtZThyBS Qw71pP1zqtp93nXhldD7JfRMpgjxL6CVr1xP+X7GSG+oI6aDPoFM8KbrPMcaqBS3f9nCDGRQGrEc9pvo/a/hdpPu1e6ncT4cAvhU3GClbbTm9/xhVxb+TbSn4hjAghbMT4N9e14aUFPIkBdyoxnpTDrmZPAmB6pMCctf5xp4A3imuHWYCHmP9K3UFrXX4DN74H0omTp6eBrXSz1yQKQPMeZSRcD9HVHtTprH2I2db7tPCfJRfvujbdI5KLnIVbiTvQpIbuZEx3wB1vuA2z/dbX60BDSMnt57X3Rh3NXm5i//K50Wv07u1Xst8dKLxjv9hni2caATyyzq/KV4ZOKsc2VUfNcgt2Vj6pakfOizp5LhHhaG1sXMMCpYYIw7S7apqfVx4DV79pPucbCYvsCVjXg1YaH5LIzmLbo7GV7olz+d9B/ZSV/EKiYuMoirnB1Glg91AucHtrZmlaVgNOGwMNsTiTBDdQyJ/YIoYs3SbAERGY9qATfe6scRl/uOv5EPAfWIwW7r4G5MkRza0MojS0yBo2Z9jQ0stW1hB4clbkYg/8IxRvw8Tx03EuIM7fm23411fEK4KyVnrxHK4FPGHLOBEDRWVz4yugCjd47DMnro7tqy60ikPvUefaU6ytwDc1JW63zLJn9ZZUOpBZC8yzDo8qjxKDFwDrGASiZI/dSkwuAyEcb8FX2PvcyTILH+dE62EXfrO5VwgJ3kJff69IIwH5gsmPOHO1heKnRaXuTxohHViQwbC3S2VaYe7Yqqw3NEh6adJqGavoD2IxFwssdNZQrZ87W/7YDRe44qbSGc9Drv5HWMukoDAzLywaazL+/iaIvtGQqRLf8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 25, 2023 at 10:09:23AM -0400, Liam R. Howlett wrote: >From: "Liam R. Howlett" > >mas_parent_enum() is a simple wrapper for mte_parent_enum() which is >only called from that wrapper. Remove the wrapper and inline >mte_parent_enum() into mas_parent_enum(). > >At the same time, clean up the bit masking of the root pointer since it >cannot be set by the time the bit masking occurs. Change the check on >the root bit to a WARN_ON(), and fix the verification code to not >trigger the WARN_ON() before checking if the node is root. > >Reported-by: Wei Yang >Signed-off-by: Liam R. Howlett Reviewed-by: Wei Yang -- Wei Yang Help you, Help me