From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49806C77B61 for ; Tue, 25 Apr 2023 14:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D05996B0071; Tue, 25 Apr 2023 10:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8D816B0072; Tue, 25 Apr 2023 10:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2E126B0078; Tue, 25 Apr 2023 10:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F0526B0071 for ; Tue, 25 Apr 2023 10:26:47 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3AB7C1A01C3 for ; Tue, 25 Apr 2023 14:26:47 +0000 (UTC) X-FDA: 80720139654.29.51D9C93 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf30.hostedemail.com (Postfix) with ESMTP id DAF938000D for ; Tue, 25 Apr 2023 14:26:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=yOxoxF62; spf=pass (imf30.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682432804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NzQgQguk3FOOn5Q0sl8SuL93RxV/W/XH0B4cmOPUOrU=; b=FgK359z91Rtv6WEZcZ5GcYvPBAkktpgbN5vyaPriEaRy8C/MhDhWq7hj+J9S2yrBnkWvI4 zg0mtTCJM7t3qxcUN1KziyVQUYBn811+MQ1Aqpua8KgyHAEt69AVpTt5HfPf9xtnN0hV5h wCULC0yqT+CaIpyCyEKSDd728xK2FD4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=yOxoxF62; spf=pass (imf30.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682432804; a=rsa-sha256; cv=none; b=QJmOKal2MlsP24Wi4SII6jq+tJ5uxhkwRwi++KnXm9nv92GTTaxME9LOeCpCVWxYNIb7JW gyJUDY9rjZPfN7YcBIzV62AbEeijkUHhg718k3o8Z5TwKmWh+VpS6YMqJYcoqSYzevses7 wNcDlRi9DfSyOOEnxL9B8Gqd2eUwFoY= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-5ef41569a3fso26072396d6.3 for ; Tue, 25 Apr 2023 07:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1682432803; x=1685024803; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NzQgQguk3FOOn5Q0sl8SuL93RxV/W/XH0B4cmOPUOrU=; b=yOxoxF62ERjNeWj+CJa/Kah64bkFFMllNsu/eOE1VPjy/CtwcA4FxevLn1O/B4+AY+ zfVO2T4iq6YWlUNEovI2VhyRBeqpSobmLFeaPBC790F8WxXVf2FT1xl83r3qVq+EGrsV IXaeU2RXZDlKh5LyQpUjFc140qZ447SZe8eQ3SwWZVC9XwDXAaTs7wXKISggALCPIrYo OMRTE2bLujG0i8qn4lvcsLiNYH1xdiBg/ug9sYv9Mn+NoV+jiCYrQMOv85l7AaIUuVoN +sB4aDdp2H9N9Nu7hdKDXR98TnMR707C/ZsscqiU3PpsaA6nhgtN7PAfb8QEsh+CXdwS JDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682432803; x=1685024803; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NzQgQguk3FOOn5Q0sl8SuL93RxV/W/XH0B4cmOPUOrU=; b=OtkpoiNEAhBIkoBRAR20vWXhu5XF8kP893JRS4xo2/6dYku4c+SpX/Ij2V/2m4EI2X ykKX4gKm50JcP88dXTpW/6BqnQeS2fAhZjpzfGvbA1AzypZJipJHmjWa3zQHj3ZfrE1m r1kIcmIHOLqK7E2OZHrx524qDlz2PMYCkiBNqe9BeDMsHEX0ESUVuQB9m8My9uBbTg4w WGGZqrHKCgrHLqPtd/cgzfFT3/vqUMRqjNCJUHLIIeikAiSztr/Caqwu0zCmwZnm+TJR c6149/JK8Rgi5vS4Eoe1smjG57sogt++G52IEFn4W7pUqf9SgCMibqqDpyj9xLQ1BUw+ WClw== X-Gm-Message-State: AAQBX9dzEtIIpgzX5GQgZQflOy6sN3/J/tUa7kVCN/J2Lp74Cug00zys nPNxYVIlfeXtphIdVZNr7Tucng== X-Google-Smtp-Source: AKy350aVJB8UWDC5ePhBp0/DKlzvTUR/3tZD+AfBmuBDgB9VXbS/x6mF8kc684QsCsAoWpDytYxKqA== X-Received: by 2002:a05:6214:1c49:b0:5e6:1723:a7e4 with SMTP id if9-20020a0562141c4900b005e61723a7e4mr31244225qvb.30.1682432802913; Tue, 25 Apr 2023 07:26:42 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:9fc5]) by smtp.gmail.com with ESMTPSA id q17-20020a0ce211000000b005f5b71f75f3sm4120360qvl.125.2023.04.25.07.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 07:26:42 -0700 (PDT) Date: Tue, 25 Apr 2023 10:26:41 -0400 From: Johannes Weiner To: "Huang, Ying" Cc: linux-mm@kvack.org, Kaiyang Zhao , Mel Gorman , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 20/26] mm: vmscan: use compaction_suitable() check in kswapd Message-ID: <20230425142641.GA17132@cmpxchg.org> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-21-hannes@cmpxchg.org> <87a5ywfyeb.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a5ywfyeb.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DAF938000D X-Stat-Signature: rd4d9dtidfzk3b44nz6xzkip8i6b7wks X-HE-Tag: 1682432803-493273 X-HE-Meta: U2FsdGVkX1/WPkuYRozhQgIjNrbfqKtxUuNXkmJ61EisyDojui5iwrapjdUYYaGD9JfH9lrBvJX3I0Pb2W+iVRDPzSbbb8Xnj+WL0qak9/NKwbF+cF65vfcSnsyDM+5bdeBOvuNHD2icKf9jN9iMSorpic2EwpAelksES0A1JVr6qCN8/xZ0BVrJnMp6b75z83yfcuaswqph3Grv72AklnrWm8r9qpKmOxWsKBovRxUyjO5udXhbuPqmED73I+VpmS6k9BfulnCsuTAHzfLEEYecRoMXOoC0LfN4BUsf6u6fj0mX7kfmq1Bt2zrtKY7FY1Ic+1PjCmJnxYO7t2cQeK5Mwne0EldezqClOoFHBUJXuddANa7gasx7woQRtev5pjVCqfCwYlWhMG8oF4BVTuOkIlvr/9O6zhrJRt304zs3NHGAfgwEnJAel99uMSXn+oAW4feGfR7SGLAg53i0JK6jOQikJVtJgz8B3U10fdV1VJ7AsuWBmNwI1tMVrB/IRQ4zijSMmgmA/TS7yX0y0fIPh65u31hYbM3P2TI06Em4Y++kQX8wwdkYXKo0rW5QTfYvIyZ5QIiOS4dEj4Peu02e9byOjbR+R6QNU+LqYAYCv3SaCvS4MHFbf2DBKSgO6ojaBSARiQSRu9wmWBZFubqPr6tb/UKhWBDBOlGWt8AQAcup/u1HAxbbkUVuNV4qLIWgUzgtVZrZsMG//ZA5KtuYQWNAE9QoTXonDn8Y3Xaj8XW7Tvidlr+yX2yiNFkx0HTU8gKehj7Ze6x9ZQUXUMSrZMHGGkz9sQAtZSzuSy/YmZmss/oan3vtDR5Hv9oKrzdo8XyPy48QLRL0fspR1UqqhYGqYIeSUm3GHTWT8xXhbdUAmkkzGebVBahqhAQiMN7u2hdz4coOTx1eK07IPObFImeBAr99vgk2rs8r1A6RMnah9Dsyt8z7GiSphq2vnltIFnPAf4MU/uW6wux A6AaEtx5 zPOniLSjIFFHq5sINKhr1qAvdejmfsewcQaHjhjQWgC/Xu9iLhexZ8LLZKSyfe/u6N11SEawdDshMiu40/tyvSeg7o+x+PxW+IQX4Ybh+50icMq1/3rxCTYa+bJJBo6JFP8D5u6VErmpK6s0Gu4L7MMgF57q2R50yFNhW2ngVSac8FhnkVvM941bAHABKE69FiV9eIxWW/1j4ItiZWCJztBdRyr3nKialkNUV5E0BBBdwEio8OMD3j9QhKZlQX3HeqBFzWZv+6wLpEAGHvmKIqBOwxn9GAia1By9NZIQBB80ZrPSYR/OV5AFvPxrd6ApqJwa9ItFpZZvST0mkt+b8q18kudiKHZfQMQCoyHb1JjsnB+Oyw/2NZN4gJaa1SnTmZKOExdsxu+ZqmBsWZoE10frdvsvKrTEBxNwQZXGh3ck/wEPey5kRvGnKodJ1Erb5jrZjikNSFtw3idUl60SNI+2cu9G6O9i6h/R0Sg5SZKnQDplYnvCX8fDpPFYSl25C0JMcb9zjJx55HaQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 25, 2023 at 11:12:28AM +0800, Huang, Ying wrote: > Johannes Weiner writes: > > > Kswapd currently bails on higher-order allocations with an open-coded > > check for whether it's reclaimed the compaction gap. > > > > compaction_suitable() is the customary interface to coordinate reclaim > > with compaction. > > > > Signed-off-by: Johannes Weiner > > --- > > mm/vmscan.c | 67 ++++++++++++++++++----------------------------------- > > 1 file changed, 23 insertions(+), 44 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index ee8c8ca2e7b5..723705b9e4d9 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -6872,12 +6872,18 @@ static bool pgdat_balanced(pg_data_t *pgdat, int order, int highest_zoneidx) > > if (!managed_zone(zone)) > > continue; > > > > + /* Allocation can succeed in any zone, done */ > > if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) > > mark = wmark_pages(zone, WMARK_PROMO); > > else > > mark = high_wmark_pages(zone); > > if (zone_watermark_ok_safe(zone, order, mark, highest_zoneidx)) > > return true; > > + > > + /* Allocation can't succeed, but enough order-0 to compact */ > > + if (compaction_suitable(zone, order, > > + highest_zoneidx) == COMPACT_CONTINUE) > > + return true; > > Should we check the following first? > > order > 0 && zone_watermark_ok_safe(zone, 0, mark, highest_zoneidx) That's what compaction_suitable() does. It checks whether there are enough migration targets for compaction (COMPACT_CONTINUE) or whether reclaim needs to do some more work (COMPACT_SKIPPED).