From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6529CC77B61 for ; Tue, 25 Apr 2023 13:22:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA5DC6B0071; Tue, 25 Apr 2023 09:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3B026B0072; Tue, 25 Apr 2023 09:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACF936B0075; Tue, 25 Apr 2023 09:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 996536B0071 for ; Tue, 25 Apr 2023 09:22:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5D1C0AC539 for ; Tue, 25 Apr 2023 13:22:04 +0000 (UTC) X-FDA: 80719976568.11.D2911E6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf20.hostedemail.com (Postfix) with ESMTP id 83FB01C001B for ; Tue, 25 Apr 2023 13:22:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hwKQuGvy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=odSorB+J; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682428921; a=rsa-sha256; cv=none; b=lTasWj2Y0JTVC+50sGG0VPOxuYJHVy5v2Mu5rVikoQ0mDOQvpyppAsDjQEX5ZTiifD48Sf ga1Rk6j31V0kubETpEVjzVXPRQ3CsIpgI44D3c4Ga5tSh2pCiNA+y0Om9bSzNWrzPQsVT+ 7sIkp3oGrZVhs2djrR35GWG3hCXrppE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hwKQuGvy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=odSorB+J; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682428921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z9Ct6m1F90AsrgQQ6lr+xNgx5dYzgpTa/d+gY39u8l4=; b=iV2YASBx9+vvhbzpZDk739uqwHwpc+u2GDXPCRgYNR1Pm0j/+F4VkaPjdak2xK9gxbEyn0 9efhNwlsyzjZtejCPPany2GKtTR8ZJNNMd/XM5CHZXr5rPHYItoVFy0bNFLxbWoskN24b/ gPSxaBq5PfPcWkeSHDq4Y/O+GR53n8k= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BD82121941; Tue, 25 Apr 2023 13:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682428918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z9Ct6m1F90AsrgQQ6lr+xNgx5dYzgpTa/d+gY39u8l4=; b=hwKQuGvyhUjffrLWjzFWKZ+d0mJ4kw7oq/SRNjMV2mzwg8BFQ6+VDPbm3lB3IHlK0CWnuC 263rA6NvyBeEa+UhR7g7iRtrFgbcDoh2+9xn6xNriFOVv3EkzTp+rznVKTjjnjxZwuGYKs Y7WrtMCd3QdqX2EXO6E0oNWuLOw0918= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682428918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z9Ct6m1F90AsrgQQ6lr+xNgx5dYzgpTa/d+gY39u8l4=; b=odSorB+Jgw90gPNFVz2kvE5DqxEaKnBuabuW4NRuj+CCE1569SewCW2lrrneJF34LI8hmo qB4+HJx8yhCuArDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AEE4713466; Tue, 25 Apr 2023 13:21:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Iq+mKvbTR2QVEwAAMHmgww (envelope-from ); Tue, 25 Apr 2023 13:21:58 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 523D4A0729; Tue, 25 Apr 2023 15:21:54 +0200 (CEST) Date: Tue, 25 Apr 2023 15:21:54 +0200 From: Jan Kara To: Carlos Maiolino Cc: Jan Kara , hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V3 6/6] Add default quota limit mount options Message-ID: <20230425132154.nxaxyyhwupelmma5@quack3> References: <20230420080359.2551150-7-cem@kernel.org> <20230425115725.2913656-1-cem@kernel.org> <20230425123042.ja6oab6yhtzqnwyl@quack3> <20230425125610.xjbkxlozfvio2ihh@andromeda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425125610.xjbkxlozfvio2ihh@andromeda> X-Rspam-User: X-Rspamd-Queue-Id: 83FB01C001B X-Rspamd-Server: rspam01 X-Stat-Signature: 7nccecoyupzn9earap4w1zsfcsouxjrb X-HE-Tag: 1682428920-5451 X-HE-Meta: U2FsdGVkX1/Gc4WWm8IOwwAugXByZh33S1ZjbOz808YBatY7RV4zkIcIRTf+9FFaASMrWV6EuwWQlKeSQi6qEI/HYdC2orYDT964RFBzXljVKcCLXoTg6R3hQIzJGNSJjPAxvk6aVPBli9CfdV06VRzi3aGsPWxD/ZkeukLposzyeTBdqy+kakw9aKO1u00WN4MKx44hmUGZVEqfrOMNVM+Kivab95KIg2Z/oO2h/IAEXYeOU8Vg2iDuw0SXHJEhe2yz3hT/W9yXTvBGiZ8gkdB7PVdTsWGeufdFa/jUniNzUQood0XmIK+L5d54PQlYu71I8EjV113PUuShUNdUDDoa20kUgMlfh+CZSxpHYxqMHGTLSdVVq/Du3xpmdPoKsYoXEWvHkydU2RSuVsGsYhu3KhY4AKB5qR3etwbvU2+o6apNCpcRRnr8E2qdkB3YyJ7wR1JvOnN7H5NcmUxi8l4GMvxjpISvKc+j1EiAFkpVcZFddHIVvo1qac93EtlKa0G8g+K5pE8CjEvARausOlz8cc7RM7vkRwVQxoQLsIB+HES7y9hbZiCBSlBqeUhgWpm7xeko2ZluTGv+mUjghfoI+aCdfvGX4iNKO4Sske1ylPmBSFlkSmJyWhcdQ/IFeOCC5uNMmAIOQEiNKRY2krfSqDAGrLJ4oD2OpX0DJ5YSx8WNjHDS10xZ0Se4IuBhKCeH/9ZxT9RnqVR2njH2TgrvHj4MtTQio+WKJf8ZO859c9opaiFvzdx3iGq7aH0lvaaUvIoXLIKmulvexbN94TRW1uiMrNftvWeGe0X+2/+cHHZb8HwxUTcmpf3eziqm5nXUDL4tBisCkcwBc8gOrQpbNDCBX2/sG+/eGt7ZvFuv8AtlaxFCblPkEFl3Va7549nmdWBrdht3MEhM/kx45Rr7UWCVXsIoDVE/lVIPDyEwJbbZKXDK+U7h7Yzy9BLmAT1/qUUeKTDUYbZQNTT ZSGPyMCN DyIRTzkDL+ps4OFZ7h+g2GV45EZFO7C8cWtjmME+bjB1nPexldKT+nvuJxtHk9GY8ECONJvIP19fE0QG69NRJahdx6+FlnDAbXnrDnw6kT+8Z1/CluJwDDUzCx2IDL0jW/V+yoGpYeTxUK3VOHm1Yu+2CEA5f3Dx1W9VeqAXkW4KHJNw10rJ3UYV/w5XvoW0SollyPhRyUrju+JY4KJIrlal4y0J5j2Z1V7kR3tMNhcEwNUl4SIV5gxwFQFvt+OhYKLTPPglbDViT6B3aeP+muIl1pdx/3VTYnHGgTDjkMEB7c0q51SPBcQZd5Nal38VaOG3tzYt3BAkeeG0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 25-04-23 14:56:10, Carlos Maiolino wrote: > On Tue, Apr 25, 2023 at 02:30:42PM +0200, Jan Kara wrote: > > On Tue 25-04-23 13:57:25, cem@kernel.org wrote: > > > From: Lukas Czerner > > > > > > Allow system administrator to set default global quota limits at tmpfs > > > mount time. > > > > > > Signed-off-by: Lukas Czerner > > > Signed-off-by: Carlos Maiolino > > ... > > > @@ -224,6 +233,29 @@ static int shmem_acquire_dquot(struct dquot *dquot) > > > return ret; > > > } > > > > > > +static bool shmem_is_empty_dquot(struct dquot *dquot) > > > +{ > > > + struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info; > > > + qsize_t bhardlimit; > > > + qsize_t ihardlimit; > > > + > > > + if (dquot->dq_id.type == USRQUOTA) { > > > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; > > > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; > > > + } else if (dquot->dq_id.type == GRPQUOTA) { > > > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; > > > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; > > > > There should be grpquota in the above two lines. Otherwise the patch looks > > good to me. > > Uff, sorry, copy/paste mistake. Can I add your RwB once I fix it? Or do you want > me to send a V4? Yes, once fixed feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR