From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA9FC77B61 for ; Tue, 25 Apr 2023 12:56:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 387FD6B0071; Tue, 25 Apr 2023 08:56:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3379B6B0074; Tue, 25 Apr 2023 08:56:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2263C6B0075; Tue, 25 Apr 2023 08:56:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0FA416B0071 for ; Tue, 25 Apr 2023 08:56:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CD65740002 for ; Tue, 25 Apr 2023 12:56:17 +0000 (UTC) X-FDA: 80719911594.16.8F79CFC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 2C4E340021 for ; Tue, 25 Apr 2023 12:56:15 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=enNPdstc; spf=pass (imf17.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682427376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EH72W3at3X/XCWupMJtkWObMjH/ZNRtMYtsS3aKaTWA=; b=4TA4APfbuCmUqyeUIpCE2nBRuDMPfNuj0vvBjzr4cz+zO3SDRijD+BVhiI4MHoL4G2gRxi hUYoZsOEI/DcbnaMvQ7ArRBnB/tFDxB+CPhyolhg8RdwE5GR+l9IOe+LvGOzOevKgmU3rz FImqDFe0XpYIQRrdXCNndFZxBZiBCTc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=enNPdstc; spf=pass (imf17.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682427376; a=rsa-sha256; cv=none; b=C4HiM/Tm6Jn33GqxW4A0U3iun6jnLMcVa2+8qSKMno2na9uER8AEmdpDqL0iVbz/ykmcK+ 7phXK4T7uS3Okyv44ntHV5EJeqTA4BeTpD0JIdtIMIxnOVHZUW1kl6CtMa/p85YYBThstd sdLkFQ89Xj64itPJ7aNLWH0riBFsZ5k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 143B5615D5; Tue, 25 Apr 2023 12:56:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41545C433D2; Tue, 25 Apr 2023 12:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682427374; bh=gVGfA5ZlFxWtmoGDNRKOJuot728x2y0cce+aV9eRCr8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=enNPdstcCR1OaTU62ObPEv1xx9KkVtuqL3DglGygH/RA8UgdxPFBCDaQk9SLrPvC9 XsVsHVfmuPWDnoP+jxvhLgS6gRelh9TthWhmNjWdk1w6SF2QbobfVp3VVijgGEqOJx XjKySR1cF1KI5RVToMpd0GB4JaGxQ0IBjAMFRXTdZ3EBo78NerKHRRfTyYGueOrxcr Ve7rFZxpbK5ktZ7McseQVjavds9gxEgT7G72FWhbNSnqqA7twRlDkXI/2ePUr6XM0X ki/YrXumqYAr54c/pRHiR7VTWdNgMGbLqyYWQ529jbi+vbWM9uBGfsjEwqSym+WQOd RPA1t0gfKppDg== Date: Tue, 25 Apr 2023 14:56:10 +0200 From: Carlos Maiolino To: Jan Kara Cc: hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V3 6/6] Add default quota limit mount options Message-ID: <20230425125610.xjbkxlozfvio2ihh@andromeda> References: <20230420080359.2551150-7-cem@kernel.org> <20230425115725.2913656-1-cem@kernel.org> <20230425123042.ja6oab6yhtzqnwyl@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425123042.ja6oab6yhtzqnwyl@quack3> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2C4E340021 X-Rspam-User: X-Stat-Signature: kqh47u77q8b8ekpdwah7dsh3n3raoheg X-HE-Tag: 1682427375-160979 X-HE-Meta: U2FsdGVkX19OH9FrKPe8HeqQpnC1azpcBjwdybzbzBGDkGnZrWQwz/2LbD5bS1CvMwHHXlLx+IXNWBOeoBimMwgAq4jnw2MSt2pIXM6lLotJ4nBe1dkjgG9p6bmmzzmJ3ezssONBkxxzjNyJFh1iDTv67aWTqlPixgfzcJGuh7EacDKokshwVQSF+vlCOnqlP3lf6dR9DIGXqh63PB2cmZw/2rrs94ss6SJtufof98vaV7VL9MAp1wSDsy+eTyRlFsSzIjW9mPokwnMtW46WZfsagNW330UV1uKzXEQosImM9A6we4WDASiPHba1FiYmFWhw0SE38cSKR3OhPPBMYDKIgxowDGpcWyUqnjmgNFp7uTo+rJ4UuTm2WDhQF/gl2YUMeEr8P5yluGApecLoPfJhWngCy4Xi00iRtmZ/O3xn8qA8RXoxURqg2WBVYEzCacBJRjBXPRng+UG9TgStTSgxlLUni8/pm3LGIO8FQO4RVQbVEZ0AjvXIY+vHFEE1+5uCudE/zaRUqJ7NyXTWGwggKKIwFk/oXSvjRv8Z13emrO1ba3rO+v18QWh8Yf3sSJswmfMHl7807uoorf+0QrE+/G1qXs+sV2/jlnCbocRU/Q58OBTYbC7RvKWcirfbc5Zej7OV1ULZWVaG/mLpAGaHLH+C38NvBHCjWrAtfyxU1FvVXbr4wUumKFWGdQo5g3uHLz3TvAMrTdZoOeHUmSeMfkSIwINYtkOFIIg20VqwMZUjuTOOUSLk4PTVcsetKNaODBC3fmkApZGt3x3iAnEbUjUEtx/Oje5+dvehcszJoh/bk5RXXiPhHirorF7+jsoxcAQMGlUUwWxfbjY5UU8Y10jU19Eoc3H+4gXh9m9+0LAZ6bf6qRjs0SEf9fd2QtYZ+gjHUpTtx4nHuablK8b7RWfb5nI0Fe289KNqwXVIRIwcgYte4bNIEUqDdVRTVoVWA6s5tBsJn3E5CJT S0gxS+jh z3RNE4F20H5onjHtjkgli5m8Km7zz7E7xm0Xr3CVCg0+ZHskU8pO3V1Fmir0q9XFY0/wsehLHgXRM104Yfd0hVoQ/FAaHSHkdXGDbL+uv57oduUhOEd6xHlKVFQNWyLgfr/Kdso4pR/yr699bTV2rNciUUPFSNiSeNjRhMp99CqxUoYIMia15GkIwr1kUybdUXyQqyvp/zlMyrxcFZetVEvY9okZWNkpATGxRReO34mq2bfaMIZiaplsJjKqLb+ghtTTq7SXE6JpFPq/GCoFh7bGtfNV+gTTJ08iR3GOC8RkXud01/9KZ9K9o8x4PMP1TddBWi7NLebejwwfBe22LFsbFzHl1J/27uloJJDoLv6TVcw5XMuaSQJyWp89gcR677tNem4zwiEHhefk9B3rtFKkFhEubTKsgV3aQ0yCe86lhGpI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 25, 2023 at 02:30:42PM +0200, Jan Kara wrote: > On Tue 25-04-23 13:57:25, cem@kernel.org wrote: > > From: Lukas Czerner > > > > Allow system administrator to set default global quota limits at tmpfs > > mount time. > > > > Signed-off-by: Lukas Czerner > > Signed-off-by: Carlos Maiolino > ... > > @@ -224,6 +233,29 @@ static int shmem_acquire_dquot(struct dquot *dquot) > > return ret; > > } > > > > +static bool shmem_is_empty_dquot(struct dquot *dquot) > > +{ > > + struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info; > > + qsize_t bhardlimit; > > + qsize_t ihardlimit; > > + > > + if (dquot->dq_id.type == USRQUOTA) { > > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; > > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; > > + } else if (dquot->dq_id.type == GRPQUOTA) { > > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; > > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; > > There should be grpquota in the above two lines. Otherwise the patch looks > good to me. Uff, sorry, copy/paste mistake. Can I add your RwB once I fix it? Or do you want me to send a V4? > > Honza > > -- > Jan Kara > SUSE Labs, CR -- Carlos Maiolino