From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA4FC6FD18 for ; Tue, 25 Apr 2023 12:30:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5667C6B0071; Tue, 25 Apr 2023 08:30:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 516156B0074; Tue, 25 Apr 2023 08:30:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 405406B007B; Tue, 25 Apr 2023 08:30:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 31F796B0071 for ; Tue, 25 Apr 2023 08:30:47 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0698916013D for ; Tue, 25 Apr 2023 12:30:47 +0000 (UTC) X-FDA: 80719847334.02.4E71247 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf09.hostedemail.com (Postfix) with ESMTP id E5106140011 for ; Tue, 25 Apr 2023 12:30:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pbfmxOo4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wxsbKQyZ; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682425845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f/eMe0Yi26O4GgnxAzwKKj8+VaObX0RFaPTN5QrSbSM=; b=SUI78oIvjjsFRCbN5mbS+1CTYqAWLRbUCvETA7BMSTSrKopKGrM4SgJyWCTFv/BH3PU6gT iOz0tfXtfC3KiUKuEC3rNEPlPO3mXPu9cLvux77BZS82f7h/Ub/ZBzQPqZMOT6eM5JgLV7 /7SspPgR6cH5qYWxUE60fF4XB2FeeNc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682425845; a=rsa-sha256; cv=none; b=OMUKC860YtnAzybaAMq7s2ebawrRL60VFu8Fd/NvDfBqP/eOoSKZwYStKA/d7iFmxqPlcu J3U3BwFykSPyXgod7LqJKE0dgJMwPtcnt8orzagYRHlaXOwAcl9Uf2c58fW/U+K3U3lfXV 0wFl5KhO5syVToTr9ea3wDaReRowUVI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pbfmxOo4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wxsbKQyZ; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2FB901FDA5; Tue, 25 Apr 2023 12:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682425843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f/eMe0Yi26O4GgnxAzwKKj8+VaObX0RFaPTN5QrSbSM=; b=pbfmxOo4TAaQIk6drgeO52YWU2cdDpUoo+17MLTrMfHTVRaV1R1936FvwkqERu5mPCxFnw 3ZY3RmfALMvpMHtpibbcW5UJHQ1+UWtcBeV1BxjRAtrdJwcxpZ82frDoXp3sTY+iCTPoTk FmOWws5EYVs5Jxbi95Vd7gIBmDaSRXk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682425843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f/eMe0Yi26O4GgnxAzwKKj8+VaObX0RFaPTN5QrSbSM=; b=wxsbKQyZTzxh3hh91vMNeCPuyGYKzDzVKT5wqgpR0ca+Q3wWh/783LNPz9jdTkg7lsFTp0 0KCywCWZqyXFOBBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 140BA138E3; Tue, 25 Apr 2023 12:30:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gt/gBPPHR2Q6cAAAMHmgww (envelope-from ); Tue, 25 Apr 2023 12:30:43 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 8B799A0729; Tue, 25 Apr 2023 14:30:42 +0200 (CEST) Date: Tue, 25 Apr 2023 14:30:42 +0200 From: Jan Kara To: cem@kernel.org Cc: hughd@google.com, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V3 6/6] Add default quota limit mount options Message-ID: <20230425123042.ja6oab6yhtzqnwyl@quack3> References: <20230420080359.2551150-7-cem@kernel.org> <20230425115725.2913656-1-cem@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425115725.2913656-1-cem@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: E5106140011 X-Rspamd-Server: rspam09 X-Stat-Signature: dzy3qjjmw5qrw16jj43epetuhto5idhf X-HE-Tag: 1682425844-193209 X-HE-Meta: U2FsdGVkX1+4GfTGZa2yhS2sgbtsIExHoGuzOZrgSpuMzw8usA0ltO23GCmFxZDrk6JEuVt/HoaD/WEw7iwhEVLOhTAkRtUF4qENpy5TF/c4AeDrfBKGbIxQBAxAaJn/0Qi52wxkLkVygH6YqpUDLS63/4nxNZQODYm6hfBHyx/yPIPKEqtr06EpPUtLFBuPEaeKCpXQNBsgX52GYaIK3ylpTMUtRFKrYay5DjWGyETeivE4TAw/6gtBAsvLYHKDl/J06lay5dUElyE64ZqTr92uVOLr1d/WqnkHy63fREE2dukIs1T28Bf+vtemaGmfb8NlN3tH42xYX22tmhMmn1IyCTL/T8UWdeStFIXRtKDJt+6tJ30U7RAG2gQT0HDBtmQpK7/iQK973SxdJgWFc8ywIlRBkonl8KGE3mlp9pWD6jthsvLZsyiImRhMyXg8bK/eVR1NX7xFkRR2zAzxF9ODDKh+NYzD7AJ/OV6ruWYnrtM+5lY4cTQkJ1K4RfT9XEXx3Y1eA38DzVNSO1Kc6SDgl8NM4IpzcDdQX66100V6EN8it6bhSrqQAWBGhzEyH1rtJQDaZP5GmPXt7oWAB62843Cw0QXZKmpEdgV9Ef0cOIo4KV/vaKKHW2zRqZiiJFdGd34RfUm2hfoEAZag1GGKUXSyBk5nna4sqwcd8US3592UfqX63fmuUaxZnQB167QFBIZHr1cyx0qqbR6HurwUxEqVd/SD2hgiXUQNU+oPNEUGXzoH8Rx+hT02ptkL793f6Ojmso1ZkkN5GFEwojcvZZHTjgY8N2+MsFaNuUXue7NFt4u1dtv18TRiHIKAIzhu0nYhiZzNw38Fqp1Lasj//LkJKa30JPpCszAruaHgb5pFchKmEh5Jokvf6x6b/Q/UBDPRa62ZcipBW5hLoKt1nOJJJGh9nFF/INlK7CcEIg82V50UDAkN3vnrwPiHIKwZJTn5zh7OP/la42y CsQRSIIs waJV5I5s7i1nQs+CJf9WtpEQpbkhL70NF4r0y+8NeMD4lzY5HrjEbjNErHDQPmw7fKSFIqE+bmVhWB6qGcqxdSeFz3TtSItUly9pxH200+BzvUnr9VYCVxPnSMaUs5cOnpwHB9a2bKIMQvBV0Z1EUsMTCtT/Jgeno8mchpeX3R4Qz0ThNc/+aMieod40OyVtV3Ppj7PZQlJzhV6KhFOvS0FZswApECmzQzyBlyVAAfoWrzx/9qoYj/FK87o8jgXn7Sdql6x4R/etfadw3GmdGLyNGSQC54WzFSlh2afZvI+9Ey1PSat8ftTrSoiDIua6ikddmzxWur1KKBHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 25-04-23 13:57:25, cem@kernel.org wrote: > From: Lukas Czerner > > Allow system administrator to set default global quota limits at tmpfs > mount time. > > Signed-off-by: Lukas Czerner > Signed-off-by: Carlos Maiolino ... > @@ -224,6 +233,29 @@ static int shmem_acquire_dquot(struct dquot *dquot) > return ret; > } > > +static bool shmem_is_empty_dquot(struct dquot *dquot) > +{ > + struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info; > + qsize_t bhardlimit; > + qsize_t ihardlimit; > + > + if (dquot->dq_id.type == USRQUOTA) { > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; > + } else if (dquot->dq_id.type == GRPQUOTA) { > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; There should be grpquota in the above two lines. Otherwise the patch looks good to me. Honza -- Jan Kara SUSE Labs, CR