From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673D1C77B61 for ; Tue, 25 Apr 2023 01:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9596B0071; Mon, 24 Apr 2023 21:09:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 999506B0074; Mon, 24 Apr 2023 21:09:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8610D6B0075; Mon, 24 Apr 2023 21:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 720606B0071 for ; Mon, 24 Apr 2023 21:09:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 35CCD12041E for ; Tue, 25 Apr 2023 01:09:35 +0000 (UTC) X-FDA: 80718130710.25.77A1D2A Received: from mail3-166.sinamail.sina.com.cn (mail3-166.sinamail.sina.com.cn [202.108.3.166]) by imf04.hostedemail.com (Postfix) with ESMTP id DEF4840009 for ; Tue, 25 Apr 2023 01:09:31 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.166 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682384973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzIHGU9429iIXWDr/khHcWo26G2UYhSSmpft4Jcwbqs=; b=QwJ1CH6qN6kkLEA/1XMlMk+t+a1R9oYcyX/W7Pv++/6Klk1akDNDSV4Ua71ZVUOGnylt2K dpaCOed5YC58SfaCKmuImNOEOFyFXvFC2JQml5iRRIEcYx9Qjy4vCJpk5lBOnO8UUnZttD zq30xiU1FkU21hHIFjQ9RRGb17uPBC0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.166 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682384973; a=rsa-sha256; cv=none; b=52vT7/zpJFTTe67EXxE1GrCHmVOybyn/C5TdoGuEH6haUM9wyE7IDnWF2bTKQq2SqFEZTk WdJHcXWzB+ZeHUSGLPFLqQpJMgs9CBR3tAaSKBSaaZcKRzEzoJ6QuZ/Cq9pf8kuKfvnTSq fLk1YTEjfGvcD0blOMws6cx/Rq7AGPc= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.59.75]) by sina.com (172.16.97.23) with ESMTP id 644728460000A135; Tue, 25 Apr 2023 09:09:27 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 71494631458486 From: Hillf Danton To: Doug Anderson Cc: Andrew Morton , Mel Gorman , Alexander Viro , Christian Brauner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yu Zhao , Matthew Wilcox Subject: Re: [PATCH v2 1/4] mm/filemap: Add folio_lock_timeout() Date: Tue, 25 Apr 2023 09:09:17 +0800 Message-Id: <20230425010917.1984-1-hdanton@sina.com> In-Reply-To: References: <20230421221249.1616168-1-dianders@chromium.org> <20230421151135.v2.1.I2b71e11264c5c214bc59744b9e13e4c353bc5714@changeid> <20230422051858.1696-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DEF4840009 X-Stat-Signature: q7u4ucmj9xw89976ge5jdc7kfwdpniw4 X-Rspam-User: X-HE-Tag: 1682384971-679343 X-HE-Meta: U2FsdGVkX1+mPbDji9pztyFTW+dnUOCRSW4fQjJz9R3NSSUDwRXGi9AF30mOGQxg0btn/w+CDGImlcCg3Ty6ChWsxWPbcrXolhu0YnWmtGogerMzPb4gTo4SKb+9OLySQWpoaS9xHWOKxCj8kLm80xEBgZpP+t0/IqqypjfFnXVDhyVdPdoGUc1GepiaVMwz0fVHc4CgRWc7FjFgzSiQoNcBp7MHqC0BqTz3FyqffTE6HONjmVJ4NRP6J/gPzTGh/aV934PH0GEsuWfKakXyPOOExf7zq5/oJipJ8xy/o+BB2lve8fIkcOQviXCceCIGfOAF9Xkm2g1FZHwsyNJRPKwm7RilpbPc7Ce9q+RGJwVgW7YqwzZHqtbi69HWCFvpQovcNx/ls08E3EkXexFPOewRZJGLiqAHeoHiua/5IJsY+CisyXrUCG7r9MzyyAkghUOgnWIR+zwHNbdfWycp7pmaHs1XZCBWnpMepYC3yBlGQTqKYfg4ZBPLHTgi/fbP7XBsxKhSCuQ7Vig2Eq1X6M3pjaM+h7o7yqqk6L5Erxgs0EqcH0dmMgQXeXXL7onYsSRIpbxf9aNDU8wK/SEbI87LY4a8WxSCuang9oD2q0uTKorK8DgGjI0+6Wj9d7T8nmCKq+cpzb+bvf18LbRICaOvGyYA/NrmtDkEKzjZnpQGHqaeSE9PIa2/Sw7BLV10WJ5ZQK10Xca/s6iic8Nf2HHrYlQ6ZnajHaWlFuP8sV+q0ek5VMKgLJZpkNQuUTky0rlnN0UDp6oyLKuWc9aic6/DWcTM0Sh2hT0iCpe/wXozVg/U2O8xGbHxT1arYNM2o0gTefdf+veCxaMZeCZxwsI/EWVHIvpDska1NkLqCxMLpAd6YNXunqICu0pw650PcAakpX3XdbAOqzezF5afszFllb2OglOFClqw9sXI6SiPjPM+QacHAx+lihNBiK9+hl7A1WpksnOG4pPdtOZ YVsRlAN/ ThoUBH2dguhly0eoRaSLe0Su/hEoKjSY+u1bTlyh3efawPrGu+JHiI6N9QTWrTRJ73IBkdYxGl6lsz6AYZvuME+brDPFN9606mp7uV+i9azA9rojuT6jABaceCfS+MvJJyK2GHW3E6jQ2EZjs6BR6XWiGX/xfucD3EvaNjdrd9Zea5Yzt2fG3K6Iko+vvxTTosLXf85CtxQkbIYrnY8LGczS0ikCvQOcD0icN1Z6/3IMgvi61Vt/kyzQ3lFUD+KMfDlm+7jj9luFyyu+Ra4G0RhhOguzfSgJhjKyKmXpw0XTMAa4GS2vf6v+l+T+Ok5xa7VCHGw7niOFQ2ZQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000071, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24 Apr 2023 09:56:58 -0700 Douglas Anderson > On Fri, Apr 21, 2023 at 10:19=E2=80=AFPM Hillf Danton wrote: > > If kcompactd is waken > > up by kswapd, waiting for slow IO is the right thing to do. > > I don't have enough intuition here, so I'm happy to take others' > advice here. I guess my thought was that kcompactd is explicitly not > using the full "sync" and instead choosing the "sync light". To me > that means we shouldn't block for _too_ long. Take a look at another case of lock wait [1]. [1] https://lore.kernel.org/lkml/CAHk-=wgyL9OujQ72er7oXt_VsMeno4bMKCTydBT1WSaagZ_5CA@mail.gmail.com/