From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB6BC6FD18 for ; Tue, 25 Apr 2023 12:02:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53966B0075; Tue, 25 Apr 2023 08:02:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A03FA6B0078; Tue, 25 Apr 2023 08:02:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F2206B007B; Tue, 25 Apr 2023 08:02:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7E9336B0075 for ; Tue, 25 Apr 2023 08:02:27 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5673F1C6150 for ; Tue, 25 Apr 2023 12:02:27 +0000 (UTC) X-FDA: 80719775934.16.95D3001 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by imf22.hostedemail.com (Postfix) with ESMTP id 22FAEC001B for ; Tue, 25 Apr 2023 12:02:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none ("invalid DKIM record") header.d=microchip.com header.s=mchp header.b=buibDxQz; spf=pass (imf22.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682424144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r60APdj43kXAdNbxYu4dsvTIUQWJMxwXEhX8or2M8dA=; b=uiAH/NcFTFcP/0Z3ZWvqyBJuMl6SyB0PE8oOEgngVg03nrztRsdxonMUo8vgIOkPMjg5RK mwibcQsHiyRYpDXxuMAwXzabjGb46WCxAh0efIzv8CeuHJ26fCmAbwwQvJEENU/XJZpggu OpX626F0cjs1kgHsS68pODZj7XnheH8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none ("invalid DKIM record") header.d=microchip.com header.s=mchp header.b=buibDxQz; spf=pass (imf22.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682424144; a=rsa-sha256; cv=none; b=c4KlrZ5ulTQy9oDV72EfwJMKiK1p6ZxXQ4RWlk4fro6wwU3pJac0UNULErEGlo/GmGKMf1 GqRF3cbRdcgCC/j2tRaC62XjhXDaQxbNWuZQw5Ay67DnO4Q0Wc7mYCl0Y3yjjFS0IubpmT +Txai9Cp0uAYvggsQaTuvRX2GkgMi+0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1682424144; x=1713960144; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ktZDAmJABhXIc6D5OVFisqlZkbF33qJIsMcwJhPUgkw=; b=buibDxQzv+bqkLa0L7/4+KfcUJzqb7zrw0hRFigDBhU7DQstYmRSFcbh ox3bZXiVurB4mrbcAmDEZk1aVfbSa3Myr+nQFFpugH8rjppTJom/9EWYa tRr1gU3q8lAWBHWeM8rDRU3vXA8PAOM7fM3CT/4VJc3idk8P4jxlERueX xaQb9dKxqOuoagw4SqyqvQS4Xtjwvab5eyOxAb9XTo5tvJ3ElVtu07Nvl lRWtRnW3vZtRSI5SPsJop9GP2OfzrBS/LHKTw/hHzQUAd3OhCIiPIgRTM IAzr//7lwzifRPOieQVk8oaSL6+fP7G4I0RpjzNRgXNMKxkAOVWGWJWm+ A==; X-IronPort-AV: E=Sophos;i="5.99,225,1677567600"; d="asc'?scan'208";a="210584387" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 25 Apr 2023 05:02:22 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 25 Apr 2023 05:02:22 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 25 Apr 2023 05:02:20 -0700 Date: Tue, 25 Apr 2023 13:02:02 +0100 From: Conor Dooley To: Hal Feng CC: , , , Stephen Boyd , Michael Turquette , Paul Gazzillo , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , Subject: Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Message-ID: <20230425-filtrate-nearby-f62515de1ec1@wendy> References: <20230418123756.62495-1-hal.feng@starfivetech.com> <20230418123756.62495-2-hal.feng@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GHeW0EClyRQDEg0y" Content-Disposition: inline In-Reply-To: X-Stat-Signature: dqtzj1qdedwm5smneu6wn67f18hdi46g X-Rspam-User: X-Rspamd-Queue-Id: 22FAEC001B X-Rspamd-Server: rspam06 X-HE-Tag: 1682424143-562548 X-HE-Meta: U2FsdGVkX19uG7EPRKdTrDjQHjxc3c3jdnmO5U+PGZ92q4E6MK8RQsjWH9ndYlRe4eFDrQ1OK70dZAnvxlusg7D2VC++2RPMCzCpvCe1yxbbB6QEVvYkwf1WGINIeMK1NToFyH3Ga7wQV0I2iiUGK+akZUIop3bIQvdB1qiXtqC3/w5VCDOzgd3BLf+YqtrlQmqD+Kk9koVf5aBS0k+BGK9F+xZaStsXkNva2MnPqjuVNQc2NzxdSGUAotXTNr4IRrYjhb4D5DhqQrnACoILLBxMutYbmFPDzPx8xKSWfk1ufKTTox2S762QHKJG6o3ED+EwFS0wrTwqGSrl9vgTI6go8/z4hIGr/6a8E+bVbg10sqonkPQNcnrx+WKHyr1Dqoo5ttgLiqu6iE7sWQDiZPSp55fqBjUKyPClMxg6W6kfigCx+QltuBl7WO4I3oiiMrm+d+QkB1UmGfI3s3awggYUVAYiXVXuzrnu6AxMDEE4JxviUwOkl7xpKS3q4FOis+qs/oelHbUvlAjBTFuAlnbCkNdm1GORILUmZGtPFUT8x7Dfp5PRsX2RD2Q1stoTBatdZh7QY240Y8VC//6l8/N1eZBYAvc7F51mD5qiTrJMG0dExlgDZAqKYdrPLbADn3XK6QmK4H3/BHL7SMiAjAjq4pYd61TQPVq07bMBearCdll4KGW+sj0AB32+mF4R7uiPiYFQ2PJT0a4BMZ9XrIGJsx8aQmG9oH67EEV/6mFNnrETBXG3/B1IcMDSfwLC5NLSugAn08dAEsPFGWotFN1ey8uYYvFR8xbTfMdoJ0qfJJecLNGpwGRklEISs+ezxqc3X/Vzs/0f753whfpxk1ca/ObxB6FV/Qr5pEa7sXGTJ0WO7KltO5QF+rm9xt+Yix5hKkFcAnZfK9v4gMJKjjysQ1ndlEP8FXDyg9MABKrpjXbkzzH088DKhTT3lIb8aZsIzGmz7wRoJ3Z37wj EvFpmzkO YClEJsJEZhILmxUxy9a/Sbuu6D19OOTKdUGdOmpQze+dlkbasLmbJZTzlUS0BbrXbp9RKJOnmULTSABKb5WvE62fq5rjG1dWhLKjCQHZz+TQ76H/decRItBFV9X+p9ELT87om+CXwQeTyWIEepMyyJnb/E6EmoW4NyMaFrv/Y4G/9o95P6r0zL3dVfz7EasWiH3w2rOvx0GNQutwka+zItPHZBURML5qx8Xo5UolCWNNfL/O14agZ6V2eDDDyU+JR8OvjOe3WLc6/F7B7v3ml+pofoCqSzTOaj016MzXzpT1GxsCbl2PkcVhD48db16Sl+MdJtv54Hpvy49xuFgNOTIUS86YMM72oSMN1w5cAiZn2SGqOJoFdsJ2KP7DGXaR+FtrL0a9aYisYpXY5dtXuOBUIw9yduiLQyAjFMrCPUR3u/wEEy4+LF5FKagYUVi/8Jp2YgbBpuEfPhkDv8sVtoVZtU/3RW9bxiUun X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --GHeW0EClyRQDEg0y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 25, 2023 at 07:53:04PM +0800, Hal Feng wrote: > On Tue, 18 Apr 2023 20:37:56 +0800, Hal Feng wrote: > > When (ARCH_STARFIVE [=3Dn] && COMPILE_TEST [=3Dy] && RESET_CONTROLLER [= =3Dn]), > > RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > > and CLK_STARFIVE_JH7110_AON. > >=20 > > Add a condition `if RESET_CONTROLLER` to fix it. Also, delete redundant > > selected options of CLK_STARFIVE_JH7110_AON because these options are > > already selected by the dependency. > >=20 > > Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock d= river") > > Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on cloc= k driver") > > Signed-off-by: Hal Feng >=20 > Hi, Stephen, >=20 > Could this patch be merged into v6.4? Thanks. Whoops, I thought I had replied to this a week ago. In case it helps, Reviewed-by: Conor Dooley Thanks, Conor. >=20 > Best regards, > Hal >=20 > > --- > > drivers/clk/starfive/Kconfig | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > >=20 > > diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > > index 71c1148ee5f6..5d2333106f13 100644 > > --- a/drivers/clk/starfive/Kconfig > > +++ b/drivers/clk/starfive/Kconfig > > @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > > depends on ARCH_STARFIVE || COMPILE_TEST > > select AUXILIARY_BUS > > select CLK_STARFIVE_JH71X0 > > - select RESET_STARFIVE_JH7110 > > + select RESET_STARFIVE_JH7110 if RESET_CONTROLLER > > default ARCH_STARFIVE > > help > > Say yes here to support the system clock controller on the > > @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS > > config CLK_STARFIVE_JH7110_AON > > tristate "StarFive JH7110 always-on clock support" > > depends on CLK_STARFIVE_JH7110_SYS > > - select AUXILIARY_BUS > > - select CLK_STARFIVE_JH71X0 > > - select RESET_STARFIVE_JH7110 > > default m if ARCH_STARFIVE > > help > > Say yes here to support the always-on clock controller on the >=20 --GHeW0EClyRQDEg0y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZEfBOgAKCRB4tDGHoIJi 0rbrAP0V0yJ1YNh+S+KxDVsTxngYTKlRNjGmYP5q5MQo37uTyAEA24mDl+HcIrF5 XyZakrHAwWpNtM6Z4Ux111f6UVJsRwQ= =wdU7 -----END PGP SIGNATURE----- --GHeW0EClyRQDEg0y--