From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78D9C7618E for ; Mon, 24 Apr 2023 12:42:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 693576B0075; Mon, 24 Apr 2023 08:42:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6433D6B0078; Mon, 24 Apr 2023 08:42:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 533466B007B; Mon, 24 Apr 2023 08:42:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4531D6B0075 for ; Mon, 24 Apr 2023 08:42:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A43E40182 for ; Mon, 24 Apr 2023 12:42:41 +0000 (UTC) X-FDA: 80716248522.30.EA388C7 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP id 22C25A0036 for ; Mon, 24 Apr 2023 12:42:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682340159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYXieGe9fPqTUexJRiJtdF9YaRduizg0r9Rnrl9HpAE=; b=Sh4Kx4LErvH249798OZrCRnJAJaYHTeUKMWpiNqiOLv/eRdZViTz6/zKqbv7EZEA5RbnoP 9N5G9YyGLc6w8KyySNqyiYCznLVp04FRi67WFh8+cH1s8io/Bxk7i7jWF24mMnHhL6r362 3UbvAHyKBA7BEWtwNg6GIeXSONY5+xU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682340159; a=rsa-sha256; cv=none; b=pjv3ss2gbIdUsGuqygDYb5BY/U1u2EG10TqyLgGdoa/Wc0Pkz7V9yisQBrWdal6e2y12Hh MTTCxsIJB9RCnH9iBk3ly+Q01kWYXieE7+3dAQcnYJFXPiZaKu2QfUoFhutvGAe0dpF2xn rAbZgKsP/9lAjQkC81v3ODzgFxN1KN4= Received: by verein.lst.de (Postfix, from userid 2407) id 72FF26732D; Mon, 24 Apr 2023 14:42:34 +0200 (CEST) Date: Mon, 24 Apr 2023 14:42:34 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Miklos Szeredi , "Darrick J. Wong" , Andrew Morton , David Howells , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] fs: rename and move block_page_mkwrite_return Message-ID: <20230424124234.GA5786@lst.de> References: <20230424054926.26927-1-hch@lst.de> <20230424054926.26927-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 22C25A0036 X-Stat-Signature: p3o3w1z5bdxo5oasxqrps98oh3ty5nud X-HE-Tag: 1682340158-933107 X-HE-Meta: U2FsdGVkX1+C67Et1fUnDSLGUpNQe44FMVZ4r1XNxFQ6LSPFf6r5oUMYC1B6QoeLmChChYYgCON9yP2rVqUb1+H3KGayKExt/OqJn2M/Fd3S2o8e/mGSQfSkJEa/v/9QAXfyBGHFezPD+5HByywPEljy6Uk4a/uvn+8Flche3nH0CuPnOqLGO4umzvbHHlsaFgRZxzR4axs2ROkv1k0JeAt2qa2807i1WSrblYaUvVkELHXor+TbllpCE977J1rBdl3Nc8Y6RNyrZJcHpudbMc6Kj1f7/3H2+AM5Q5N8t/anp8u/OM+K9a8ZIuLYo/2D6qj85Sihj/GHFooZQ+fy4HiHLC52PULiXRAIJMDRGBQp2QL0918K9CMLBh+MNSWzaOf4BGvIJT/2Mzyk51t2Hx+XhvcZ9cfFcelVvgbESlDGkGBYKPq4gDPrjmkVPP4OanKvxxJNKqcXPbXqDOLhIuTx/dqPeuoBoDkTj3doGIRmLuDf39FRUuHfI/LirgkXd60NeHoy5mE/7dRtTexit3xcO8LtTyIEXkm+NTg4diQoicxVaKr+8PL+0GbmFcbCmwN5Ch4t/jkH+TuGH/YXlVJG9miVjUF5nB5hgo5VK13YT0gXLSWsn8iu4YpIlhTNiF2xH1DmJvbf2E4vLcEjNKzUWIbLgKWxxAkH3+k1fiGxGWrOH0uLzFxQIrE6t1tOTnGSXRSt8I2wXoXlFUctZZ+6J9vy9iafQ/Jr3THwI+nz1JyiOMpzTsJK0wdmW0X4ujbjtzED/jC85C5ZYd0Dwxyg04nGWdd03CU/jAQvRXDbrYRilKbfTY2b32emFSut+/KFL4HAECgLehlBYuTh1qgKZPBvt68To464xfqk1jJx2c9Y2an0dmTbz8YA4qR0/iFpF9ZUAmCeNj5oJOvRMgWThXZNQqfN0cA0sv5U5qToqL32pwgCkRN8t4zfiaalry0vMRAeijvuJNBjgLK oAp0W00V UHYATbXUoIRvGDw/Y5w0C3qutxDGArIB+UrJ4XZyK+EvAmtN26+3Y/c7aoTXCOw4xx7no9Nm4XfvQ0jxxy74kc+FV9p8yM5+pCIsAtnoXokiXG3g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 01:30:56PM +0100, Matthew Wilcox wrote: > On Mon, Apr 24, 2023 at 07:49:12AM +0200, Christoph Hellwig wrote: > > block_page_mkwrite_return is neither block nor mkwrite specific, and > > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > > errno_to_vmfault. > > Could you move it about 300 lines down and put it near vmf_error() > so we think about how to unify the two at some point? > > Perhaps it should better be called vmf_fs_error() for now since the > errnos it handles are the kind generated by filesystems. I'll look into unifying them for the next version.