From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9972EC7618E for ; Mon, 24 Apr 2023 06:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17FA06B0078; Mon, 24 Apr 2023 02:18:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 130B36B007B; Mon, 24 Apr 2023 02:18:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F392B6B007E; Mon, 24 Apr 2023 02:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E30426B0078 for ; Mon, 24 Apr 2023 02:18:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B2AE1201BF for ; Mon, 24 Apr 2023 06:18:29 +0000 (UTC) X-FDA: 80715280338.24.BB6D1B8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id E12CF160006 for ; Mon, 24 Apr 2023 06:18:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="UT/Dbssa"; spf=pass (imf08.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682317108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m8/vbs/KZ4kG3rGa6EPpInm5hn+HmPY26T8rCn74t/Q=; b=KV+E+2lJN82ildHEkWqtbLMfkrPVFCHdYvfqvIZr55enhLmjVa5/E3rhpluc1RFeJk8ey7 qFtLC3U26xHXXbLsTBmI0ssFhBRzXY34tr5A3AI9trcALRxdqPejfNt4CbMm+McRzDpGjW r2kHTBlCQX/YR9+HJTBvlDs6kuT+rns= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="UT/Dbssa"; spf=pass (imf08.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682317108; a=rsa-sha256; cv=none; b=FyBAevf6/b/XEHY2G6DdyC37qpHItKvwK1Taisqx25CDyvjFqs3e3eSqI0zI4Ih8294ZTz v7PkZLiAsweHvyaR4VGSqZpZZ7Mwj4JczxdrpuvdQ4+4SuuJTQq/Y93i1wCpzocFK1NSeR r8YSL8v7pq8k8q6q7k914n/nabPtWL0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3E21617E4; Mon, 24 Apr 2023 06:18:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16E9EC433D2; Mon, 24 Apr 2023 06:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682317106; bh=yrOHoQW3uvuLL/IhB326kZ2OBDh3o24byU0KV1vIAfs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UT/Dbssa7FMu87YCTTzaTmgLkwn75ydoQ5e1ln1O+ABDNIqGOzM3jqE84LcFRLXtQ 8PuuiokVVXrvBeYIF8iLRJehcsneFbeO541NlPuyK4WYdzoxYQNo4Ct81C2GCviI+E 79/CFqU6DUXRwrF75TfpgUzUqpnzqkrSmaHscnDlFYff2Q092otoUICLTqHPcjNycW C7ARkCXD0SS6fhBsNHyLWVZjmfBZdVWOaqI2B3r1Z1l+wSYSI5vYVpmU08euCPzUsC TVc0sjLEGEsQXHIvBCt48O7duOfV2QNgFrxe001cpPfOwYHak5QZkXJngosDVkNNLc yFrTv1XJj1gDg== Date: Sun, 23 Apr 2023 23:18:25 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Jens Axboe , Miklos Szeredi , Andrew Morton , David Howells , Matthew Wilcox , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/17] iomap: assign current->backing_dev_info in iomap_file_buffered_write Message-ID: <20230424061825.GO360889@frogsfrogsfrogs> References: <20230424054926.26927-1-hch@lst.de> <20230424054926.26927-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230424054926.26927-12-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: qnerz4ymyz99ksyz6o1g3r4qens77tme X-Rspamd-Queue-Id: E12CF160006 X-HE-Tag: 1682317107-462888 X-HE-Meta: U2FsdGVkX1+qe3JjOqYS9K8VmHH1x7pgZliSKQzGZPejV/TfxuLFgtq7S1C8k9h/MkFv3HIN3EaJeY1VPBy1pepbzI+nZG2/khP9NkHKoVnyPpZVkPcO1uWo8cWmp/eGqtyHVTNvnqNxt42M4DQ8aY84a/RgvA8fo2r2clnAKHA+xGw3mZKnMpf3dbIfRNxlKqXpmkAdQdDSW9zMcG7Ur01kUaVT0VNeALoAUlBnAyXlDZV5Fi6tRDEUp8bKbdhUz2ddfYXjRgHH56sVI/L71/K6F1yd8o8e1aNiXDTnIhUk7HgnHDHc82QZJJjMEMxg16pYi/Akoh1Lwtlnpe3zn7hq7xMszN41xkndlHh8FQduvd2rjOWqrSvD1VsVjnMlG4P7vmTBcVD1d6fnrbL/Nb+NuqCr3L7uN3aB69m+hLf+Iy3G3G/H0fW0WDeNSiUiyBelP1nUCKBPjrgFKc9ppgrFWCp6bhU4PAieuY3M/Kq6LkZuFogb1FK96hgn7ZRUAVAU7+/aOIN5PkwUyAplDcPQp0aFdqvbIOqB2bkPdVF5xH/74q7XPp6m4Jk5FBdZdU28Jcddtb+KqLVj/1Kzqb0hsPP495pKzXnV+BgNpCykSe+eLbP8vANdWB2drPyksXqi6mblvhJC1jk6jrpe+Bx8d8CNeYAw1JfSWuCyIAOW584JiA9TavpMuDIQ+NHyrSKL3nq+nmafmGJxDR801O0jvVgwTapN+UJ8E6ZP2hkOdP4Bj46BbHT/bZuCLnw2XIAOizFr+l0Q1dF6uAkGGn51194BhjFqQRtlAGT0/EMkTnWAOoMSZTTtRsNjdzYIGfJPiWwPvDHV1HGzl162pDTsbynrrPZA127DxDlbZw+NGC2f/2EkckiS4T4kJnyxkFJtDhnAvztYoVwTQ9gc6eUDbJd5MnKpScZiXFhRpXuCmCP5tsQCAeRXApEiqCoJT78ABzQJl6SpHIg51S9 5mzB4uif xoE9t2VnNSukQA/YxYButplMRUyoVBuoqr6Gu5ngFVS/6yZVqMfUrZ2akzgABg9OW2O1H9Moy048I5FCvjlXbE1Yd/76wk75zkuDSeM7x4xct4VpiR3+QtFngVJynSO0Pm17JTHUzNP+36XEsu/2Ps5IYG/1Xe7iJp7Lpc/UVHTtUMfNdmGNJfPxmBXPZDRk34bkrutbJlJ6t7vuDHaLpIcfZinczQGLiwmHN0WLQBmYtpskfuFCsNPATjkV6hoNa4WY0/1aF0R85kSh7VfCv2faPHAxrzXsUNBisswbv3J8SJKmO6eLrWpNhq4Rpthny5IiwUVSEZRyHw5gXgvC4eS2IQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 07:49:20AM +0200, Christoph Hellwig wrote: > Move the assignment to current->backing_dev_info from the callers into > iomap_file_buffered_write. Note that zonefs was missing this assignment > before. > > Signed-off-by: Christoph Hellwig > --- > fs/gfs2/file.c | 3 --- > fs/iomap/buffered-io.c | 4 ++++ > fs/xfs/xfs_file.c | 5 ----- > 3 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c > index 8c4fad359ff538..4d88c6080b3e30 100644 > --- a/fs/gfs2/file.c > +++ b/fs/gfs2/file.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > > #include "gfs2.h" > @@ -1041,11 +1040,9 @@ static ssize_t gfs2_file_buffered_write(struct kiocb *iocb, > goto out_unlock; > } > > - current->backing_dev_info = inode_to_bdi(inode); > pagefault_disable(); > ret = iomap_file_buffered_write(iocb, from, &gfs2_iomap_ops); > pagefault_enable(); > - current->backing_dev_info = NULL; > if (ret > 0) { > iocb->ki_pos += ret; > written += ret; > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 2986be63d2bea6..3d5042efda202a 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -3,6 +3,7 @@ > * Copyright (C) 2010 Red Hat, Inc. > * Copyright (C) 2016-2019 Christoph Hellwig. > */ > +#include > #include > #include > #include > @@ -876,8 +877,11 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i, > if (iocb->ki_flags & IOCB_NOWAIT) > iter.flags |= IOMAP_NOWAIT; > > + current->backing_dev_info = inode_to_bdi(iter.inode); Dumb question from me late on a Sunday night, but does the iomap_unshare code need to set this too? Since it works by dirtying pagecache folios without actually changing the contents? --D > while ((ret = iomap_iter(&iter, ops)) > 0) > iter.processed = iomap_write_iter(&iter, i); > + current->backing_dev_info = NULL; > + > if (iter.pos == iocb->ki_pos) > return ret; > return iter.pos - iocb->ki_pos; > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 705250f9f90a1b..f5442e689baf15 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -27,7 +27,6 @@ > > #include > #include > -#include > #include > #include > #include > @@ -717,9 +716,6 @@ xfs_file_buffered_write( > if (ret) > goto out; > > - /* We can write back this queue in page reclaim */ > - current->backing_dev_info = inode_to_bdi(inode); > - > trace_xfs_file_buffered_write(iocb, from); > ret = iomap_file_buffered_write(iocb, from, > &xfs_buffered_write_iomap_ops); > @@ -753,7 +749,6 @@ xfs_file_buffered_write( > goto write_retry; > } > > - current->backing_dev_info = NULL; > out: > if (iolock) > xfs_iunlock(ip, iolock); > -- > 2.39.2 >