From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C7AC6FD18 for ; Mon, 24 Apr 2023 02:36:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 380716B0071; Sun, 23 Apr 2023 22:36:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 330896B0074; Sun, 23 Apr 2023 22:36:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F8046B0075; Sun, 23 Apr 2023 22:36:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0D90E6B0071 for ; Sun, 23 Apr 2023 22:36:34 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AD68F40364 for ; Mon, 24 Apr 2023 02:36:33 +0000 (UTC) X-FDA: 80714721066.05.1AAEFF1 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf07.hostedemail.com (Postfix) with ESMTP id C566040018 for ; Mon, 24 Apr 2023 02:36:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Myis4J2Z; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682303791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Er9IodKAhu5Xy/24MmuM3ISnj8SFsqKhcDcV85YYtd4=; b=TjqcSHXQwyJezdiVXq6eNfcZ3gyeQoJKkUj16kIzpuVIwpOFoCDT3IO5irPdlcOQqWctz8 3U60TRwSGagunJZN2VmL3M1weEXTMAQXw6Prga0kxKQ8cnWy2/ebuln7e6cCtrZhpkSlxg Dhn9j8/rNrl+6/B1cYU63QBR021WggU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Myis4J2Z; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682303791; a=rsa-sha256; cv=none; b=Prc7exVxkn2aaME1fY5Tq2mGzFZWvwdctfcaRztssfax79heqJcDdMBpDflGGE0Fp+zTLx m5LC5kjPdp+tYC7i77FYmK8323DhywvrZ4lWDA9DJf0U21vdzW9km75Lvz4uRO9r+LNyYe DqYRzo4G7sLNBzIIv1tH6iZ8kcDlmhc= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-63b46186c03so4951352b3a.3 for ; Sun, 23 Apr 2023 19:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682303790; x=1684895790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Er9IodKAhu5Xy/24MmuM3ISnj8SFsqKhcDcV85YYtd4=; b=Myis4J2Z9lmx+G/UGHQV666UFM6OJ8EKtdAre2rvRUUjU2E+rQLKwJ+D0eYgmT72Z9 5SaX6H/C77vylvdgFXO4tn7m7ArVvZvZSOxiW6NiLDX5h8w4cEfp1YoxEuHlyRXPz09e 5JgUmEmUJwM1H8XEmuezqPmJ+lzP8zXU2UJcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303790; x=1684895790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Er9IodKAhu5Xy/24MmuM3ISnj8SFsqKhcDcV85YYtd4=; b=MpQdZk5yTh+/1b8dFfgBnnVninQJH1mSsRO5HbbYrCPKdX3CD3leyOoGDCwcPZi9Zk DnVMeU1eWeNb/WSm/rPIlU3ZoEuYmCyuAjQ5LUoaGptweIdydco7xaIVxPEpsbU2TFxk TQrfqe6HyNXMlYzTorpFGneoqw17Q8Mm1e+lPhv1PgGTsfhKaNN+Ca5+aPFeAnu+6WkJ mDzFMXq+NUOrUg6XS81L3ZXEb9Ac/bZ4ieEKyIGyIv//T2z5NRZPxp4lSyMEgOssp6m2 l51etiei30Q3IRljzNXhUHSDxZ0ZuF2GAba58UUcfxYg7Dz0Znusmv8mAKJhBgp4U55i rZfQ== X-Gm-Message-State: AAQBX9fDKF6SzK3KiNLpAV0Kr/Vzg6+GWLJcn3DhSnpdSUbACvxIITJj CDWEB82LCyez+6x1/qQAHbgysw== X-Google-Smtp-Source: AKy350a438RODTsIQbvbOZb4mhoGqhZ1pvzPivBPJ5Ra5hjJQnsR6/IRQqkIVQmM+kaUu2d3rd1IMA== X-Received: by 2002:a05:6a00:2406:b0:63d:38aa:5617 with SMTP id z6-20020a056a00240600b0063d38aa5617mr12656579pfh.6.1682303790512; Sun, 23 Apr 2023 19:36:30 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id h8-20020aa786c8000000b0063b8279d3aasm6183422pfo.159.2023.04.23.19.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:36:29 -0700 (PDT) Date: Mon, 24 Apr 2023 11:36:23 +0900 From: Sergey Senozhatsky To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT Message-ID: <20230424023623.GC1496740@google.com> References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-6-mcgrof@kernel.org> X-Rspamd-Queue-Id: C566040018 X-Stat-Signature: 5rap6deaq5qdcu4hyrkyrtq4wxnrzcwt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682303791-16998 X-HE-Meta: U2FsdGVkX19/bIduXauWx5rVbJ2ZFEIqdhwcmJUJ6Bhzk4eNU0UhI1bFarq343PNli/Y0Dc+u1n3L1o7OEnLdOJZ/Vv3NmcadOvv045oeJjuFbH5X6rebtAnBJIjJ0znRWR/vp3LC8hct6jONvTuqMBHJdox4xO4HEUTgS3CNQvFFiGbQjS0Jy7lBq7fAVaEu0QLeGMVnFfYBLKcpFOBqNO0v650voWvvwugBIbUmQURZkFt4koYiCemWRxGrbTjE5t6g/JLMl7axZjEREHYG4ABc3KUPIPaHMddby9AhUa34x0upYJhOL7DfekE3+pUsKSgpw+71JXYV8CKdFo0jrRPHolyIp7Z2vTwo7HaJ8YBFSfgJREmjVFVAGgO5WIhH/87ag0WEzsY5xvhEm2pe6k/QvIghteJbc+yF+WmaFKRVCdeS4dfok/NwLI/OZjbXLlvBlnfX2J+XCR5sSM2r2F9jo5BdjUjLyX9/nTClIMHuWF+pp7CWqcSyKwhDy8xWGFCLbct8IBCEeTBTK+J8VTnWbHzhu0h85hRlOLH8MQfNVm05ug1xrlvgaowE3Bj2dBRqMaRihQjB4R7tBR/phdchYO8fXhpUuXpiEwH1hur76AmA9Wmk+PPfr7cqBq4IkHSWj+grblKBxsiqPtAJ3BqFc40R8vBFKbOsXKa0KDXOWyPmfdoSfakxmfjL0OZmK3bcEGscne0X9Zkii9samvv2icZXWL1fFu0U45SCtGDSEu7onqFu1TcXhkpxQWvcX8gLtqaLrmHsTsGNkm8PyJBqHRAkEdtAT23xCgm1FfYQy5Z8YSDsh9fe4vHyUXABqt8H2o17Qg272NbknmTGUJBBU6LlfMaLlsyMJpCaeD+HP9KN/+5JT4ff4eV773ev2aDwlu6MUET0bttm+QxkaV+NP0uaeeFGcDLZo0a8s9/lu/MTLiuAsdJb/7M0XTkzzMkSyPhbx/EW9EY02X PpUvS7oN ND4ukdpGZ0YVVxA7ihMA2vAgcczmxe2k+/AVyVXLC4FPQuIq9Z/Vca66DcK4XD/wpu3NQym893/2mhHf3vYtmuLWo22+VA4aFECojhWTdhdxJQeHHo04B5Qzub719CivtoL/gUgFX0eFUx9skx7v1/8sTPO4W2LWSUCxlM0fy7wLmlzhS0YKlBcXBzvEYrvAzA5ntOa7gWnV1OKjx4JoIQaSBz/9HPMCbToAOLXc4aHqTZK/DGdX5n4Fo0klK7e+I4VuezjiNDtQk+wE8HcEasyMsMlN/szwCG2CfZnTdaoKuHdTFmISFHGRSKsTmXo6Dp8m0tFHj0BUVzpqTxrvy7ZbQqC5Vpc/GFGxo5vyYl92ZVineEv8VJJL28URmC9cF8geqClIfcGhbkDPypZb9gsz/zb4+AStuCf/MXiP+ipmNUR49wc51xgvxwn15Vgzr07LyFw0FQdJuQPckFpWzA7xaaguMDVRJDdvt X-Bogosity: Ham, tests=bogofilter, spamicity=0.001954, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/21 12:58), Luis Chamberlain wrote: > > Instead of re-defining the already existing constants use the provided ones: > > So replace: > > o SECTORS_PER_PAGE_SHIFT with PAGE_SECTORS_SHIFT > o SECTORS_PER_PAGE with PAGE_SECTORS > > This produces no functional changes. > > Signed-off-by: Luis Chamberlain Reviewed-by: Sergey Senozhatsky