From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7280C77B76 for ; Fri, 21 Apr 2023 22:34:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 307CE6B007D; Fri, 21 Apr 2023 18:34:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8A36B007E; Fri, 21 Apr 2023 18:34:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1813D6B0080; Fri, 21 Apr 2023 18:34:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 060FA6B007D for ; Fri, 21 Apr 2023 18:34:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A3B151A0351 for ; Fri, 21 Apr 2023 22:34:26 +0000 (UTC) X-FDA: 80706853332.30.CE5F599 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf02.hostedemail.com (Postfix) with ESMTP id B614280006 for ; Fri, 21 Apr 2023 22:34:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=28YtcKiM; spf=pass (imf02.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682116464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WOBbV//TmE5/Vt+YNa7VvWoHjH617/cqrLHE/FuEqvo=; b=GZ1sCCjafiHILq1Alu/wMkh1RxK710hbe27WuefX69ELJBvRp35y0L0UzjvvEMOmjg71Bb RIH81jjcKiLFEcCPdzQGDVfjzs5P1528agTlsLW+pD6w18Hk0II9g96v830tk6ZN3sjqt1 y4Y9ZYfAA01MBjmznRQQqS8x6zKDULo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=28YtcKiM; spf=pass (imf02.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682116464; a=rsa-sha256; cv=none; b=ktHliZp3OgH4PNy59Gvkv7x74Wz18sBC0A2frtgzCrdEerpF9F+K9hGfp0koDqk/z9WZbV CcJ6vBTm4k0lcnHVYwF5NvFG2w8zhNXvXNg0Nelm+YbtmZw/ekYLsd/HsA5aXBXIYLuydJ 59ATTvf/sjNzl/y8tamjbnYFV9CxhnI= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1a80d827179so23511095ad.3 for ; Fri, 21 Apr 2023 15:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1682116463; x=1684708463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WOBbV//TmE5/Vt+YNa7VvWoHjH617/cqrLHE/FuEqvo=; b=28YtcKiMKTyuPMVw5fu/SoweCi0BqDGeWt7RdFQrVk7PAU917keO+0FEYqTQ9/TsLB T1pzM9DhgsBLcc91My2Vu/2jTc0NKv/M54REjAUYDHXH1HKV9Z5I1WFYwId6vQM+JZTT E6n5vpXvzeV5sJVZPomczRMqHlEzbnPY63QdhqjDa6gftGLx/sPZUwv2JfprlGFlZtYf fkSebmqIvZEolZKw757enRENf4URiSoQqdGQEZOuckafZkYiGfcqGHFj/veTqOAh424T Sue6bk+H9d6MxTxRu5J8fCc9HsE6NtJ7Q9mZmdahhGSisRdkO3MgSWcLNMeFOEusAg5H JN3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682116463; x=1684708463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WOBbV//TmE5/Vt+YNa7VvWoHjH617/cqrLHE/FuEqvo=; b=Dcb/oMbYqzJDLmkxt6wfSPAYBw10rf+r7qoE0PXQiGivMcjLlhjX6CWf3tu0rY5Zt7 g96FYWka5W+G8pHd3L/MADS4mEUxrZy0FP9+4T10vGEUM4HIQhICiqzAsRm0lR1jaiQd wUKvmbAReiw5Gr8itAuga/UAPAPFnuAuj7Ac1ETpS3n5uIOm/2h3yJA5Tklc+iBjLDfB khCb5SiksrjYMO0RPu6EpD9na4V7NM7Q39g/RyRmipqYFSLpb/WBDDzw4oz/ilUrZDEX OUBjgoRM8rZOaEv8uKcDrwv1U7+qJtjYbKtMQToDwcIrLFWqKRDvl22REceFY1okJhTF ikwA== X-Gm-Message-State: AAQBX9flQHVAdALexJHt/dP6npTlq7wVdnFrmpIby7cbKBx8jtgve82b 2ATH0vcLPVTmpbGXOg52I1eNdA== X-Google-Smtp-Source: AKy350Yx4GjX3RRHXL1Mum+601m5ZkYo7MaItZI/8CPJsIZY6IZjMOJMo9Hbi+Mo8ymVreNZtCsXeA== X-Received: by 2002:a17:902:d4c4:b0:1a6:6fe3:df91 with SMTP id o4-20020a170902d4c400b001a66fe3df91mr7801960plg.50.1682116463609; Fri, 21 Apr 2023 15:34:23 -0700 (PDT) Received: from dread.disaster.area (pa49-180-41-174.pa.nsw.optusnet.com.au. [49.180.41.174]) by smtp.gmail.com with ESMTPSA id v7-20020a1709028d8700b001a6401189a6sm3138777plo.147.2023.04.21.15.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 15:34:23 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ppzKe-006Dta-Ha; Sat, 22 Apr 2023 08:34:20 +1000 Date: Sat, 22 Apr 2023 08:34:20 +1000 From: Dave Chinner To: Luis Chamberlain Cc: Matthew Wilcox , axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Message-ID: <20230421223420.GH3223426@dread.disaster.area> References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B614280006 X-Stat-Signature: 1nguerzu7peccjjgswddbmsw8ppk7uf6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682116464-785352 X-HE-Meta: U2FsdGVkX1/+uji+fc9H9UpsBkKeeFETr+egDkEhuwZ6Yt9tsJxXm44Htm80H0LOsCMwd5nOgOrqustht87iAygOSrxjJNlKVaKoAj2BbOhjCHoU2Kj7D6WMMcMyPiLpK6OKu3bbB2xyMTCuaUSPhE9GEwtNciZqw2bcgUQECVC7cMUmGYaC7pdBW8TkDvlxIRmqnyEZCqhzE6ZRpTNUdBWrqaJU0LYNnA+NWS47sdSlaV1S/TT77AAqq2LXOL8sdjvEwj64pGjx6VoDib/JYcsfeV7MKsmZOnUNMdk6605a61Jl9Hn2pZLI1WH+8+vosMoOOBoILQDDRS/9fJi9t4yhPfL6isYtjWvsFFr1W4QNuKB0ZS0arh/cwXB5S7TveuD4wFLTAijMJYwdDMSatRhLb2LH7U61xOFuKzYhTzp+ESupLaVgWtrgqST44d5/owMaQl0g6GSFewSdUiUA45phUDvGFDM09Ad8/AuWAIzNwwgSNuhbzsaWbVnqoXXIlFtfm4rApA7fh+XKuHQWSQL8oyANnuL2Kv+PZBPlYphGJdMVFI+Oh92j0Zxk0zvFjaEnhXdWmbO4KwG/80t1iNu5KK9YRwR47E3hWkvUQcfxnlx1zsRJd6u/TctdSEuml1Px0Iam6BKKeqTNSI//FWsfh1t9navfYsx53yXeWmhxbEj3nUCQOpCojlH9cjN2V62mhRiF/dVm8SQ+2uFpd/u8akEOxM1l57lzdhG6rarwuLRspDQwThpeTL7GztecXMnL5cwXOQIlL4ptPmWOMUE9gJyA9pIU+3/jMJU+/j6ZRztYdr19Slx85KIi/5VG3FtokODbuzZhLQKYfirsi2RCjNEvmnhEFFZKkwI+k01Cg1kNFtlqDezlfusNN97OWaVmDNhXYr7pPNd/PJ/l3CkW4/V926E/45JtZW+98Fmkd08kwGdqsvy2kHOSxohjNmGu9et+7tTKOpSEoNS Kxrpjhen smqHRN6VqVDZbVH18q500IWoc9bfVRlKXDrsuMnBYid7jiK+HeUQMAuYV3LZDQGfZtAByEOwHcSXNyut6vUFW/+14ZOdr2tN1BjpQ+yDUDaeCCT/bP7862H5A8aGJGTv1PKnIGQy0npIhSZTTZyLNUydBzk6TnLOhSPJi19wOZrQcHIJj9eiQSBfwd6sfxhWadWA9q8ugUc7mxtbULXKM8sJS2R8AiZuFzM+oY28HedmK0mBTR7Fzg/ObGh/xKXRLmjZaZOgBQ1bd+tzeCzoQlisHLmnXcZC4OmaGB6EilGS5XT+zWBW/GuyPZ78sfOM/KC75+M8sHU4hzbeMmI9FD/SBqVKRGgsNORyAr5NruRPQoYUe5YqgdTXbx9u6abZug57m0pTwAoPjmZopvdxb8o+63Cyc+GlzWqEpylZ4HvvIdPcDybOlTEwRtIC6B6+e232fh/mfEvh9AM628vCx/ngr1HPunQTbqO+wxiClHLewSfP4dMWfshk5fA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000218, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 03:02:30PM -0700, Luis Chamberlain wrote: > On Fri, Apr 21, 2023 at 09:14:00PM +0100, Matthew Wilcox wrote: > > On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: > > > Just use the PAGE_SECTORS generic define. This produces no functional > > > changes. While at it use left shift to simplify this even further. > > > > How is FOO << 2 simpler than FOO * 4? > > > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > > > + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2, > > We could just do: > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > + return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS, Yes, please. > The shift just seemed optimal if we're just going to change it. Nope, it's just premature optimisation at the expense of maintainability. The compiler will optimise the multiplication into shifts if that is the fastest way to do it for the given architecture the code is being compiled to. -Dave. -- Dave Chinner david@fromorbit.com