From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA1EC77B71 for ; Fri, 21 Apr 2023 15:35:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F40806B0072; Fri, 21 Apr 2023 11:35:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF0B16B0074; Fri, 21 Apr 2023 11:35:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB7A66B0078; Fri, 21 Apr 2023 11:35:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C81C66B0072 for ; Fri, 21 Apr 2023 11:35:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D77A140686 for ; Fri, 21 Apr 2023 15:35:06 +0000 (UTC) X-FDA: 80705796612.04.C77A8CA Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf08.hostedemail.com (Postfix) with ESMTP id C348E16001F for ; Fri, 21 Apr 2023 15:35:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="p46jR/2a"; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682091304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AIwc2EwMoi2Tn8izgV4+Oz6B5LB65bXuCsFCTBVkivA=; b=KQsMG2AvDcOTQkVyqxXoWavIAHtEmysgUJ7xCzH++oLDDBQ+t9dyJY6lEk7KYZA0sXGyja ivgeM11qNnn4grjRHoiFkjDYBqVVL0oJURxMc1ew1G+/ULh8j0bnaEfPZWCXVRZRMNxs2D qtaWYzorEbxMgG/p2pR1KY5iR0qScOE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="p46jR/2a"; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682091304; a=rsa-sha256; cv=none; b=Ev9Z1kzRucydTN2hNLbDC2o7pb0Km+wzY3ldGLd24taglxKrkzpHqthTo/V05hQ3+9DyyN Fw0AoJvNHfSLMWPwm3ixpEu2eeOyewB8qE0VTE8Sqs/Na4CaXiItyYJAXn1/IW2miES46D MU7oN4itArVTOczvPlev7JNudrPQg10= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-5ef59b5a1d2so10176466d6.1 for ; Fri, 21 Apr 2023 08:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1682091303; x=1684683303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AIwc2EwMoi2Tn8izgV4+Oz6B5LB65bXuCsFCTBVkivA=; b=p46jR/2aVJ2uuWmw/MXDI1Bw0f8UBaTgoMrk4pt6iKCrL9SVUq8FNMpvaMf/q8MVmg HNw0sTRu87WY3YOHQ98z/CBUOc2QtL0XQBD9EskNE3OIoIh+cpLEsHtZI0yEObQDFBhj 5f4+3re4Y4n6ztZ6B0XBnRhHyIQ/0a8c0mj2D3VymBJMxJJRNBQm7II5R7mILjp/5wgo AjZJ6WoIXS7D3kqqKI6sEnDtQHuLulHE1790VNTugUTainUef9mdTzSBM0mF2l4+J4Tr RDeu6ernIEcm2e3aijuIrwuybZgRywzldQ6kAPGIOgMAGKQJ4SREXTL8Gb7Q69C1XewD NNXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682091303; x=1684683303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AIwc2EwMoi2Tn8izgV4+Oz6B5LB65bXuCsFCTBVkivA=; b=EGS86w6WNMqUrU5Ui1QcRRMULy+SQQLg/tgtG5NMQUqHuDtkYEXEhW1eptojqCi/Yb 0LYaZ83yJiAXXvwu8KiIKT9Il0yGJCHUZKN6YqjR0/k4a5X5W3Y1Z4hVcyE2yKbRNGyY 2lvGNYu+FGNBzNkrpJBuRfMLeR/c2YrzzsX0r7acl8GkbcTOvbG/fi/nAga3f2LI1/1F ZBDsWooPXIUx5qDWs1kzaNB1zOGWXNDsLum2vST0u+Uv7CzUoCsSxEikdRIOS+P6SmnC izU6UVMJYAK1LwojtGd+hs66QOrWF2Tg10sFJA3KReDrf++Tfhli8Q7+qUW6gxcYmAzD 7lag== X-Gm-Message-State: AAQBX9eCyGWCYSucRXESjQek2fJFoeP/Kbl1es8LkRAW/wSGvUtAdjCV D+7jaTiYpk2debUtpYd3NUX7Dg== X-Google-Smtp-Source: AKy350ZwdA+v1rN8c74PIN9+mxpgKKx34vtCEgUKJxx7MVUc0wFWqwCTLswvulkzoZyCh1F2bg589Q== X-Received: by 2002:a05:6214:d6e:b0:5ee:2789:15f9 with SMTP id 14-20020a0562140d6e00b005ee278915f9mr11262767qvs.16.1682091302909; Fri, 21 Apr 2023 08:35:02 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:6f0d]) by smtp.gmail.com with ESMTPSA id oj2-20020a056214440200b005ef593385e3sm1249813qvb.1.2023.04.21.08.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 08:35:02 -0700 (PDT) Date: Fri, 21 Apr 2023 11:35:01 -0400 From: Johannes Weiner To: Mel Gorman Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 12/26] mm: page_alloc: per-migratetype free counts Message-ID: <20230421153501.GE320347@cmpxchg.org> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-13-hannes@cmpxchg.org> <20230421142841.parju3gmqmpefigq@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421142841.parju3gmqmpefigq@techsingularity.net> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C348E16001F X-Rspam-User: X-Stat-Signature: owh15qzzjqrof7dqf8gzs31iw7ewb4qh X-HE-Tag: 1682091303-589385 X-HE-Meta: U2FsdGVkX1/hTevTM3nnHFW9YC6oTQzbBdXPfneJVcLz7PWBjJbJh8fW99iONHw7z9G/dA3JXmp+yVcGYt93zyoaklWZLTGNvvfiOZO2zknjXC3BMVX9tR3YoOttxaInnuf9aI3QD+/Q2a8HUUL8K8bgweKRELXE5VOpkYf3mvJZxAZqmmerwgWPJbD8KhYb2/dQLQpKRjjhNhEyPO8dNK/pAX8JoYhZzc46pGT/DCNjai+2UV4Cn7EbE+wqn6KpA+7Z9ApAe4HFpJPDc/MVm+dqoqzoOpQCE7Ml36SwvBwGf+tWzOjt3TEmawocgCV85ycq56XBL48vrk+aJgPEMqKBiwc4b56Egwten3K1m5n/BrCzOPJXJpEUk4qBDnjmZAgHyPWzsi+uXVXMx6JGS3zcbxljftYCxCC/VEJayiTeefNQ5cz5z4/dXKPQP7XeCcgCcusGfV1PaNTCcQiC8tNB0N7sCfyjt7I/MtkSC5GObzhvNyPkw9CujOTXZF2Nm4z5OCHI4HY37QM66VF+rITNCQdxvJp3+FFkLi/UACigmC/8dh23GwM5uDPXfTyU8znbisaebNuKBYoPaLgjFHYkY607IVlCKDgS6V4YHZpxXeSYnwka31BWMypiYwc5NahKMFalT4wK+u7ZuBkKGOEaO5t7F2j3jlABqdizS2g+uCs8WW6Unhsu7cDnKErFPw6Xhx9jxvmmeGoKY9hc45Qma+LPps1tnYZXhp2JOFUmE9wLoFkd8pmONAMpvyLf8+AlmCyTY160HF/gY8TH3DcFxB5h7bwFR4jFZwF9Edg/dV/E7vgVedjLej+m7WxbAmWTaMOfaaPgoeSVTY1DvZxtnTQDxxh+eAGb6ziPc1nuLbukpVUWldJDEjBKZohErVn0JoyGDffdFiQ0ZGENeg9im55swQyafZmW9rs5TVdBCVFh436o4rcHwJgihBluGn7gMmvFD9NFhUR/FN8 GOXMN8b7 7LizUbDYpihHhk823Ziwf7EXSXneeobsVAmUdoKJvit1oXuw9mliakbRim6eRpMrXmWC87jQvpjjLziMJ5NvUj2Nz2KVbj8GWH2r1Wu7IxKL1WubnO7F8/fOd/73GvUOGeMLxZbGjeyrxNb+7CZoK7udnI3C7LubOqJPHDuSfkuNsu69w7fZuA4PVK/tcx795tqN+Mm4EeUsDsiwLjDu/n6dPdUTNnJ3eaPKyzW0fBDZK0c1wT9CGTcu8GIfU8AH2x4Q1lH3pZpCv3U5PT7sX87Gm8qhwXGt9fiz3hlyfpd9ATmoyeA6SryqV1MaZ6Ijc478Zh22KrOeL5ymnNQ0g+/IkcuXkoLXmKPeP8sZAGxrd3SbsBlDqt3XRROqbUtk0qiQQ18KRWCom86VsnNQOkY8/gCrrBW9sljgsAX5UPLbfk++C9r7ZZ6OeRcUxfcpaOBL/H0TUH7FGXp3ouolaeszNIC0IApOktthBd4YLqKeYG285TeNsM7OVGBif5buGHVc0X1Vypry1hFU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 03:28:41PM +0100, Mel Gorman wrote: > On Tue, Apr 18, 2023 at 03:12:59PM -0400, Johannes Weiner wrote: > > Increase visibility into the defragmentation behavior by tracking and > > reporting per-migratetype free counters. > > > > Subsequent patches will also use those counters to make more targeted > > reclaim/compaction decisions. > > > > Signed-off-by: Johannes Weiner > > Visibility into fragmentation behaviour is information that is > almost certainly only useful to a developer and even then, there is > /proc/pagetypeinfo. At minimum, move this patch to later in the series > but I'm skeptical about its benefit. Having them available in the memory dump (OOM, sysrq) was essential while debugging problems in later patches. For OOMs or lockups, pagetypeinfo isn't available. It would be useful to have them included in user reports if any issues pop up. They're used internally in several places later on, too. I'll expand on the changelog and move them ahead in the series. Thanks