From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E7BC77B71 for ; Fri, 21 Apr 2023 15:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5DCE6B0071; Fri, 21 Apr 2023 11:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0D8F6B0075; Fri, 21 Apr 2023 11:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD55D6B0078; Fri, 21 Apr 2023 11:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BC0596B0071 for ; Fri, 21 Apr 2023 11:14:32 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F623140788 for ; Fri, 21 Apr 2023 15:14:32 +0000 (UTC) X-FDA: 80705744784.20.F9C385C Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 6CA7D180009 for ; Fri, 21 Apr 2023 15:14:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=CUg3Elq4; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682090070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x7VjX6mpJ5cFi3m7vM66Dwsbikc4Q0r6RI58qqcJeXI=; b=AqHv7bjRGV0Cd4L2UL87jEOyI4k+VQTSbdz1clZsO7lW8GhwIO3A7DI4GDR1zuweqcLHR0 gsf3ZGRd+gFiUcEJoVq8Kfi28OkPL9Ghlby0n1aOgf47K7unHI6QWV3nvkpMrYaJMFwpkr +D0BqOFkA1Xt28fSHGvxLU4pXxKYTbI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=CUg3Elq4; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682090070; a=rsa-sha256; cv=none; b=ZbSS0h78S8tVgFnW7LlI6ue/kRjnHYLSvANkkKAJHvvRZWr/SnVb0z0pnBAOtP9ww3+ZvQ 8d7EhUj2cPoj3KsPsqFeRSjVbHKIBHJGTsLX0mrs8KJr59BK/eCLQB7GHbW7883WBxKK52 Y0an3egLcUJNhZXhguBAqueEbUWa2tE= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-b8f34bca001so2268807276.3 for ; Fri, 21 Apr 2023 08:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1682090069; x=1684682069; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x7VjX6mpJ5cFi3m7vM66Dwsbikc4Q0r6RI58qqcJeXI=; b=CUg3Elq4Nt5PxsgOUDGNRD4FyKDQynFgQU+dVG5lLhvVqjmH5lo6cjhCscSXeNzexQ DAJx5sSfGq+MXhUHbYtUNlUCDNsVwWM5hEsMRVrnYlQpiI7A+9Q/WQxe95HHoHrluq0L pBED21tUXX1COrH8Ux4b1C4eKrvIsAUDUlAS1/9LDEOIhqm3r6HBDXFhk+BRw0ST94Mj 0uJy98nxaI15eCGca9juXquGUEMEWcjEc3AmSCz+VpkU0kt14TbJHOIP9CgYuCMDnczP GKscbVsSgXk/47qzCxlvbihUvQhRcb0/e4SDFdIV5NDHUFY81ucO8EXRA0y6QZnK9gH3 R6GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682090069; x=1684682069; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x7VjX6mpJ5cFi3m7vM66Dwsbikc4Q0r6RI58qqcJeXI=; b=L6z9w/gopJJDRC2cDxVlLa8KCKRLOPeMmWRBu883U7/SBtjo0g2JKT7fUPmntM5mHq YFdju9XEpcGzvO6Ji1Qkio87YxIiSSZO6W9L1Jx733L10vOybIhmyQr2IZd1b9e+Fdx4 sgTia93Abyv3DhA29KDSVevdmG7woOAsF4o5Y9EsN+y5DSw7NDO8wY20Klkv4XAwABfm iVxNM8GzJ9/5nmsWYUI5uSURIDSa8h5rcOlJ+uf8FoSlgXLvwGCHJ6t3zCQKssqbrx8Z /YkzXTkhOPE5X6J0frmocAxtjSG3ELUUhiJnQIGX2nz3jLpjNuwUAQ01EzVwt6Aa2Ftw l2bw== X-Gm-Message-State: AAQBX9cFj48RXOFgC9bS8vM3IiJS5O4PqlxcMFjYXk80vj3pffDYgI7o aJhUeTaSK/GpKyNnib4y2C5ZvVXdG2k2AIAtXoU= X-Google-Smtp-Source: AKy350YPHteLRp00Et4PERpGtH87hoCnCwqsQI6zl7gaNxZJUiNmIgA8w2EvGj6RrDSPdk6yI43Aew== X-Received: by 2002:a05:6214:d4d:b0:5f8:ad2a:fef7 with SMTP id 13-20020a0562140d4d00b005f8ad2afef7mr9673559qvr.32.1682089689353; Fri, 21 Apr 2023 08:08:09 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:6f0d]) by smtp.gmail.com with ESMTPSA id a18-20020a0ce392000000b005dd8b9345aesm1226270qvl.70.2023.04.21.08.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 08:08:08 -0700 (PDT) Date: Fri, 21 Apr 2023 11:08:08 -0400 From: Johannes Weiner To: Mel Gorman Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 06/26] mm: page_alloc: consolidate free page accounting Message-ID: <20230421150808.GC320347@cmpxchg.org> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-7-hannes@cmpxchg.org> <20230421125453.np6b5hirktkj6ji5@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421125453.np6b5hirktkj6ji5@techsingularity.net> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6CA7D180009 X-Rspam-User: X-Stat-Signature: d1ih3owcd6nahjegwb7cjx117stz8chh X-HE-Tag: 1682090070-878525 X-HE-Meta: U2FsdGVkX1/W20csgsVnbQ12PsVgoP9+8yRn5c0wB/Z3XNn1aBPfuFw+Ddv81BHyU1asjhUXohVfmdsXZw23yZbKPhvxFh1h+nGGmvbUQnUel2ZAhmIqUT/O1r7wMSPu9aohc/J8q85gvo+hU/9lxk6OPEcJSfp2GKtfDmxcbeZWvX8gAvBUlkI4eb2xglUxEVZg3efXdeoqOz8ukXB5Vj8Y1YszlqbinuSMDSXNOWEnzBR1wcPecAiMcjK4ovdx5a/8rP0e3YnYxTYd+e0YDKaT5x/mP9/5hjCUAY2DFrM75c4XONwXadpSD1xzWYIiM2DDUGAq+2sfZCAepYfc5e/kaTaDM0bjrgYdrJqZmF1uHUrHz/zM67O/hdjQTOnhVzRkVJR+1rn02/HK2dn9HxNLtcFvkF0Of59dwfdocfBBf3JnDgmF6DJeRvy8pW0gz0vY5/G6EbvimAuyKkIOJZlzyMGoLHrb/rswmAZjD00MCaRLSqz7tRwXwJ4G1lh6Im3ynFDBhzsN13b3aMf4RkTryyJiaiOljgZSNnFeJsBGY0vgq0rWkOpABhVlfDm6ky3eHWGi0gzj1j/UYuwbkNvcgZpbYsJyHupocrdwxvdlAKSagrA96NFCxg3UB892EN0AhrsWgJLSVkSrximl5Xd6hm6mM3pxDK9riPkCk60vC0mhqodQNLm5VKtlNbeZK+cf64AO5WxWxaTOFQpuHUmRuOy70LB7AwNSufXCP62bOGRnioITz17lQRQ0A28ntDr/t+/N3Ren8ToBCQhqlMfB4kn7dlZ6COMXXpbm0XnCk+KUdNBg0cEKTe4AxUxeF7HFMKkIn36ll/1RO/zrB0CfxNKnU2pkZ7+Wxgf8Cg4b/NoZFo9YpF3CaIjh3njmKNa8c/Sb9E4HeQWWnAPNX77ZyPcDqLAh6+GPOUGP0jjTQyL2rGtW3TQDM1twojqPMTvkIgyi3BTpMm0RNh8 yQ8LFBTJ n1lmK3aN30d84qKUFaogPSzEwj9rBHN/mrePG9GL7kpdhb0wdaji98QLawG5jxx7MbEX/Pg6VeiXUFD7wN8C3dCSx0XdAPCIRotfQPS2ypjEvVIvblRs1+Lx7SLf/OE0cq8xhvF+a1ag2vcor8fKeYopN9r0jV4x8q+hdTFCzx1oH2G3uQfCXw4/3pOvA78A7W+DLvH/qVfoLfcv3ojXABZ5qg1vhDc+AoDe1hq3IJbS/plDSAXa0Hnfhe2dLYNMhgeygVtYUmojqWKpE9CepGLPX0eyvdH8dnbWenhDyNJD884stDb1DrlKW2peogSQh+oQnOR649z02fAHc8NhTaKQpZy1YQZXf7eaXuzPX7o2Z9SEr9Xxs2Fw+Qe2waRwg3nxLjOAS5AwduqyKaavF4rBXC0K0rnY06ikA3idEswaPivGybbMwkUk/LdhMzvmK04JHZYgQnCRh8qiKcBHBwL/7k5+EFpNmSn47Co2Yk7vEJTAnEEwfsrdPGlLaInlbAkFpvXTWOV/VfgjtCiCb+cZtSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 01:54:53PM +0100, Mel Gorman wrote: > On Tue, Apr 18, 2023 at 03:12:53PM -0400, Johannes Weiner wrote: > > Free page accounting currently happens a bit too high up the call > > stack, where it has to deal with guard pages, compaction capturing, > > block stealing and even page isolation. This is subtle and fragile, > > and makes it difficult to hack on the code. > > > > Push the accounting down to where pages enter and leave the physical > > freelists, where all these higher-level exceptions are of no concern. > > > > Signed-off-by: Johannes Weiner > > I didn't look too closely at this one as I'm scanning through to see how > the overall series works and this is mostly a mechanical patch. > However, it definitely breaks build > > > @@ -843,7 +843,7 @@ static int __init debug_guardpage_minorder_setup(char *buf) > > early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup); > > > > static inline bool set_page_guard(struct zone *zone, struct page *page, > > - unsigned int order, int migratetype) > > + unsigned int order > > { > > if (!debug_guardpage_enabled()) > > return false; Oops, this is under a config I didn't test. Will fix. Thanks.