From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4073BC77B71 for ; Fri, 21 Apr 2023 14:57:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A92D36B0071; Fri, 21 Apr 2023 10:57:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A42DA6B0075; Fri, 21 Apr 2023 10:57:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 931DC6B0078; Fri, 21 Apr 2023 10:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 814786B0071 for ; Fri, 21 Apr 2023 10:57:03 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 595FD120318 for ; Fri, 21 Apr 2023 14:57:03 +0000 (UTC) X-FDA: 80705700726.27.F5DC8D2 Received: from outbound-smtp10.blacknight.com (outbound-smtp10.blacknight.com [46.22.139.15]) by imf27.hostedemail.com (Postfix) with ESMTP id 5B10A4001A for ; Fri, 21 Apr 2023 14:57:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.15 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682089021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m+HAhtJ6SwJGqYj7xmRd1xMtpV96EzQAbNAKDtjSuek=; b=r2UZ2A4sk1QUWodkmifYuThbiBCejOdldZa5UGGfCAxZiay1K9l7ItkIkTQBtTaXfrtV9+ HqFPx0TqDb1Z9HDNWyoQGYZ9Ub/a6Gp3KzI2r7Q4gLj6azsk+t436/Fc7GvMPwDU+Ubw+E JUcNnYyHSuW9W2BfLKk4toNfFYdbTfc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.15 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682089021; a=rsa-sha256; cv=none; b=OiFKw5KeV/7H64LDUl5tKLCVDaYs/H2L/yl6w7lBRTQJop3zXLWyP4SYsnPID3ZNJHwZAl EtMuZd8dUjtmYsdObocYSWmpsWwDB1jlyi3s76y1H7SrM9KSukvVLQCk0YcAEcNaWrK9Xg zWqWi4a5iWj1z0tfD9K+HjamQnw1m80= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp10.blacknight.com (Postfix) with ESMTPS id B93771C3F9A for ; Fri, 21 Apr 2023 15:56:59 +0100 (IST) Received: (qmail 4981 invoked from network); 21 Apr 2023 14:56:59 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 14:56:59 -0000 Date: Fri, 21 Apr 2023 15:56:57 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 25/26] mm: page_alloc: disallow fallbacks when 2M defrag is enabled Message-ID: <20230421145657.fnpjqkuyquy3z24t@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-26-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-26-hannes@cmpxchg.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5B10A4001A X-Rspam-User: X-Stat-Signature: pzbgiasheuesuc785n5tnwoymjs3u8y1 X-HE-Tag: 1682089021-186259 X-HE-Meta: U2FsdGVkX18AKhWorul9t2dAJ6E5zHw9HT4B9dls5j21agesISbavrNG3PkQbhRdNfAwIid5g0L2glhYMDpktyV4r7E7Nr28TnBQi51VJ8nYPoht8sD/ng+PHDo1irH9FkJFRv3SH/43sSh6rIfIUdLzP2NexbGfa+ws07AdMaTxQdDo9XAVOp4h3iDCfcXKRxGnDgI9x/Ypwcu4Aj15vitEAxZ7tA7k+L/Z/Y1xMSDPOA5OB2sqhMObtcaFWKISTxABheIwTGtYVJT9gB+g9mkGBbEWk7ppyvvpGbKPgwIja5oeSITUDNSWz6o4Hv9pcSY8uPlxanYuP89deeGM0jM5tXDh7MBgzKeFXjWFE0J31JVO0IgS3rD0kCigta6Nhuc89FMA2MBt0Wu4aBt0uCQNI8QF4AT67j/eggLTE20eNdIJlq6jkh2JBxqWwqv0ghd+k1un0BwimLzLEyxZWeL5qq9Wp7IJFjsXODLa4l2dIL3dgSNG4jdgx8IoD5fCvbA2eCFeG3K6DLIJ5wFhokoovrnNRF3OrhoxaIsW54V0YJRVSeodlDc30gjiaTXTjzEo8R+EdjAT4ON+lRDVMVwp6+uJCARsw5gk1XRjhUIDokZcaOTVVsbpT0EWNj3xdaTW+2E1pwjgHhPl6XHpLXG66+ziJaSuEiLWibBNhPX6X7h1LJc9Z/GpT8D+NMLS1ELu4VB4itRIpT47vyKITsThQnq6G/dXgVU7y7eTOkYTw0d+Rkromt2V/VPRvUHlmGMrWd2hXWv4AQRwch7P2DGioQsq9+Aiw3eUge8ELm+EBAfCVHPaHwLtCGX/gZQBl6nWhCtely+XvAJZ9+eLWC9nRV0HBUDEVDE96zmmipW8K6bz15hVCdsOoOoJaf9DgeC6kDTPBVwgNIFb+T98nH6sRv8y3Yis0pbX/qRTCk9+IviKfpFldRbXiAdQkduAcdbizVbty+UTCUR/djm jSH/g8M3 uU7BIP78ltxRCDzybGhqq4hV1y4cFwOlrMVRhGYRUNcks3ltg/WveneGnSScPcy7WLjLZvte/3BcCXQi2gec6ibIGrORXhyy05i9PF0nUq8uuwKJOTsGBvJZeSW91M9RrY/tvJGGzvSI7tBW+TV3OmXb3pquUARrHtuIY8APdxzZGYXHQvI5nGYupDqIUg0qiLSCloUwX+hzB6B3CsrT2CKj0kpLz9UPw6b1Lgvo3sEDbFrJLPQsMAOGhrELF2/DGgR5N5QD9WFg+zeE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 03:13:12PM -0400, Johannes Weiner wrote: > Fallbacks are already unlikely due to watermarks being enforced > against MIGRATE_FREE blocks. Eliminate them altogether. This allows > compaction to look exclusively at movable blocks, reducing the number > of pageblocks it needs to scan on an ongoing basis. > > Signed-off-by: Johannes Weiner Conceptually this could be fun if a GFP_NOFS allocation cannot migrate enough memory to free one pageblock and there are no pageblocks available of the correct migratetype. Fallbacks might be unlikely but never being able to fallback is a livelock risk, no? -- Mel Gorman SUSE Labs