From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C727DC77B76 for ; Fri, 21 Apr 2023 14:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 346DD6B0075; Fri, 21 Apr 2023 10:39:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F6126B0078; Fri, 21 Apr 2023 10:39:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5D76B007B; Fri, 21 Apr 2023 10:39:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F3926B0075 for ; Fri, 21 Apr 2023 10:39:35 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D271040437 for ; Fri, 21 Apr 2023 14:39:34 +0000 (UTC) X-FDA: 80705656668.02.3D880E4 Received: from outbound-smtp01.blacknight.com (outbound-smtp01.blacknight.com [81.17.249.7]) by imf10.hostedemail.com (Postfix) with ESMTP id EF2B5C0017 for ; Fri, 21 Apr 2023 14:39:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.7 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682087973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1H6gZ6CUpg5q93avmSnkTgrk475ac9oCIYGefmfeAXI=; b=rRAi5Ul+vM0vDoz6e66BVgbNmtZSZrU6pD0DVL6vxlwsEBkt2XivQE5rtTzwCO9l64BrAl hitxN48015rGOR3/3VTRM+PS5kmdOQgAUHYtGCUpWxShXIB0Yo5fz0Veyy3ZyA5qdhrmBG vSQHKkqqkkcK6Z4eFWsgWQi7PhHpxNc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.7 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682087973; a=rsa-sha256; cv=none; b=W18kCVVGu68AvH9p82Vf5cOa61umnzk/tkNLpO9BfSRZH3V2zTLRA7z3F6+bZumFKDeEvO 79p5QPUjsHR5VVAdhd8UYxeWi0KEd0yfyXoMR3me/1MUWYBZycl3xcFkaHuaKOGKzonzzt z+4ieFiF2gVs/nM6SEypE2InJMcGxd8= Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp01.blacknight.com (Postfix) with ESMTPS id 30927C4ACD for ; Fri, 21 Apr 2023 15:39:31 +0100 (IST) Received: (qmail 27573 invoked from network); 21 Apr 2023 14:39:31 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 14:39:31 -0000 Date: Fri, 21 Apr 2023 15:39:29 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 15/26] mm: compaction: simplify free block check in suitable_migration_target() Message-ID: <20230421143929.riofzlnmn2dgqfc7@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-16-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-16-hannes@cmpxchg.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EF2B5C0017 X-Stat-Signature: h3u3hraweo1jqgw83ua3uxajg8pfkhgu X-HE-Tag: 1682087972-644282 X-HE-Meta: U2FsdGVkX189Qe7KIlF6ilJVGaBwVBJVKvvwsJ702eIbffADtfxylf0mSMvzgXLidK2OjiPEnRO49aOFkBNU5vxVpBVQ+wrgk/CadgY/tA30fgUigZyEAKP3d56PR3F5ZJk3B6nLz+wH8bAMecA91g5b4YB1tYLo3lH1zuvRb20xZdo0y+TW1kunWq+Vo/xMuYZ1be1S4oyu/PFDKboZEvrFBib46OkmKVBJLg3LoCEbpwRV2PyMdhnKRfDOmBx11wtf264w7rc/DszqP8ZmsSjNE877ZYXJ0sAY5YPbPVkORSz3STIYFzj2miWM4djbg5DF4/6o/OA75gg5WO3KoLisFP7XNyc9kacOpvWe/sCFqKGroIUxOAmQb8Tj9Y0PMYZanAhRJNr5Ixbfg7+UXcwZsZMl9TvAZ4pHteEXaHm3q1mS7OTyshbRGUZYAevZC8YeYWV9EpF2jQb7VrX3js9EAJ5UDLAXJ0gt+jNgkx2XjnTDPWPHd8MdFjwNzrT7HXZlYT+JVLNOewwVAxke99O3A3JZXkW/4piVxRC7q73hdYVZWJWrzwJI2nc82RcrpCuS2hYeEr30Cm5ZAfhjOIygM0ZalpL1QDSfMqlsu7+rbWBfafdp0twMC99T/giF10e9peT1s076G5QegQ9+HvYN83VGhc8AChwYaSd+nhN98NBo4ySstNeivj8wMvE+DfzDt4piyFSvWubwLVRozAukMsoOmrwNDdmAMRG2ex9cNZIuCxSXCoyvuogvMPkg/nKQaa8r2OlSsJNe63gfdSPoozEdW3unLIjvDrLMMiFWpI9IXZQNnVvpoiLXFQvbAjuEWkKYLbDWi2tglNu/LFModKdVa2TEKn2N0wrx40V/LtG2Y/V+zPuvQ5tFIdzQNTsVvh8VapmGMlTZx6bEu6oFS6juXT4TfzexhufOSPmdACrGGNGRlM8jkJBWg+Iku+i/BwCoU2wrvS9q7gT pmgoFxPk Wq3D1ldkVSQeec/ktDIwM+ho1rDK+4J4YiJpwT85HzA75/Bh8Oqlm+shdHN8aXbP5xcv/u+X9WlNlloUURS6eZDXXfQParZDR2EceK6BrOH/oL1UoaiZqZHuCmmCYL7jOfei847U2B8LHo/qysb3dU5Wmu/mgDGhMD/apZFIz35w5kXzer8rRESg2yNA3PreJTw78EAFUYkyXTNvSloxVdre3oYXuvMJcSM7XRQscU0ixs0kJS4TjNq3Vys8QvoTpmVzcssey5vW3nxNLROTSL6+4Wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 03:13:02PM -0400, Johannes Weiner wrote: > Free page blocks are now marked MIGRATE_FREE. Consult that directly. > > Signed-off-by: Johannes Weiner Justification for patch depends on whether MIGRATE_FREE is itself necessaary. Even then, it's a micro-optimisation but maybe it matters more later. -- Mel Gorman SUSE Labs