From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4A2C77B76 for ; Fri, 21 Apr 2023 14:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FEBA6B0072; Fri, 21 Apr 2023 10:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B09D6B0074; Fri, 21 Apr 2023 10:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F07266B0075; Fri, 21 Apr 2023 10:33:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E29216B0072 for ; Fri, 21 Apr 2023 10:33:03 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8CC340422 for ; Fri, 21 Apr 2023 14:33:03 +0000 (UTC) X-FDA: 80705640246.28.7416208 Received: from outbound-smtp62.blacknight.com (outbound-smtp62.blacknight.com [46.22.136.251]) by imf05.hostedemail.com (Postfix) with ESMTP id D582710000C for ; Fri, 21 Apr 2023 14:33:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.251 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682087582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7BJ0UHbMiMNyQum2cSiHT2OjxG0RN66hYcFrUbIj+G0=; b=jCveJgi4QYNF9fchRjgC9lhrp3kG6xKpZmlpD03TLIAS/GHvckNg7GDhsSmWqVr/mu58WQ cW1H3zgoYGNTvYFyuSAXT9g7FSySLQIyEXDF/rFhQwycNZ4AId3D645iHs16G4XDbiAvXp v+OebdPN9rIsZQNJSbSaNk6kUx5N7Vk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682087582; a=rsa-sha256; cv=none; b=Ky1HvOJpSfVze66CuzjNpSPMdIiCVoIVtVnoXZuzvSKV4MsT6pCMMi3RtO1DI7SsQlRUj0 j+lYoMyb5mRTDCcEXSd2umggBO6YTW1yYNEsamuGcVwCDfoWtIpSk/QpAxRJmaLmlNbnV3 4sBqwk19j7xwopywdjFKjIIBGlKKglE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.251 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp62.blacknight.com (Postfix) with ESMTPS id 39D29FACF3 for ; Fri, 21 Apr 2023 15:33:00 +0100 (IST) Received: (qmail 23535 invoked from network); 21 Apr 2023 14:32:59 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 14:32:59 -0000 Date: Fri, 21 Apr 2023 15:32:58 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 13/26] mm: compaction: remove compaction result helpers Message-ID: <20230421143258.c24oytksvehbqs5w@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-14-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-14-hannes@cmpxchg.org> X-Rspam-User: X-Rspamd-Queue-Id: D582710000C X-Rspamd-Server: rspam09 X-Stat-Signature: nimpzukraij19czgzmbddtt3s31bg3y7 X-HE-Tag: 1682087581-653276 X-HE-Meta: U2FsdGVkX18Rbr5wxKdNlvXd83XWdv4ypo6KKUFFyF3/5XFxaGgaK0QO8X/f7YSdWG0n8Vvwj7HDtDZ6sNf7pZ8m6mHPI+qLDZNWEhlZhPPIwyBSNpQTZKUogI8EaoVHDA2/xwtYRzXou6Hp3IL0+kUFfj66w+CI0UeVoseT411eYoZZ5nMpv/lGHVjdVjeC/HjZY9FWN9dnvcBms5cKFH+5/2ZXvjr6YPqeAGh2t3H5zItID+vLH8uJZ/LDAUy2xX8BOjJDzp5VueI7jsX62QaRhMmQ1gWEp0Dh9xeMVvpviZ54rPemU9Kk8D5zxRv6xQWpPMaTT7Lz6D8AbF/4SPIkLg7dF2N+53jLzspJtc3xD8k2XoZQnzEEtYa0AJlkFSY/sZcpHAxXDmwur/Wshs76L4iuB6Bwnikeeqs5ozZ64TeUxvPYWtMcQb4a7FKsVqaR7zOampG3WZvwTNSJjekThUvgid38QEWBt7TzhqcjQAXlIHRxoSv3bJSAh0aLuooBjAoOICSJgEWYwxCwulp1ao/TUrWRFdujpS00XHIiEWgjEYMZO4O8gBRMH9kVp3ceSkn2Vy5/dsZa+05XVchHh3ivD7bPuwjwTesQoyYwlRvBQzHZoJGkq/PQstdUjs+6bVzUmRjP9pkbsu789MCMCJUq8yNZq1VMSicMcd1ZyMSzOl+FWSReaiGPQ2bMj/ckM6SIw3bccfzuovrL9ZEjtaAzEKrPWyAn2nuh1Zu+QfiUpovec59zFnJYFKiAWJNTdWTcT0/herf1gW0H14yVOrhMMdrSZkW8nBdXQ82Yo8qbeZP+6j5NMeiv/DlsayiPh11dNslsCgagMvUbHaeOy48GVmoX0gtOlY0CEjCJZMDvBnIzFBcjEs3Bi8lMRieQuoYTs5jR3vxDzBU3ICEUM9AliHVRd+cTKySAcT6C3433wQ10we7gzWaYJiIf+yw1wag66clg5lZdON1 VKuk7dSN VGSKEFeBBUoJJB7LpQxdIY4dnptxZTc015ohiJW4tofxmnSPtZ5yE9SlNVQZSBP/LNO+ftX9hryhKRljS2I5uBtpRgd8/XujYsZofv+SOoWLuIeiDIJoUeWHu9oluTdX7XVOKK1CqiilyMNqJfo9uDpT4o4X9VLRODYhkXwyc/B3a/Ng0yt3cjSR3eL9sV+1wGD7XpyfScsYo6ydrwZzxMbwP0bDjJK2Ahiqe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 03:13:00PM -0400, Johannes Weiner wrote: > I found myself repeatedly looking up the implementation of these > helpers while working on the code, which suggests they are not a > helpful abstraction. Inline them. > > Signed-off-by: Johannes Weiner Not massively convinced one way or the other. Still, probably deserves to join the end of the preparation patch before MIGRATE_FREE is introduced in the interest in spltting the series into digestable pieces. -- Mel Gorman SUSE Labs