From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A29C77B75 for ; Fri, 21 Apr 2023 06:57:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A1DA900003; Fri, 21 Apr 2023 02:57:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52B3B900002; Fri, 21 Apr 2023 02:57:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A51F900003; Fri, 21 Apr 2023 02:57:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27772900002 for ; Fri, 21 Apr 2023 02:57:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0A78A03D4 for ; Fri, 21 Apr 2023 06:57:58 +0000 (UTC) X-FDA: 80704493436.24.934310E Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 22AF040007 for ; Fri, 21 Apr 2023 06:57:56 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hbF+Bk8o; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682060277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iCQQOrDHvv7muofgTvhggno9gmpvYe5WVwBD+zXre78=; b=X3a4DS1Pf1gpU6mepl0oDJFGrBvlvXFtJKagCkIgFPgt6F+Vb3O/60WK5NEbd7iOq8F9Qx vklnCwwYHQHM0lx44+7bp4XZBOExARSoWa8UBNqBXzIrUNNG1w0y18BmWI7IF2OEwZ7Txd B8XDCQgGY7n+1QYnAMiRuSQrjnaxXU0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hbF+Bk8o; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682060277; a=rsa-sha256; cv=none; b=rE0gUqHNPpWwZudjEdcJJ9cmHT202LxzHEiKBACTF84WtiPE5UBFwEULnz3xd/H2SP8EBi +fOn+iz2q+6WHgu0g9Qgk0eaHB8p7rLcoKhaYLkn9KLVUtaSUAw1ADUVWWg5p64RlWyqoz cA5Mlixw6S92NQZ9bmzp5lnUYrcQ15g= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-63d4595d60fso12425906b3a.0 for ; Thu, 20 Apr 2023 23:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682060276; x=1684652276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iCQQOrDHvv7muofgTvhggno9gmpvYe5WVwBD+zXre78=; b=hbF+Bk8ojjiZO6o2ok3vxf1WbShiuo5T081GBEE0UAfUBksGieFJSgkGacjYqBeK8w zt8XcYoWlevrCYjZed9y77ALfx/FxTMIwIwFlhupB/WwZM1Z1umn0C+QVKNQOjZ4t1v4 rUbAMrVRBbyd04gOqF9r0veBQA2+tqYWKmYcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682060276; x=1684652276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iCQQOrDHvv7muofgTvhggno9gmpvYe5WVwBD+zXre78=; b=GjBFZwiMCoodP+gmL6c5tUrLlra7a5yqDxRWfqsNSpyhh7aTP1+PVvTlRADiusTBOq DF6UYfCpP7e2ybsonNzBUhQUxkRe2JkvkK87SGIF/qhrVXboinsB9KQJe+Af95ANT4bg tFJbyhZM/yKjxoYEX7LfUX/t7dLuBSzRZnDCwnv5rwM0bxkGtJdCwq6x38E6Yok1czDl NTrOeJiIDksNcCYW5qtiG50w6kMdmvHIz4oiSgk2uKYfreHPvHFNFAAdkBaMgLPnez7D aiFhIiBXaE+DX42/3z1nSDK+gncPDjLEhY0GopbGXf412/Ii/wqTIQJc9wX7yIavDEKC 8WAA== X-Gm-Message-State: AAQBX9cyInNm1ISWuAO19kxO260a3Q8EuRFaYv2LuliVDNXUjOYfxHia bU4lV6Fb4NO1pUHdT2IeKs/JYw== X-Google-Smtp-Source: AKy350ZEEP/PrU7kYgyyZkKivdaMPHUVf5WGz+Wiu1WQ8mlkUVfjfkCNB7ZnxyH4DOCp4JsT1PbWNg== X-Received: by 2002:aa7:8554:0:b0:63d:40bb:a88b with SMTP id y20-20020aa78554000000b0063d40bba88bmr8194787pfn.14.1682060275718; Thu, 20 Apr 2023 23:57:55 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 136-20020a63008e000000b0051806da5cd6sm2038374pga.60.2023.04.20.23.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 23:57:54 -0700 (PDT) Date: Fri, 21 Apr 2023 15:57:47 +0900 From: Sergey Senozhatsky To: Johannes Thumshirn Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com, agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Damien Le Moal , Minchan Kim Subject: Re: [PATCH v4 13/22] zram: use __bio_add_page for adding single page to bio Message-ID: <20230421065747.GB1496740@google.com> References: <20230420100501.32981-1-jth@kernel.org> <20230420100501.32981-14-jth@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230420100501.32981-14-jth@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: rtd63hgfs4mmfmp3zfijfy7iddg51pmh X-Rspamd-Queue-Id: 22AF040007 X-HE-Tag: 1682060276-632734 X-HE-Meta: U2FsdGVkX1+9gZzwYMztrRKdIGJ6bksPxzyfiy/UJ3PEI+oeAxeOHIIGfkssDB4cFLkhjegJjQfTM8xDpnGoCYyREUFs5bCSYK9pKLa/TkOkaeg+Ba8mltXoVwe0S9kfjd3xvAbgnSX01nuFTkWzc3bMeSNZkrWFN9nkINroXVMJppVVnWSBKKVXqxnTBdmgGAnEJU9SVaCwQIs370gunxlmt8siNZFdjMzNTv7nUoB8LaV0+8u9iTpWooB6HtZhK+VrH/e8hVM+qtBBShC/HK6FGb3B1hM7D8dtoUDTVe0H2dSxyJjkhhdXg4jqWmuTPbjsNQkFxud18GcKNWtHCaG9pKRqAbe2SCD/g6512V+PD64xUTzD0GpkGg6IcKNOrhjPQDljqhkVF5PqS0BhZQ16URFuAqrp2lvpdwVz3T2MtHJEQpJ6AMCH6WGScLQRD8KESdJBHM3EKz9KO9g56kYOmw7FfZsOE6PRfIA1nYDkBYmf9ldYC0Z+Yx30Ndahn12LgJw607CbZQbqINQhZgu52SZWt7T5TbjZCw7aWOvnX0+YuqJylbo1NQeMkIKixVnO450DVVTjL9cUdUiCDti9WmW39e9DPzu2x9DICH/31eshqA40Sv1Uhcu9Fkn5t0XN3qg3FuDX0HlilKRVSBJ5xSihg4/ShvgpWXk0zvgMBq89UOSpozaTW/mxI5RNp6yAc8JawEHlcN8tiR9isMe6pipC6qt1QV06HCk+tFpOfxq8w4bv6LZr14qj1TnntjtFoVqBnXTljX+3l7IDpliocpOLyfftuff9Lfg0lKJf9va/1hPRaE4DY1Y6+y8T6t5PgojPf8SLcuoc8PSyQfnuKAZXlYgA/rzzUcY9GejxHkprDb4tC5IKn7QvLgPfwcmzba5BHBxy6cBKGlZpoKgyMdwFKR1kXtcIEsTC2rPe30wJdj4fUGhBpACub/8g9n6SxexPYfheK4wUV4o 7c/YhLt6 0XblBRV+EKJxGcuz2qSKraPmXXU/ln3wUhDQWjYtFKj0a+VNml172g0qcKgD6nDxjfRkXM0SMCHt6KkOUyHmdqcVu51f0rCM5NtgH9XCVzowdFV5tpdqF+r68VsWc1xKL7Kh7a2f2GcoxMaLh8sm3iDBexlyZHfZx9q7/fqg3RozJOL5lkkid5wh9/FBV/Ojqj7RWvjxjPWMWXAItmc/VqfGsT0/VPaBfkNhJVIMtNxJa5T3+2iQPoi1eZ2BeDifLC9P7pCDj5rZBHjOA0q9KAWe6uPPKGHuHx6OR/TcSSqDILRU3Q20LizH3D97Jew/Phty/pgsRXxHy/XRW9WKfndvL+TQxZbTIrKXRT06l6IUIqjohmdi6SxkTCrbjFmLodmkAomwsyZ+8EN3sxtrRSO4jmoG65di5qZKaKEqdiz+1o+5/ZwTlSsTKoHGgzUtqmF0FshywhlHAmcRS+QD9zHX8Vh7pHXK05i8f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000316, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + Minchan On (23/04/20 12:04), Johannes Thumshirn wrote: > > From: Johannes Thumshirn > > The zram writeback code uses bio_add_page() to add a page to a newly > created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Damien Le Moal Reviewed-by: Sergey Senozhatsky