linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: cem@kernel.org
Cc: hughd@google.com, jack@suse.cz, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH V2 5/6] shmem: quota support
Date: Thu, 20 Apr 2023 16:02:34 +0200	[thread overview]
Message-ID: <20230420140234.5mv5kixwr7bxnu5r@quack3> (raw)
In-Reply-To: <20230420080359.2551150-6-cem@kernel.org>

On Thu 20-04-23 10:03:58, cem@kernel.org wrote:
> From: Lukas Czerner <lczerner@redhat.com>
> 
> Now the basic infra-structure is in place, enable quota support for tmpfs.
> 
> This offers user and group quotas to tmpfs (project quotas will be added
> later). Also, as other filesystems, the tmpfs quota is not supported
> within user namespaces yet, so idmapping is not translated.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

I've found only one typo fix below. Otherwise feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

> diff --git a/Documentation/filesystems/tmpfs.rst b/Documentation/filesystems/tmpfs.rst
> index 0408c245785e3..1d4ef4f7cca7e 100644
> --- a/Documentation/filesystems/tmpfs.rst
> +++ b/Documentation/filesystems/tmpfs.rst
> @@ -86,6 +86,21 @@ use up all the memory on the machine; but enhances the scalability of
>  that instance in a system with many CPUs making intensive use of it.
>  
>  
> +tmpfs also supports quota with the following mount options
> +
> +========  =============================================================
> +quota     User and group quota accounting and enforcement is enabled on
> +          the mount. Tmpfs is using hidden system quota files that are
> +          initialized on mount.
> +usrquota  User quota accounting and enforcement is enabled on the
> +          mount.
> +grpquota  Group quota accounting and enforcement is enabled on the
> +          mount.
> +========  =============================================================
> +
> +Note that tmpfs quotas do not support user namespaces so no uid/gid
> +translation is done if quotas are enable inside user namespaces.
					^^ enabled

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR


  reply	other threads:[~2023-04-20 14:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  8:03 [PATCH V2 0/6] shmem: Add user and group quota support for tmpfs cem
2023-04-20  8:03 ` [PATCH V2 1/6] shmem: make shmem_inode_acct_block() return error cem
2023-04-20 13:17   ` Jan Kara
2023-04-20  8:03 ` [PATCH V2 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL cem
2023-04-20 13:25   ` Jan Kara
2023-04-20 13:40     ` Carlos Maiolino
2023-04-25 11:54   ` [PATCH V3 " cem
2023-04-25 12:32     ` Jan Kara
2023-04-20  8:03 ` [PATCH 3/6] quota: Check presence of quota operation structures instead of ->quota_read and ->quota_write callbacks cem
2023-04-20  8:03 ` [PATCH V2 4/6] shmem: prepare shmem quota infrastructure cem
2023-04-20 13:38   ` Jan Kara
2023-04-20  8:03 ` [PATCH V2 5/6] shmem: quota support cem
2023-04-20 14:02   ` Jan Kara [this message]
2023-04-20  8:03 ` [PATCH 6/6] Add default quota limit mount options cem
2023-04-20 14:39   ` Jan Kara
2023-04-21 10:20     ` Carlos Maiolino
2023-04-21 10:47       ` Jan Kara
2023-04-21 12:34         ` Carlos Maiolino
2023-04-25 11:57   ` [PATCH V3 " cem
2023-04-25 12:30     ` Jan Kara
2023-04-25 12:56       ` Carlos Maiolino
2023-04-25 13:21         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420140234.5mv5kixwr7bxnu5r@quack3 \
    --to=jack@suse.cz \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hughd@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox