From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029A9C77B72 for ; Thu, 20 Apr 2023 13:40:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FAFD900004; Thu, 20 Apr 2023 09:40:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AA6E900002; Thu, 20 Apr 2023 09:40:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C59900004; Thu, 20 Apr 2023 09:40:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 672B7900002 for ; Thu, 20 Apr 2023 09:40:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 350E8AC671 for ; Thu, 20 Apr 2023 13:40:51 +0000 (UTC) X-FDA: 80701879902.24.AE583B9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 7805440028 for ; Thu, 20 Apr 2023 13:40:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vPNsC5mp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681998049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S2wONjox08db8msaKO2WYqOIW5Ae1jz69YejCVntwrk=; b=jJcrv3ZcYTr1QmOTRDBbtKuYbAlw6GZFTJjnqJVtWWLrCmPERQAOymkjBcNMxdGNieo+B/ 4m5HhfS3QIznbhhHTp9nNHlxJrxieiGM6m+SarJaJl27woK/b9v60YLqytD86VcNP9An0T gfu2QaA2Gkll2VCq4RvxiZsh40IEm2Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vPNsC5mp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681998049; a=rsa-sha256; cv=none; b=Mtbkf/dmKHBSu1ZR20qaO5tK8TMRQMauiNAbsIrMSWviUgF2LwRMjcAthuzcy9T2ZYWHBx qw3VzLOXl4TDHDmX9/Mvm+LwTog88xyKRS1KxeiHdZEUrAoSSyDyPRKSh3DhojJuXY/MrT h2RV/IRMKUDtZbfDP3THW3X/4g0oKdY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AD1261173; Thu, 20 Apr 2023 13:40:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F4CDC433EF; Thu, 20 Apr 2023 13:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681998047; bh=MRxKldcFY1ijDw5IIxD43bDbNia8QfxPMVwcnt0mZE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vPNsC5mpAU9aE2iVewuFg3mhrJ03+acrucvtsKYnCZ3IhroTpHi5MnXqyums554kh cTxH+B8m/cOVxnU5+thFqPoPdylJOCCNkVdVPISXrXQL+kJ17oxzTiEAt4otLxpWIL KEwWLmvbinTuKUwfvgaKJRTXEEjAV8wL9/av13n2Hm2YGu55tgbAItMu7qpcmCapXt Zk9fyXmCPWHAexpCeabMNHyQIDY70nbk2pyqTSN2d2jBlHc4tRlnsZm/i8lG8/k8oJ 9F5QZowQDK53czLgYqN7nLul6iiht3NyAThCm1VFIi+z1bgDV/nfWx/jwEKrlxA8Bh T9zqDUg+kHFIg== Date: Thu, 20 Apr 2023 15:40:43 +0200 From: Carlos Maiolino To: Jan Kara Cc: hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V2 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <20230420134043.25rxcb4du4wm6h2f@andromeda> References: <20230420080359.2551150-1-cem@kernel.org> <20230420080359.2551150-3-cem@kernel.org> <20230420132516.qbrwe4cuvhckde7b@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230420132516.qbrwe4cuvhckde7b@quack3> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7805440028 X-Stat-Signature: hbr5usrobsdk97qg5syy8rhpma4amxqu X-HE-Tag: 1681998049-887357 X-HE-Meta: U2FsdGVkX1+9y050HBiuSGefQIAphY/Xq24WnQji7ECbAOfad5FUObkdgr7w44fQWUrasvCoLPAgIaZi/ti+JIbPalYjaWaVKsQlgqH7XGnIUBruKfgJXrCSyuUBRYt6IDZrjzZQHthWuPfD7rNMSNB+aoHPvZW8yDArIbbxTiGYB67XdjG7k5Q9yfo0kDYOs4/Ry68/4acbJtXozMQwJebdkyQHdOOZgYn4Wl0D2btDCTDNT3Y4cyaWlQS7zEirLHJo2B/WEckVWyewWqlgpUoW7XJAC3ZlLlbOtd6v6+tKBQge/dgMKIFfgA72ckuaTtl690yiYjoFkgOyyApKmJojwmpyVOuAPSizFN6/x1vIKGmHVlBv/UVyGBBZMP4/vgEglmWdniWYMd2zf4Pp+JHa8ZqZKVCPR2rnOLFJjoWqNNzFI09s4azjfV0k7VHPokPGaO6i+dAriz35XegahgY0A5PGcZFpNLv5vP2FOUbej0GvLt7EbjlAL4Q5NvBJCYko8BY2JsiYwBggj7DSYsqEv/PGGaf9QizYElYXrYTaJ8P3oLgL7C34I0ajM5E3+HfHi502ft+h7eZEQ+vlmA4+G/l4gUhErv1NKL4ot0kbheAg3nY81W7MEQvXzxOJ6FMKnMvIS+/4TkZ+g8dRKuh0FLVMEUVJUdmRm2ouhpggw5jP270pWwZjRE6Lsmkaz1b7BH3JmP9R+c9u5E2sCe3NkcdKL51ESGQVVLucjbK6YAlTQ95pmkz8NhYtM//F3g/2MgYm/nmoE5y4vHNR3PJUTHoS6fz7/mOMg7Q33iovS3Tbl6Y4/LQgXYvHnCfWDPQC4f7h8/URiNboqmAG6Ehe0n1gTSPZ972WEXk95oVr3BFLGHT7zjjOLL0aJ8v+4samAiSnFln8agKBdwoslDnSeTGh5m7jIqHY3rRt2E7B0ieHLLKmdY//b7flPQK3LldgCHe5qjf36HJU4lX jxoIEnPj IPlswfy2t2xvjs3VYmZlxH+pV2TKFgkH67Ir26xyR+pcKo46a0Cb1emSYxR/OeADVpaGFQ5yqB1JakXUgMcVZ4a1BxSbR9cfYFcjNFZH/pfOftS3ST388CyTXemoVEcUKHQtnGNung45hTcI3qz68zm3RNy74nFZ/CsmxAbIPo+CKyYFfPzEjJM6FmoLHLc8OmmkR+QVowEXYnMCIe+DWEGbmekEqqJECrD/S6qjC9UFBSE2i7tLSPu+r2TxXTCzNCpp4yIRwoeqXxES+kzFhSIoKldwRN76BgcM5OMOhLQYGRjhRvaS9NuS9o3CJInW6fCtkRi3FxYAc4Z2b/DXCKqrhgXI1s6Hkc3u9cJ4dBLg5CbFGId0jwDWWX3OPmt3kBLE1OddUpO2QcmrMzxqEjhaaG2o7n4IIKzFKyyS4mNm4B3u7f7Ih8eZHbKmLHdMOuxe/l1MGEsPtwlcwAN1Sfb+wcXg/5SkukKgs47vPNxnmyXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 20, 2023 at 03:25:16PM +0200, Jan Kara wrote: > On Thu 20-04-23 10:03:55, cem@kernel.org wrote: > > From: Lukas Czerner > > > > Make shmem_get_inode() return ERR_PTR instead of NULL on error. This will be > > useful later when we introduce quota support. > > > > There should be no functional change. > > > > Signed-off-by: Lukas Czerner > > Signed-off-by: Carlos Maiolino > > Looks good to me except for one problem with ramfs fallback: > > > @@ -4209,10 +4228,16 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range); > > #define shmem_vm_ops generic_file_vm_ops > > #define shmem_anon_vm_ops generic_file_vm_ops > > #define shmem_file_operations ramfs_file_operations > > -#define shmem_get_inode(idmap, sb, dir, mode, dev, flags) ramfs_get_inode(sb, dir, mode, dev) > > #define shmem_acct_size(flags, size) 0 > > #define shmem_unacct_size(flags, size) do {} while (0) > > > > +static inline struct inode *shmem_get_inode(struct mnt_idmap, struct super_block *sb, struct inode *dir, > > + umode_t mode, dev_t dev, unsigned long flags) > > IMO this won't even compile - "struct mnt_idmap," does not look like valid > C. True, I totally overlooked at it as I've been testing with/without TMPFS_QUOTA and QUOTA, I totally forgot to disable CONFIG_SHMEM for testing. I'll update it on a next version once we get a few eyes on it. Thanks for spotting it Honza! > > Honza > -- > Jan Kara > SUSE Labs, CR -- Carlos Maiolino