From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA43C77B73 for ; Thu, 20 Apr 2023 13:25:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E26900003; Thu, 20 Apr 2023 09:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE61900002; Thu, 20 Apr 2023 09:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BCEA900003; Thu, 20 Apr 2023 09:25:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1D643900002 for ; Thu, 20 Apr 2023 09:25:22 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E475D40209 for ; Thu, 20 Apr 2023 13:25:21 +0000 (UTC) X-FDA: 80701840842.05.450A3CB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id C5B1E80024 for ; Thu, 20 Apr 2023 13:25:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=m952Z1iY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5V72OE03; spf=pass (imf02.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681997119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bjZJGFYF7RHYIbl0f70AINTNCHrtYqqAEsuq8oLRtSg=; b=jUtnFRtNphtAh2Ziid2n/rD5nro1QvdY1u8y8eZnThici55Cq38MeIfieCnyZ4rT+pWiPy ClkQRMNcCDZvVaQLJZ98NDpcZCVE/ZZS4JWOg8mxVuf9VHV6IkGaRPOiNWvLaaUiIBrRsx +ADq0aTUfjltDPLRmo9IKVSGToa0lwI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=m952Z1iY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5V72OE03; spf=pass (imf02.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681997119; a=rsa-sha256; cv=none; b=qqIWtjv8M20PK8+ennoO8Rb6jnfsZ6RQSbm5WJQ/eJlPeCV/gwpPrBsYuXBHyC6vETu8mB vV7wZobS0nmC9H3oeJacQwhwI/Rxd+L+Gm9A84WsB8Ksgm4glAdAJkxhdJGdh/APQIST0Z mPDQNeCgscLvx/qwmZJJbOFQLXTPb8I= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C3EAE21B1D; Thu, 20 Apr 2023 13:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681997116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bjZJGFYF7RHYIbl0f70AINTNCHrtYqqAEsuq8oLRtSg=; b=m952Z1iYkyGa1z5ldO/1O7lE0fRpL2wJ0gF1OlZphN22mbS1kvUu6hOLZz4WCxV2XKVkBV TRMhrFbzOqLGAJ9YsFwNFU5UYej7qXoQjYxwpw2QQQuqWkWBFKxcFziln9PhcTJs9dywKd U4YdtO3TYGsgLrLqW6venEuwti8JTeU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681997116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bjZJGFYF7RHYIbl0f70AINTNCHrtYqqAEsuq8oLRtSg=; b=5V72OE03NeSp7fR/CAEo2WNo+EZMNcAAV1VE4lw7dinjvKGOktb46pnGEEX8jpI/XU+4Ow GPa7NiK+p8kiHBBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ADADD13584; Thu, 20 Apr 2023 13:25:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hspOKjw9QWT+GAAAMHmgww (envelope-from ); Thu, 20 Apr 2023 13:25:16 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 21051A0744; Thu, 20 Apr 2023 15:25:16 +0200 (CEST) Date: Thu, 20 Apr 2023 15:25:16 +0200 From: Jan Kara To: cem@kernel.org Cc: hughd@google.com, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V2 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <20230420132516.qbrwe4cuvhckde7b@quack3> References: <20230420080359.2551150-1-cem@kernel.org> <20230420080359.2551150-3-cem@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230420080359.2551150-3-cem@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C5B1E80024 X-Rspam-User: X-Stat-Signature: ypnupa96nf7khx5a5g4mtwhs5dqg5tyi X-HE-Tag: 1681997118-458666 X-HE-Meta: U2FsdGVkX19ABkMg6LT3SjEegb+n+GjY7Rm1f2Qpmmame6K+BxBQtfyp3bnYO1XXBQYfy54uKTUhAYSRsONvr0e/RRc4gJeyF4KeBn4D7+QLOdMIhq1Ia7g7lQ9N6IE7AfheH7XjNYEd+REOQytyM1n3EmlROed4clhi+qPjyKBSj+RQUtkpLonpMai10Z58sxbZf+tl/0iFyqVCOYAf9sV2rD/9DH76KuLVk7M1nPxJ+Prd3Khn6JfH1TE1v6v/SplvDwxDwJQfVeTF5YGE5itgb9MAbyQsrx1njWkJPi/5KyloVPe5Oyd2cfNNyfOOmyTgyKm7yAhqKbchi+JYL7u4/uBgdEW+lkoZrEko1fi2L/A645hgPn2aB+Bmxn1BLpc6LYH8QGaIRf6TVhMH5cE3G1zYmz//3njB1S2lxH2xjVh51vNdW33FEtptYhGWEIQwmDRZSCgsHj+S2xwoATBRQcLKqYQKTjcYpWXnIaQwfJPLkZx3rx68AOGo/twWQBYBxWSr0D2GyLUOl6Y3LgUN1VQ7jtElkbz4YHLOp/i1kh1IXd2BbxKCJP20BzgKfdhUopcQd5/aA2PLkkHBsXUPjG0nDwVpN7biAp+eLZFiyjEqxnx95YXUU4TUDGaAZW9Ya1SmBYILvDopUKfP/10jGAkc5lr3eDkX1iKUzaBFFk31PaeNmhm3XomWOlRQf4+n455XjRMgPPyZrSYfYCbJ1J/5nvVWdiBAjbbdx6ForkLPRPweqTz7Dt0X/lvnQw6nFSP6NCClRvv66Ghtt2VDyXYVc31ctnVMUoojuQYh8qpc4AfX7Bs0mb5463f7nBPp94gpkFh+M7yVremGsRXaQa6jzJH7arT7cJAWHxZtFv3yPI3RPdE6gCC8//FohjoLPxyYN3NVOD2HnD9mapR1D+vpnJ15DCzObray8vFqpC0zO9w7mZT8gmXBMf1PmvQeWDBOoWypnJtfXST wl1OtJ4O iXJK4PKc/QUhd9rwyB8AsAkaYtBiBGoD4+Bm2x8rCWMl3PYPRWyT47srVW8PmgVwfSa2Lm3BmOvQYhFyodUuE7loBOqf9qK9mh6WPgmXI0atjRFeXDuhNKMdjlZkP+0/2DFdBEgBA9MkHJMnyCayzy4OAo4QXWrkOJGnEPNnjfxS6le7EQv4Ezry3To74OJlEqf6vAshdqpTO+FqmB8q5TmiV7dmgMqGr20Csp7+HFrrFuWFD22p4yTKpIvsyY4WywnTPsQZpFsByf3FnZhatr642GRfYbar8WX+M7l5pdtJWSQejhAFFTd9PbC94k3awkDuMkIQrO0GwOcezhSWgBWI0g2+fKCW0CtYQzUfOwFGdztqmBREa2vssLCxDfIx+9921ru+0hfI0wcI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 20-04-23 10:03:55, cem@kernel.org wrote: > From: Lukas Czerner > > Make shmem_get_inode() return ERR_PTR instead of NULL on error. This will be > useful later when we introduce quota support. > > There should be no functional change. > > Signed-off-by: Lukas Czerner > Signed-off-by: Carlos Maiolino Looks good to me except for one problem with ramfs fallback: > @@ -4209,10 +4228,16 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range); > #define shmem_vm_ops generic_file_vm_ops > #define shmem_anon_vm_ops generic_file_vm_ops > #define shmem_file_operations ramfs_file_operations > -#define shmem_get_inode(idmap, sb, dir, mode, dev, flags) ramfs_get_inode(sb, dir, mode, dev) > #define shmem_acct_size(flags, size) 0 > #define shmem_unacct_size(flags, size) do {} while (0) > > +static inline struct inode *shmem_get_inode(struct mnt_idmap, struct super_block *sb, struct inode *dir, > + umode_t mode, dev_t dev, unsigned long flags) IMO this won't even compile - "struct mnt_idmap," does not look like valid C. Honza -- Jan Kara SUSE Labs, CR