From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9487C77B75 for ; Wed, 19 Apr 2023 22:18:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80B5E90000B; Wed, 19 Apr 2023 18:17:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7963D900003; Wed, 19 Apr 2023 18:17:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 571BE90000B; Wed, 19 Apr 2023 18:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 47D2D900003 for ; Wed, 19 Apr 2023 18:17:59 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 17B1CA0358 for ; Wed, 19 Apr 2023 22:17:59 +0000 (UTC) X-FDA: 80699554278.27.3D71DE6 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 40A87C000E for ; Wed, 19 Apr 2023 22:17:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b="pr/kZUHr"; spf=pass (imf10.hostedemail.com: domain of atishp@rivosinc.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=atishp@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681942677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aZA9SkX62fIMzNEcuGtwzVe8Up8R4eolVQO1cYHyNXI=; b=52Cm37Hc3n4+DYLNyu1bWw+b7tS25pufKNOoaMMo+s90eGU9xSMN2adVZpQSGKwBKzdND1 o7U0M56kl+ptmWB7V67Sdmo0R0T99YkhZ8a58bfAjMAD4T7XDUUoLDXGlcLNMvK9CuZTk/ Bg+xSeQUoENcfECL3qlmj1kWpyeSmis= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b="pr/kZUHr"; spf=pass (imf10.hostedemail.com: domain of atishp@rivosinc.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=atishp@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681942677; a=rsa-sha256; cv=none; b=t8NH+8CVhW0PyjyPrmNc1B7zfEEndSlbGFzEePQxsWJHC7hg9J3InKELCFBTj+kfeTljlj aAJgG6HimtcaA92fu/zc1+VReveSWyYEOfECUQNWs+LgMZxT1FQ8z9lFY/H2SBxxkkLqnq W9jK6AgZnsHL2SB+ESpM4P1R49ja9E8= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-63b50a02bffso366505b3a.2 for ; Wed, 19 Apr 2023 15:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1681942676; x=1684534676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aZA9SkX62fIMzNEcuGtwzVe8Up8R4eolVQO1cYHyNXI=; b=pr/kZUHrkhLnktVNRdfz4ij02MTZd+B9h2TaIJSMbt3NVujPvaiFp7Ik4rbkspQ4Mw yuGTwtHLYNepi572aUMJZXGKBGxqqLOoQQAVLkJQE8EutQeaNnEXjp7ozMrwLpK3F/bd Ea/tWnKPdLgS76oaBzGp+E0BB9Obb3YUpFKxXwNOfadBL+8Y1NryGBq3tL1grWdeANk4 WZM2Z6J10fv3mT8jXclG/Jc0tJeziAmqwuD529CbKYuuh+zFcMDe14NqalRMWLaTiCrI zVE7Fohp3aDpbBaOaQnfhoMTTf4olrAvxRsbHG36Vnwm4rXJhTcr8zeKFydq/GZ4e/40 +9lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681942676; x=1684534676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aZA9SkX62fIMzNEcuGtwzVe8Up8R4eolVQO1cYHyNXI=; b=PvyjG1PiovJAgHXo8HNHUSeyAEFdZUIUXxDHyX2oWeOqHt3wSH6I7Z2t5NNBRyrMEh nfHVLwCkhUwfvZ0BEOXH8E8JdsJ2KwvLRnuXUiaqN9SWSW9mB4vhFya9T8QKYBZN7Qdi hRSeqcucGTIpQNKEHXGPYw1YNUt/qLDd0fVg4twlLVc6sUK6jmUzesQ8hhvro1PaWle1 VwoQdG/0tUfEWVtEcrDyuiwEXZwFGJNgitv+gr3LXZTeVI7d0YhYyJI29q6cN/e1vieh ZJEcHgUrdgaYTMA4Fdyya0yZoXna9JdV3/7WcDVZrrUgw/NwqQ0qUYqycePIgYMSgi0i 4l/A== X-Gm-Message-State: AAQBX9cKzKSxUUB0yk2KSH3Z3H/0Rnj2142LtoLXaPD3ql8lmZ/s4U+I LLTL4/uc4lTYsHy4T7wuX2Wt8A== X-Google-Smtp-Source: AKy350aluUR1rPQXEDjya7qc0cousjv7HzRiR+wEHDbTSJe3tj7Btum5nXicmgptUoZ7hSCP4qqeQg== X-Received: by 2002:a17:902:c40d:b0:1a8:1cbb:4f76 with SMTP id k13-20020a170902c40d00b001a81cbb4f76mr4908149plk.28.1681942676188; Wed, 19 Apr 2023 15:17:56 -0700 (PDT) Received: from atishp.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id jn11-20020a170903050b00b00196807b5189sm11619190plb.292.2023.04.19.15.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 15:17:55 -0700 (PDT) From: Atish Patra To: linux-kernel@vger.kernel.org Cc: Atish Patra , Alexandre Ghiti , Andrew Jones , Andrew Morton , Anup Patel , Atish Patra , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Suzuki K Poulose , Will Deacon , Marc Zyngier , Sean Christopherson , linux-coco@lists.linux.dev, Dylan Reid , abrestic@rivosinc.com, Samuel Ortiz , Christoph Hellwig , Conor Dooley , Greg Kroah-Hartman , Guo Ren , Heiko Stuebner , Jiri Slaby , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Mayuresh Chitale , Palmer Dabbelt , Paolo Bonzini , Paul Walmsley , Rajnesh Kanwal , Uladzislau Rezki Subject: [RFC 12/48] RISC-V: KVM: Exit to the user space for trap redirection Date: Wed, 19 Apr 2023 15:16:40 -0700 Message-Id: <20230419221716.3603068-13-atishp@rivosinc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230419221716.3603068-1-atishp@rivosinc.com> References: <20230419221716.3603068-1-atishp@rivosinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 40A87C000E X-Stat-Signature: 96fycik9ki3wwezwhcgsey9k3mhribij X-Rspam-User: X-HE-Tag: 1681942677-62349 X-HE-Meta: U2FsdGVkX18G0notbdlzFSS9s31KY6UrZGfzj3f2ke09WnnaQ5YAjiipVYliAAFm/42Vrhxd67K3Px0vyf5WDW76iztX/rslv14o6HES0bH6XTOIgWQ/dBS/5eSepQldPuMzdiCXg2XhDCjnKcqemM5M88lyFBPOdhjFsV84M5EKA4srgOnctqbhUUeo7dHVI1fOgVzTOd7+bCyZRCUqJnHkjflGMoWR4vRpNQ9UnEgreH67FhL5ro7WCJxOigSkxzA2DVNzMTdMR3qjg7+tl0EV5iAVr1oJEOX1luo1JbPHYFovpuVeNKxnoMxK0ZTgQ7ZLzPV2s/g142Uv3+JL3qcqAMHqNDaFSfkMkHfs4/2U6tak/+Ly+4uolGi9FuBTTyd0GbO/08K5R9iSdaNQ209aZ8aZaEvIWmEmqjUWq7OrbPtJdHas1TgjXAFnWnH7gNkmZMEKTcNjKkvyaLc72YV1vbHWgN8j9r6z/UfFu7MbjWS8M9Ib3KYktscK8vQymrsUiIf66k4PHLPGPf7DUicPDMy8kPj3mvoD4ugYDPQujytjrgBy00i/Ew775ufHrtoZoJT0PnNGLODXHiu28hqp45wq1JDRQ/DttBQFZ/1tTr/oJLrsq9U4UUN38iSMTRccTSYAYwPdL2nlwoa5NpFEJg+6B9MA3rRxLygmBXKuMKLVxy2t4kvPmJ5ZlOA7bhku31W4Do8e6r81uzybncRKR7DqjLJFWijy3msKnIPC7akU2dDyoDybCY1qqDP8OOfYY9VFEoJC6O9OfxG5U3AzpF1edkNWohHY/JK7aPtlC9b74Lsw7V6O5eOn9N9C2ACEaIwgz1YwvdHGW1G6fVtrHjWhQjBtXKfyUSr9UZAOv2VX+OGEusBLuWSCTXQKEhCzt3i5m59Xox19pmppCRwFAguKW4x74pBIOwtQyXBn/txsZFC6Y0Nbt8sruCmADmld5HVk8FtK6MHwwDG WjsX2Uqt 4bCSLPSZ0ALC2fEbk2Lt8uQhHQNgfKp6gyYHoSOYjzQxivHVGTx8EZDiR/if1Adzp5A8++YeBVtTS8uckeCUso1DN1iOPng3BgNLUJGMrnXm2h0SbWqVC65W4aLSWP8bTa2bUApfa2dVi00F6f+69zXprLZ/4NNJFd2BQUQAJMK8GRKZ1x2idC/02B4N+VI+J15zVmTucaWLSuZJJ5YRQziGAFBWLGQDD2H25mBNfBpuC6BEBZfi7bPYoJDzpSEBrzc82l+0SylRoULWrU3WxTiU1wI1iAwZimT/nIhtxfBs0T9/nZkgIk5f8eQg50V/EXgFmv45CMDc/j34I61mj3ffbX6Ht/nsTn0KC/sZVMOm+PFgxlHxrIhiP/Xajiptkq/V/pPQtCAc+Vau7CaJH5HcOchnKP0Dx9xzHOjMS/fpuLIc4p3YiAlRktOoXOn3ddfWgPjhEAI6gcxfWFRSL38uBJ1EE/AlmwAhqA8Nz5Ji4C49y9/BZvjAETg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, the trap redirection to the guest happens in the following cases. 1. Illegal instruction trap 2. Virtual instruction trap 3. Unsuccesfull unpriv read Allowing host to cause traps in the TVM directly is problematic. TSM doesn't support trap redirection yet. Ideally, the host should not end up in one of these situations where it has to redirect the trap. If it happens, exit to the userspace with error as it can't forward the trap to the TVM. If there is any usecasse arises in the future, it has to be co-ordinated through TSM. Signed-off-by: Atish Patra --- arch/riscv/kvm/vcpu_exit.c | 9 ++++++++- arch/riscv/kvm/vcpu_insn.c | 17 +++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kvm/vcpu_exit.c b/arch/riscv/kvm/vcpu_exit.c index 4ea101a..0d0c895 100644 --- a/arch/riscv/kvm/vcpu_exit.c +++ b/arch/riscv/kvm/vcpu_exit.c @@ -9,6 +9,7 @@ #include #include #include +#include static int gstage_page_fault(struct kvm_vcpu *vcpu, struct kvm_run *run, struct kvm_cpu_trap *trap) @@ -135,8 +136,14 @@ unsigned long kvm_riscv_vcpu_unpriv_read(struct kvm_vcpu *vcpu, void kvm_riscv_vcpu_trap_redirect(struct kvm_vcpu *vcpu, struct kvm_cpu_trap *trap) { - unsigned long vsstatus = csr_read(CSR_VSSTATUS); + unsigned long vsstatus; + if (is_cove_vcpu(vcpu)) { + kvm_err("RISC-V KVM do not support redirect to CoVE guest yet\n"); + return; + } + + vsstatus = csr_read(CSR_VSSTATUS); /* Change Guest SSTATUS.SPP bit */ vsstatus &= ~SR_SPP; if (vcpu->arch.guest_context.sstatus & SR_SPP) diff --git a/arch/riscv/kvm/vcpu_insn.c b/arch/riscv/kvm/vcpu_insn.c index 7a6abed..331489f 100644 --- a/arch/riscv/kvm/vcpu_insn.c +++ b/arch/riscv/kvm/vcpu_insn.c @@ -6,6 +6,7 @@ #include #include +#include #define INSN_OPCODE_MASK 0x007c #define INSN_OPCODE_SHIFT 2 @@ -153,6 +154,10 @@ static int truly_illegal_insn(struct kvm_vcpu *vcpu, struct kvm_run *run, { struct kvm_cpu_trap utrap = { 0 }; + /* The host can not redirect any illegal instruction trap to TVM */ + if (unlikely(is_cove_vcpu(vcpu))) + return -EPERM; + /* Redirect trap to Guest VCPU */ utrap.sepc = vcpu->arch.guest_context.sepc; utrap.scause = EXC_INST_ILLEGAL; @@ -169,6 +174,10 @@ static int truly_virtual_insn(struct kvm_vcpu *vcpu, struct kvm_run *run, { struct kvm_cpu_trap utrap = { 0 }; + /* The host can not redirect any virtual instruction trap to TVM */ + if (unlikely(is_cove_vcpu(vcpu))) + return -EPERM; + /* Redirect trap to Guest VCPU */ utrap.sepc = vcpu->arch.guest_context.sepc; utrap.scause = EXC_VIRTUAL_INST_FAULT; @@ -417,6 +426,10 @@ int kvm_riscv_vcpu_virtual_insn(struct kvm_vcpu *vcpu, struct kvm_run *run, if (unlikely(INSN_IS_16BIT(insn))) { if (insn == 0) { ct = &vcpu->arch.guest_context; + + if (unlikely(is_cove_vcpu(vcpu))) + return -EPERM; + insn = kvm_riscv_vcpu_unpriv_read(vcpu, true, ct->sepc, &utrap); @@ -469,6 +482,8 @@ int kvm_riscv_vcpu_mmio_load(struct kvm_vcpu *vcpu, struct kvm_run *run, insn = htinst | INSN_16BIT_MASK; insn_len = (htinst & BIT(1)) ? INSN_LEN(insn) : 2; } else { + if (unlikely(is_cove_vcpu(vcpu))) + return -EFAULT; /* * Bit[0] == 0 implies trapped instruction value is * zero or special value. @@ -595,6 +610,8 @@ int kvm_riscv_vcpu_mmio_store(struct kvm_vcpu *vcpu, struct kvm_run *run, insn = htinst | INSN_16BIT_MASK; insn_len = (htinst & BIT(1)) ? INSN_LEN(insn) : 2; } else { + if (unlikely(is_cove_vcpu(vcpu))) + return -EFAULT; /* * Bit[0] == 0 implies trapped instruction value is * zero or special value. -- 2.25.1