From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B01C6FD18 for ; Wed, 19 Apr 2023 09:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BED268E0003; Wed, 19 Apr 2023 05:20:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B76218E0001; Wed, 19 Apr 2023 05:20:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3E378E0003; Wed, 19 Apr 2023 05:20:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 95C228E0001 for ; Wed, 19 Apr 2023 05:20:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 73CFD120243 for ; Wed, 19 Apr 2023 09:20:57 +0000 (UTC) X-FDA: 80697596154.17.0D3521C Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf24.hostedemail.com (Postfix) with ESMTP id AB6A0180011 for ; Wed, 19 Apr 2023 09:20:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=h3eMV3Es; spf=pass (imf24.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681896054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=D6j3fNAFXjpvBoTtgGD0M8hc4WjhauUm258DFePjQyw=; b=gtdampbyP0b4bfor2OKlK93yohSZrg6gAZ1VRLbPhlzfGo11aNH3hekXrv/ZFqevKWlOiw j413Zr/t8tFgnRqGCVHAU03pvGYYewWyGyIpSG/qf5UU0dgtjEwFqn4fE1JmDUUC5JMsjr 9lCNDThaxcndDwIbwV+iGF9kUcCPGyQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=h3eMV3Es; spf=pass (imf24.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681896054; a=rsa-sha256; cv=none; b=rWK+HdsxiQK+4Z8sSLQ7IqdY+ndLqCp5QZIWEF/Lr8L7Fn2zMhZmdCMFDP+q97LwvT9viN kZQI4T3YNmhuARlHNDqxHm7GTYeVnkxL0ZG2mIdRkNlatwRZyFz9jK6JaWyTUMqQ1JVZxt uWZ14l17d7e2AfOCZJmV4ODWqhhcHvg= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-63d4595d60fso5560771b3a.0 for ; Wed, 19 Apr 2023 02:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1681896053; x=1684488053; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D6j3fNAFXjpvBoTtgGD0M8hc4WjhauUm258DFePjQyw=; b=h3eMV3EsSX72f7O7hgzr0WV6+ecbdyXqfirfdt6Dq44ghMI+MWgX/qisWcnKFu9icY 9uJjgRr9AXvqs3+YsAtOHZgn9PEctz3hn8qqUDbtDi2h+6u7Fs5q7Ef82yf/0LD4QMOs g9cRGGrEjjZJpkpbkvZxMbNHfU10VvjZClYzFQamPXLqx14V87rxncBYi1zqGUj1yqQv 8Btur7MSGiP4o+vZB25aMIgcFx/6PPXw93WiWJwi3Sq+tMRewk9DhjmIzpkGIU6+ZMja pSItz/sP1WwsqPUz0vhTy2bn1E+Okus33elHUIVUFQn5NS+pdarsTA2HR6ApdrEJaIFG Y5hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681896053; x=1684488053; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D6j3fNAFXjpvBoTtgGD0M8hc4WjhauUm258DFePjQyw=; b=OGZvz3Pd1e07WSAB/rIrXW9URIifPGsWOCazXp22gat+3d2EFLXryH2ai+eJ6jZ9xG A6cVDBW3AXi0yxrLKGVfVmS55oG1wlvV2pFG72mrQ3JqVNFy+J1ILS0NG1cWSf/Irmiu CwvEwGL9NAXNxL5/OGp2wobPLP11BQlJHscWpPuGMyGDqru37EknfuvcWcE1uYYAaSFf dGiETqEN/DB7DO8LwnqpFqRV0QApGRo5uJKgfPsnXp0gf/PxOSaaRdUh2w4G4bZD4hGu rRJwLPTekIpi+lSaxjgReaw6vZaCEotnzk4elGTJROoxF59MdqGHtq6Fd/iryELEYoWy kN+A== X-Gm-Message-State: AAQBX9fJ66JAWJKdKGbCUJjnkpEvybuUKVMxTzzGx2e3IuGzITJi7Hn1 bOCS4KvuOJ0goBGhyfxqUKnvxw== X-Google-Smtp-Source: AKy350Zup6z/OvK/V81kQmeAGtxtx1sJEe/iiztZlP7XcnDtdpOL4uAZyNcACPlbOAkDeqn8h3atDA== X-Received: by 2002:a17:903:294c:b0:1a6:846f:90cb with SMTP id li12-20020a170903294c00b001a6846f90cbmr1606364plb.11.1681896053424; Wed, 19 Apr 2023 02:20:53 -0700 (PDT) Received: from ubuntu-haifeng.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id z22-20020a1709028f9600b001a52cfc73acsm10932111plo.129.2023.04.19.02.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 02:20:52 -0700 (PDT) From: Haifeng Xu To: mhocko@suse.com Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH] mm, vmpressure: remove redundant check in vmpressure() Date: Wed, 19 Apr 2023 09:20:07 +0000 Message-Id: <20230419092007.186938-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AB6A0180011 X-Rspam-User: X-Stat-Signature: r8xaa1t8ehsxm3pdgh18xdsfmh9j61fo X-HE-Tag: 1681896054-551082 X-HE-Meta: U2FsdGVkX1/Bqi0ft/VbND2+ygM/tf9JrbNpIP4F4A35zLVcB1uuv7ERcxwmH0pokG57pmarG7aNJg8L6nTOsWABsaaJlfR3P2qwj6L3fLIUV/ln9wvInBNiaxCtsAb9EpNG2P4X/Pr7Ucrj9yvnwMlez7S7Vnq1h+Y01gXgo9pl1hWqgZIS7KrJlGTSXRlkhLfu6RchlAyIZCdRXLW82YYgRN8DYz7K8Z40WBWbHAXHlgyzjYURfTMTQ31kvfAUyn9xlkZ9iFVsbJHSrN9Fr9ZlMt8TfCSuKZZX+/1r55qQhmpgj1cxaebeR3CbodN6qOpYpvJDJFzOag8GpMlc1W7EZUW9k+Ew6oB5Roj0ZrptMJmzDVDBbOUkuc6t8cwNhHGvHMpinq4IttANcKUtUGb8D/NavauVzDKcy+zCFOisere8Ve6Nh+mo6CI/ceCZzZvEwyVbLHCllDLnPu6jSxvEgxZ2+n+65vnyX281qF7jzyn0skgnl/N5++6okRctGiTUOkHhugKnrDbtY+TnhTMCeG3570U87HpMwIWsnIFX/GBvN/m+Tgh++jF4/N9ZGxEw5rjzVhYXvWBBi+x9rvp0h5FZ61V9QWo7AXthV33h914Up0tV0LUaVg0Ko3ddiQ8kfZfbU8mK7Xr71hEM9HlTiFgo8AkOtPASUoIjQ4w5675A+b0gpnWyYcoHJEDkTzLMM/GfKZyRguv4vOP7G2yzqhhbODeC2Rjlpjyv3WCnyJlQdIxJMWHMchmYvNV7Tig+5imEHU8S1X6R7Xc6HHs78PEGbo3i9KyTfJymwkjfB32hdb5fvpTd65SxqyoG1APawYWIX0/zWtqBmkhMA5Fjqt+hu94l4mt/lmgu3SxBYqIbuhXrtxhuS8s/GYxa2t5QJaGrC4pM7glGCsZr5jotVotBhR0BlgXb4rJBSy4GoV6ucZ57EPQOl0wkLhqkn3T3jMB7fxmKCMvXULr H+0whfIF oQww/914d7pCfuGHpr3aIQQjFeUO7J2TYgdsW3lKW8H88AhtZvRze49wUXK1hFc6efYGAMirDsWOg7S/24VTaqXaqsxamNtQDt+3dkdSi+0lfbEerrCLpHRNy9ZlhCIn7pIDxRc9odF+vaKzv/q40JyNjKhifzQCMMB8QdY4z3LCC9Ce0w47EmEa8CBJ0yw2IrbZilGyRpf4Tf0sag1+k83he39knwigwzNwYiKaP6KRIta7T5QvZLjsYxNLw+MKyAo+2PbV/1nRYR2ONxoE7FZDqRCJ4ZhpMPHSn3CFv30143PS2SmI/Fc+/NB+WXAI6+tYPwzjPtoLF4lAdgaN1pwWPxVBntmHw/S/bnDuEBgSQJCen6GHyFieyNGo4xmXOSTou0/PYvBj0IMsDQ2EkWeh2A+rk76zcZnYR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There are three places, vmpressure_prio(), shrink_node_memcgs() and shrink_node(), which invoke vmpressure(). But only shrink_node_memcgs() sets tree to false and the memcg used in it is not NULL, so we don't check it again in vmpressure(). Signed-off-by: Haifeng Xu --- mm/vmpressure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmpressure.c b/mm/vmpressure.c index b52644771cc4..3e4251a55e56 100644 --- a/mm/vmpressure.c +++ b/mm/vmpressure.c @@ -284,7 +284,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree, enum vmpressure_levels level; /* For now, no users for root-level efficiency */ - if (!memcg || mem_cgroup_is_root(memcg)) + if (mem_cgroup_is_root(memcg)) return; spin_lock(&vmpr->sr_lock); -- 2.25.1