From: Haifeng Xu <haifeng.xu@shopee.com>
To: mhocko@suse.com
Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev,
shakeelb@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Haifeng Xu <haifeng.xu@shopee.com>
Subject: [PATCH] mm, vmpressure: remove redundant check in vmpressure()
Date: Wed, 19 Apr 2023 09:20:07 +0000 [thread overview]
Message-ID: <20230419092007.186938-1-haifeng.xu@shopee.com> (raw)
There are three places, vmpressure_prio(), shrink_node_memcgs() and
shrink_node(), which invoke vmpressure(). But only shrink_node_memcgs()
sets tree to false and the memcg used in it is not NULL, so we don't
check it again in vmpressure().
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
mm/vmpressure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmpressure.c b/mm/vmpressure.c
index b52644771cc4..3e4251a55e56 100644
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -284,7 +284,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree,
enum vmpressure_levels level;
/* For now, no users for root-level efficiency */
- if (!memcg || mem_cgroup_is_root(memcg))
+ if (mem_cgroup_is_root(memcg))
return;
spin_lock(&vmpr->sr_lock);
--
2.25.1
next reply other threads:[~2023-04-19 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 9:20 Haifeng Xu [this message]
2023-04-19 20:03 ` Andrew Morton
2023-04-20 2:25 ` Haifeng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419092007.186938-1-haifeng.xu@shopee.com \
--to=haifeng.xu@shopee.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox