From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C85C77B73 for ; Wed, 19 Apr 2023 08:59:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A21198E0002; Wed, 19 Apr 2023 04:59:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D1228E0001; Wed, 19 Apr 2023 04:59:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0FA8E0002; Wed, 19 Apr 2023 04:59:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7A35E8E0001 for ; Wed, 19 Apr 2023 04:59:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3A0F31A0278 for ; Wed, 19 Apr 2023 08:59:12 +0000 (UTC) X-FDA: 80697541344.16.092AB48 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 8BE98100008 for ; Wed, 19 Apr 2023 08:59:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ntrcwJwe; spf=pass (imf05.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681894750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L27DU0nZtzgUVG2ufru+F/II44c96mRNXxoMg9BioMw=; b=4/pK/qJoV8TWLPKv+/Zh3jrlSirqbhc1nhlDnpI51weMv/dP/bTmZ4gZJJcNgKo03eNOV+ 1+nwI/X2o/Pyp1m/y2tepyxs7Pf7VfXcPqm0q1NT3ieccfzzKAfG3r6NN1fN2oXNfCmIvX ymphz3JgGWDTgGNfH4gDCfq72nTcD+0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ntrcwJwe; spf=pass (imf05.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681894750; a=rsa-sha256; cv=none; b=D87GJTD5MrpNcDM19O4y0b40uFOn0aO+Wx1PULXomZUJ3bUkJTVFBk3I/SUKoE2mbQ1iDu hRwfXcFDtrr9V4OgP1c51UnHqODZ0T4pbf5qSlcVXkivgMMU626stomwNPnUHo1gtlAn/r uPKTequ7j2gUAgi95Wj48S1wqmVutg8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB88963CCB; Wed, 19 Apr 2023 08:59:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90718C4339B; Wed, 19 Apr 2023 08:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681894749; bh=bPUspiHGV/cQHYqjuDQgmKqH62SgWxZuQwh73JM2jjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ntrcwJwe36MwGpjRUBHS824gYAEuQTlevH6WIBGMs6AIikoaH42bfMZvm1w+AwEfg JNGSNTSt5HVxWunytraXUte7XSaP9qSaY7a7V14M92+gtpSsZJxZaJu04HS66n/Eij ep2LxyABXlx/wNKaEusTNb3z25fV2ojZn/+WUAToLAJAHF28TRI8fGZWkTWhgtJKMc mFqHK5RSCQbxg4hASHoqPFDM46I5mAxv7+Zs9szsx7DyfNk0/adxWyDWnaduznxsBJ QY7hWUoa5hszSrCPCBJPLBM9t0PJYAewkWLSKaKQCAzJJpORWzjm67YujUB9AShnn9 laFdug2h+lQXA== Date: Wed, 19 Apr 2023 11:59:05 +0300 From: Leon Romanovsky To: Eric Dumazet Cc: David Ahern , kernel test robot , Wangyang Guo , Jakub Kicinski , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Arjan van de Ven , Thomas Gleixner , netdev@vger.kernel.org, steffen.klassert@secunet.com Subject: Re: [linux-next:master] [net] d288a162dd: canonical_address#:#[##] Message-ID: <20230419085905.GE44666@unreal> References: <202304162125.18b7bcdd-oliver.sang@intel.com> <20230418164133.GA44666@unreal> <509b08bd-d2bf-eaa8-6c49-c0860d1adbe0@kernel.org> <20230419055916.GB44666@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8BE98100008 X-Rspam-User: X-Stat-Signature: ushpfwq5fsgg5qmmxz96o67xmrgr4wsz X-HE-Tag: 1681894750-742715 X-HE-Meta: U2FsdGVkX19/OdosahysoBb2JWK/R1HEzpZaLhvmSHu8Pvh9BAHGqVrZ1bkpff9KjnZl1J+ITbOFxWgdliTRetwlLt/2mCG9hiRwGduq3AoXwIr7fpnHPrdPf6/JoXF+YYqygFNLsEDs/Gyh9nBEvy85rLcp2KCDB9UOwVlAr+aFyaqew+v9V4SDivs6ckNw6YFk2wnQFgYKZx6K1vcgiRljGdMpFfEuz5G3PpMYvfar1UCAiM86f+GxJ+5PIsD51SDhVkzmdd8tZIxMOUkITXZySmirvfyNvJLWVS9U4ncugg21jCw3QNMBpBWlL1NEtD/Msrf/ZFsagbKro0QoyipWq0otX5htriSAIFNUUI9ZUoRHd3rci3fGcMoUfjvY0dILT0FGR91U1yNjblZktcgndVXn86l7Cmzc7dCH0cSLv+S8YuotehowOZNuC7tSUCgdTH9euoRFXtQoE7CxaR+emUkVrgL+9GZ8TBXHuJnRRHN/9+WsJ3BeKzfmyLDX8MzVk5+QMBwrndot7jAKxoba093sfjJ7uKNjWZR+a6LxD3kP/q6QfMYgm3lvwOhoJjakp/Jc55NmrQKBWBIrUbyUqGaXvRHxE9yl48L8EHjC3lIu5P5hZ91VZfRHs5GGXJ5ygCUWmDA29X5atB2JKQfo2A5xE4OcIqZdAjJU2mT8P9uVg/2Y/AdzHulMlltc6TTJBKk45oXDqJnF5ECxSslYqAt/07rsDASPFk3WiGPOqqoQ7BWFiT1/2F7LgRVvAPAeTn4iksFqhpVCUEsNTxxKwD+Ang456BF2KyCDo8oinO9l+Qr7PsSotc2Dh9pf4FJL6TVHv5TYglJXyZVDvDbsDxC+HaNKLBl85/lfpL9LHViN0iy9WUVYw5g8RWe/tyXjgyjrVZxr8aoMAkNeHeAs16pYvPZUVPfl8q0j7k+PpMDu8pRV4uMlaJzGVL4N72tf8ixhXtwFXDBhV5X Gb0PGy6M 9gQF+butDDQxKqd+Z4aJF70pOlYmHivze1sc9kGNygHisoojBL9SP1EG12pGtuN2IF89C3KatsIOjVkajR42d/pRAM05TSQx1dCI37dpK8gTTCgwt91zmyFtR5YmCzjJHXjB/RuQCDTyPrO44dzdAGb0Aua4iRWessr/Ea5c9exQBpoq602hyNvl3i9llHLu+ZoJMTeZoVUTr+rg649o/0Z0Nj4zu5EPuL4fatmmk03c/UIza9tbg4RlQCIRHi1YFKxjIpO9Y3K11BhTgA0EPFUS2T+qral375upSw8pkfXTcV3AKFXU1yZOzyQ9gBcWEG3Yzt9AXCUpQmxb9mlKV7PC20hvWlEyPq0gs8WzT9vQYWORh4++te/QUD/pdR1eyrbkl/v3H6yIjM4v1Vsy/yoPgZH1UnpqbowXY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 10:41:00AM +0200, Eric Dumazet wrote: > On Wed, Apr 19, 2023 at 7:59 AM Leon Romanovsky wrote: > > > > On Tue, Apr 18, 2023 at 02:43:02PM -0600, David Ahern wrote: > > > On 4/18/23 10:41 AM, Leon Romanovsky wrote: > > > > Hi, > > > > > > > > I came to the following diff which eliminates the kernel panics, > > > > unfortunately I can explain only second hunk, but first is required > > > > too. > > > > > > > > diff --git a/net/core/dst.c b/net/core/dst.c > > > > index 3247e84045ca..750c8edfe29a 100644 > > > > --- a/net/core/dst.c > > > > +++ b/net/core/dst.c > > > > @@ -72,6 +72,8 @@ void dst_init(struct dst_entry *dst, struct dst_ops *ops, > > > > dst->flags = flags; > > > > if (!(flags & DST_NOCOUNT)) > > > > dst_entries_add(ops, 1); > > > > + > > > > + INIT_LIST_HEAD(&dst->rt_uncached); > > > > > > d288a162dd1c73507da582966f17dd226e34a0c0 moved rt_uncached from rt6_info > > > and rtable to dst_entry. Only ipv4 and ipv6 usages initialize it. Since > > > it is now in dst_entry, dst_init is the better place so it can be > > > removed from rt_dst_alloc and rt6_info_init. > > > > This is why I placed it there, but the rt_uncached list is initialized > > in xfrm6 right before first call to rt6_uncached_list_add(). > > > > 70 static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev, > > 71 const struct flowi *fl) > > 72 { > > ... > > 92 INIT_LIST_HEAD(&xdst->u.rt6.dst.rt_uncached); > > 93 rt6_uncached_list_add(&xdst->u.rt6); > > > > My silly explanation is that xfrm6_dst_destroy() can be called before xfrm6_fill_dst(). > > > > Thanks > > > > > > > Please take a look at the fix that was sent yesterday : > > https://patchwork.kernel.org/project/netdevbpf/patch/20230418165426.1869051-1-mbizon@freebox.fr/ Thanks, I replied there with my comments. > > Thanks.