From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0267C6FD18 for ; Wed, 19 Apr 2023 07:02:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655F48E0002; Wed, 19 Apr 2023 03:02:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE168E0001; Wed, 19 Apr 2023 03:02:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A5FA8E0002; Wed, 19 Apr 2023 03:02:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3718C8E0001 for ; Wed, 19 Apr 2023 03:02:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C05B51A0190 for ; Wed, 19 Apr 2023 07:02:42 +0000 (UTC) X-FDA: 80697247764.27.892715C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 14816A0014 for ; Wed, 19 Apr 2023 07:02:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qQYSTIsN; spf=pass (imf15.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681887761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TSQSyIpeUCb05OOB/zjLTMz8Z+DEjy3kyBtYIBfZS5g=; b=z0JHktjEq6tySxc36qvRrasUk0iqD4n+iiikRJUfgVwLueof5rtFsDR86r6+vrBpBSJVbc T0sAIdNtrD2zXanpI6UOj2Y+5x0Wjz3grbO0z26j0vvbJdqVZTfwKNpR/ww8/0gSpF95Be B+im2kOe/DGbspu6krLQ0xrBA+qPtKY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qQYSTIsN; spf=pass (imf15.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681887761; a=rsa-sha256; cv=none; b=QD0eaFmbwMcGCOf817f8oNTkMTiy/aC/Un+L5PQXJaHBAN/eXn9X140ea9RWD4IXZoFjR6 Bu9F3kDWulXz93XM/DACNzXRQ3wMtsuEKaK7WqeF2TT6o5sxcbMxb1Vjl3jQYvls1+Z9Iz qOJqjHkeO0nXNhajHWiRevRn3MuKpHY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E11E16381A; Wed, 19 Apr 2023 07:02:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F7C1C433EF; Wed, 19 Apr 2023 07:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681887759; bh=JP+P9Uj3W/De8PEr9B2Ujl46kJqnROKOmOOECwHUMqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qQYSTIsNCyBK2zZvz0V4+JRaiASojnL2wwCFRphudqfJ/k3neU1zqVvbR2t3rGnAk fg06OXB+88UTlBwliXxDPmOeGrzEgz9pL519m9gpMue+3M4pDZEmMXxOrfEiyvZ1u7 lYZ0lARUFBLzDa/bJt7U6QNxSvf+/23x5+jIGs25QFHekzzK35jvJmJ1DYrhHKuDLc mM03/RwTvzRhQjubV2V9wit0+ZwR/+H0D2n0yEKtjfoKbEAOBrI7I6HHIBGLcFrgun vBpJOcJ4/+UM8/OhHE6uDcmZydMnTwI7QLCUajBeO/Yuoe3dkRw7k/AidSa816A/vl y34Wi5d+NYCHQ== Date: Wed, 19 Apr 2023 10:02:34 +0300 From: Leon Romanovsky To: David Ahern Cc: kernel test robot , Wangyang Guo , Jakub Kicinski , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Arjan van de Ven , Thomas Gleixner , Eric Dumazet , netdev@vger.kernel.org, steffen.klassert@secunet.com Subject: Re: [linux-next:master] [net] d288a162dd: canonical_address#:#[##] Message-ID: <20230419070234.GC44666@unreal> References: <202304162125.18b7bcdd-oliver.sang@intel.com> <20230418164133.GA44666@unreal> <509b08bd-d2bf-eaa8-6c49-c0860d1adbe0@kernel.org> <20230419055916.GB44666@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230419055916.GB44666@unreal> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 14816A0014 X-Stat-Signature: boqkq5b3tmpptji6cdq6d7fnucafswtr X-HE-Tag: 1681887760-873573 X-HE-Meta: U2FsdGVkX18NQOfshqjyKrQGC+ZPUwY0SyR+4woz2i4NKSdfyrSHig/twTcbW7GxidlLMcODrYKGGrK8GIzHJvHmAVPYmPQK/PTVqMtgBN1u+o23lXcjSoULWxHDFxFoIGczReEDSYAGy5iKG3OTVBbTwgr0DD9INIRPbpFjOYOVwHvdusQCtTb2NVeMXDCPTFd5M1CtZoUDS4BAFCJ3xDL6mVdDLOJ/IavmIWCXHHH+UzFXSbe8Dm2b/SgPxOFmNCftnffcC/PgKOaydbICmDhQCCW44f+q+d7MbmYQlPisk9RYDYAeKd4DAJ0e2/HMu4hdJxR/A9wDH6J85RHIZj3dasmc4hBqdtL/GKuD/1ZKaOlpUPPSIr7Bp9+FwxXlbEAl/qP3y97sBkvYOC7MWyss7PDTIW0bp8F4iMH/k4cnUD+O9K/pMt5mmhP2LmODVkwPNtzuReNnE1sdrrs/cN3dCnefQ6mpgfOZe5fpbUq5ui8d0MQuze06mik0nYIcFsDIiV0wGMG2l6dkaCJaAY62ruttkk4itl+666dP8f3Br1Rqv3EPb7W2gqROVtwNmPXfUHkzjUb/Tg2krD6jYbeXz4uDGEiYyhI8E5LcS5mtKhyvZ/IXS5cWaUrx2XkI5EcrqaWdh+6DhK5hPTEr3kqJvwgWGnfCbtQvH05usJh9wWbUKrKR2dXYeCS1qwTg1ufSlETvfN1U0SXaxQUtHkGv9NfvngtkOp3kdeSDPKhiowdkfDAbnX5MZq3x4hhcmjbUvFtP8gJfBiC8hBJo7mEfQ1ulJPOQcciudQBS+BoUb6AnhubzfaVxbjSfCf9+Hq9nB5uXocE1smFnyW47Jpr1vTEImHiYZ5pskdrItzC1YtBaHWDMiSINTZztCauwK+ows2fRNLxpG/nvXd2VnkWNTWBCu4KvCXO4waCFLamW/3eFIw6N0j8aTzYWdcBvaXv8taHlfDq6h7oydB0 nM/JZ1TS xRNJ4GHnaszWUT/3nUsk4UU0kHGkwtfQUm8hl20xVHBbM0z+3QhZ2LZqZNRtEd+M3WMTlXQxiAVIcGeVgEDH2TdHNhU/wCDLs0/wGYHdyw4itCdKzA8sfS9dW9wv7c/NhbKFCi7aWzVD+oA1sYNqxnkUkPgVJA7RgwYUoOjpSd443jXTyL+3ul2zZp/IISse6a0m7Udfb2qcKww2HKGODpvToWstA/dsBDa8gGu7r/MEIf6CM/wEUeO75XTlKlfWCRDhz/i9fqMg4zfx74KHVSnjdVdL9LlPEMp1nQ2hZhSPXC6691ekzpFqutsmvfCu9dL9s/bskrFxdbx37Wa5+ejwn7GtwkCfMKfAu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 08:59:16AM +0300, Leon Romanovsky wrote: > On Tue, Apr 18, 2023 at 02:43:02PM -0600, David Ahern wrote: > > On 4/18/23 10:41 AM, Leon Romanovsky wrote: > > > Hi, > > > > > > I came to the following diff which eliminates the kernel panics, > > > unfortunately I can explain only second hunk, but first is required > > > too. > > > > > > diff --git a/net/core/dst.c b/net/core/dst.c > > > index 3247e84045ca..750c8edfe29a 100644 > > > --- a/net/core/dst.c > > > +++ b/net/core/dst.c > > > @@ -72,6 +72,8 @@ void dst_init(struct dst_entry *dst, struct dst_ops *ops, > > > dst->flags = flags; > > > if (!(flags & DST_NOCOUNT)) > > > dst_entries_add(ops, 1); > > > + > > > + INIT_LIST_HEAD(&dst->rt_uncached); > > > > d288a162dd1c73507da582966f17dd226e34a0c0 moved rt_uncached from rt6_info > > and rtable to dst_entry. Only ipv4 and ipv6 usages initialize it. Since > > it is now in dst_entry, dst_init is the better place so it can be > > removed from rt_dst_alloc and rt6_info_init. > > This is why I placed it there, but the rt_uncached list is initialized > in xfrm6 right before first call to rt6_uncached_list_add(). > > 70 static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev, > 71 const struct flowi *fl) > 72 { > ... > 92 INIT_LIST_HEAD(&xdst->u.rt6.dst.rt_uncached); > 93 rt6_uncached_list_add(&xdst->u.rt6); > > My silly explanation is that xfrm6_dst_destroy() can be called before xfrm6_fill_dst(). David, I think that I found how it is possible. 2959 static struct xfrm_dst *xfrm_create_dummy_bundle(struct net *net, 2960 struct xfrm_flo *xflo, 2961 const struct flowi *fl, 2962 int num_xfrms, 2963 u16 family) 2964 { ... 2971 xdst = xfrm_alloc_dst(net, family); 2972 if (IS_ERR(xdst)) 2973 return xdst; ... 2981 dst1 = &xdst->u.dst; ... 3005 err = xfrm_fill_dst(xdst, dev, fl); 3006 if (err) 3007 goto free_dst; 3008 3009 out: 3010 return xdst; 3011 3012 free_dst: 3013 dst_release(dst1); <-- release of dst1 which has not-initialized rt_uncached. Thanks > > Thanks > > >