From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED6FC77B73 for ; Wed, 19 Apr 2023 05:59:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81AAA8E0002; Wed, 19 Apr 2023 01:59:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CADF8E0001; Wed, 19 Apr 2023 01:59:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 692758E0002; Wed, 19 Apr 2023 01:59:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 59C608E0001 for ; Wed, 19 Apr 2023 01:59:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 26AB41A0183 for ; Wed, 19 Apr 2023 05:59:24 +0000 (UTC) X-FDA: 80697088248.06.D08C2FD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 81694120007 for ; Wed, 19 Apr 2023 05:59:22 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fuXRxOIj; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681883962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BCwDftQ9UUV+nFHGHs6mwCtEMQvdomrf8uSpNRzzxZ8=; b=Y7Vi00wjv/LzK/AV3GbYIZ8LjswNFP3G74UntZTf4jTO4cgqXkAR4SNgG3hjfZnREeDO9e Z/C6J0nHcVsHo4ReJD0U4LsD/MRPxgTh3+7VYOx6vxP/8DyuiMXAF1YwCpJD6UQJFSNOQN qwI6/C6EjwE3RgyDXWU0BrIkiPVEKjg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fuXRxOIj; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681883962; a=rsa-sha256; cv=none; b=0PEywNkdBLK+42h9xbfVerGYQVH1nqaybjaVwY2KIN6WCDdjewIVo6Hckl0D8D4iLoMn3d RozHmLXJ66hL2v6lAP2qrRHmp2MlSUrjp7un7RG3AQ+JSh4/Shs6Uz50GUTnXWGDIHKEH3 ABhrByz95aWQtrsbKPPETsNNE4q4PBk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 703E3614A2; Wed, 19 Apr 2023 05:59:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CA82C433D2; Wed, 19 Apr 2023 05:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681883960; bh=uMEP/rLMSuizQenPLrelbZAZmJG14sYh9fm/by6+dFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fuXRxOIj80rqK2A/dyzSWBRMytGf8o6ZQ3LNriU1TOAMu8iSwoVoiyVLBHq0nf9aJ dzYc0Ll6oKk06ZEQpD6A2VeR3gB8AJFi8bNjFg5UQiXxUdWdeR5vtLacIdbSdsJA/a QMmTfJJW+aKCidmgcd0ODd0T+ztpzcHiQrcRAXeMrSHzveyCau+vTcH/EXoYO3wpdw /ib+QL3+xH7GyHWXATVkUzdjG/gX7gETPzFZu6SNYcHtMvLe8AhjSlV/P1zkGrTZ90 Ukish9v2oseVsi1U6VSpaVC1hAuKz+4JVTgJfXFFA0Nj6LQpsVOOAgE8dIQm/ZcraF /r0tmQ+quF9/Q== Date: Wed, 19 Apr 2023 08:59:16 +0300 From: Leon Romanovsky To: David Ahern Cc: kernel test robot , Wangyang Guo , Jakub Kicinski , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Arjan van de Ven , Thomas Gleixner , Eric Dumazet , netdev@vger.kernel.org, steffen.klassert@secunet.com Subject: Re: [linux-next:master] [net] d288a162dd: canonical_address#:#[##] Message-ID: <20230419055916.GB44666@unreal> References: <202304162125.18b7bcdd-oliver.sang@intel.com> <20230418164133.GA44666@unreal> <509b08bd-d2bf-eaa8-6c49-c0860d1adbe0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <509b08bd-d2bf-eaa8-6c49-c0860d1adbe0@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: y6dfjnyf9qxenbn5zmfjgkg4zg5hgc87 X-Rspamd-Queue-Id: 81694120007 X-HE-Tag: 1681883962-458222 X-HE-Meta: U2FsdGVkX19ahQIMV/Uy0Ha6ujs5rZWP2HOkD4pGMfk+zkSZfSUG3+lF0SuaYzdbj7F5wJFGITLNFghgQfWre7GqUFKnscuhhaLN/L2iKhfSrdl8STvlBLt+vWjykOV301oo9Chw2KWITssrM9L5YbIyJJhyALnprHWBolXBocmxylb71jg4qPRWWPwpF0CHBjSTqhWYA1Kj6TYdAj2SpgG4MfDnUBKReoN7sVkTsWK6svbWt5ROh2p5cSIP6uK/W9Bop7F6lOcaC2ok6oPyih7eUzF3GMRbGTVJ6q6qlTrx7w2rsUDNmImnowGzDfVT5OgiUkHOGH7D/z4oKDsGRe1Q8x82+FpoBGgEvO1Y5tzfk3Zwc1GbNzIB4Z+2sBGIxMEEaChsgEJLGBqBaKsP/yoC7GzRHyM0QzvT3rmACzccGQNetYK2x+ZqhMHaJ/xUBkQRrZFaF2Vc1IbKIPMRW9L8EBws2iRa95zYVlrLkhWBVVEe5U7xJ75PnwFHU51o/DfbhC+JiTJO1O00nwDFfgA34Otu0LNdkOHe7dnsYymGxfR0A0WD0SuHKbauucIrHEs6cI8EHdqHzXN1dCphmyIHAUeBHpaaiFTnQTsqJsvOx9IsziZGy0xR4rGSmEXWskB/S+qz4m5ow1MYDu9wOdDDkT2gGK0VHktEq1goYuacZ395rR+gIaBTOVB7o+AHGOkxhemHMEGpVsdTrsihSU/2Mtwvjr9TsHvQEnajma7xZ84CSyFDkw22X21JoEBXVbCpONd6Os4P+qipSDhBUNwNMzgUYTBaExWrZhKRTho3BNfZy7owkLCbq5PvawG2RKrvdikJiBfXQ7t1HqnCt6BhP3a6tqTpUnbRR5EiXgQszk8bXDVSsmzI/BnkA2mmNnarqmDdSdM1IGx5jyFlMhdBQWAw4eElo+vUnSMtL5cmyzDfYuyS8egud3W4/eRCsv+cpBvF/E5EUG/FVbe n9jxR1iL LQGf8fGEMPXYvnw2VnP5hJgs9fsdh7NQjXYclc3bH4CRAQuJZNHHFBOhnr3KAxqTvZ/aRAc7Y+7RxhyF3yXvPoXYgLcjHCZ1Qgdha7rkkcIqdxWmf4+M0n9CZj6P3RJvT17d9NG7ed5deeEbJAthzdA75zzqV+RWsWt76slZqSsINykaKda75thy5WVIuDPxQLwodlEnaVk1bUhBoklK0yMPQcc5KLbKPG2fp9ieyd1rWquHWDgw3iy/LeDrFQhnhJfUsrVZLJoh9BdPCgwg6/my0RjJoEUPjkNeLAB48oW9WfY6DifG9xDOoxg7/meDIX6B2rTFebjl5sM/widRmNDuaJiBzSctfuCav X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 02:43:02PM -0600, David Ahern wrote: > On 4/18/23 10:41 AM, Leon Romanovsky wrote: > > Hi, > > > > I came to the following diff which eliminates the kernel panics, > > unfortunately I can explain only second hunk, but first is required > > too. > > > > diff --git a/net/core/dst.c b/net/core/dst.c > > index 3247e84045ca..750c8edfe29a 100644 > > --- a/net/core/dst.c > > +++ b/net/core/dst.c > > @@ -72,6 +72,8 @@ void dst_init(struct dst_entry *dst, struct dst_ops *ops, > > dst->flags = flags; > > if (!(flags & DST_NOCOUNT)) > > dst_entries_add(ops, 1); > > + > > + INIT_LIST_HEAD(&dst->rt_uncached); > > d288a162dd1c73507da582966f17dd226e34a0c0 moved rt_uncached from rt6_info > and rtable to dst_entry. Only ipv4 and ipv6 usages initialize it. Since > it is now in dst_entry, dst_init is the better place so it can be > removed from rt_dst_alloc and rt6_info_init. This is why I placed it there, but the rt_uncached list is initialized in xfrm6 right before first call to rt6_uncached_list_add(). 70 static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev, 71 const struct flowi *fl) 72 { ... 92 INIT_LIST_HEAD(&xdst->u.rt6.dst.rt_uncached); 93 rt6_uncached_list_add(&xdst->u.rt6); My silly explanation is that xfrm6_dst_destroy() can be called before xfrm6_fill_dst(). Thanks >