From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6833FC6FD18 for ; Tue, 18 Apr 2023 20:29:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B621B8E0003; Tue, 18 Apr 2023 16:29:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B12048E0001; Tue, 18 Apr 2023 16:29:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C218E0003; Tue, 18 Apr 2023 16:29:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8AC788E0001 for ; Tue, 18 Apr 2023 16:29:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 60A8C1203AB for ; Tue, 18 Apr 2023 20:29:55 +0000 (UTC) X-FDA: 80695653150.23.7C06D4B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf25.hostedemail.com (Postfix) with ESMTP id D22ADA000F for ; Tue, 18 Apr 2023 20:29:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=MxRKmxml; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aCSnyJov; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf25.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681849792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JI7X3ejjGQoCkbIzLvFLK7b1SJse9JxmfNbj0u8XL7w=; b=zUWFgmiuxS7VbB0J9XeILaq3Snqfao22WE7G2emPKThlwLhOQjKg53NVuO8xrwX57EtOKt UM0lILYCvnNGP7yivI8nz1HVhU1YihOEQTmsVtzLD8VxqcCTifMghyc7n1FkoSiWZ1w1FF aSxVEnoKVSUNqHOXn32DVYtUKKhwRQs= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=MxRKmxml; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aCSnyJov; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf25.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1681849792; a=rsa-sha256; cv=pass; b=HvK+k9RbiNkmeEBeVTeL4dvoP2KxL+mvKznaqhOajMILTneCeNpLj6urEbTmlVlVzXu+SA vxfTqXbZpRL6pWk9NyF+AC9L0HGR8ArPDH5bHtRF39d7f+t1jRVSoTkw+hPmkj65/sWb9d cJcMEtjXXwSwvQ6qPM0grwfWZ9klEJk= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33IExZnU013966; Tue, 18 Apr 2023 20:29:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=JI7X3ejjGQoCkbIzLvFLK7b1SJse9JxmfNbj0u8XL7w=; b=MxRKmxmlkc1TMBkV0AmWFGo5CiCf+LJDB5cBoKtGEYtmNYu/B5PpaVmnTH3lfEm04vrt FCNWXOQFSxMEWUUiI6qtQagBKvyvrVaSoGQw6/NhY0VXnB1oiDIAazPb3lzNJZCh0vyq LhPm2T/32m97s1DTJ6ZS2VueODpLxTRqb1I99zSfNjbsd0RMxEqfzQ35UyIittNH41wU XZ2fRS7rFV0YnVBWd8GGGt3KpC2s9U6puJD1xcKKlnPoV3xlLzAxzS5+HucG+tCIVp3U R6DPIoxDSYWLVGIjW4kzuKBYHK4YvEm4GPl5nNIFEMztiDwtY+GH9KSbHhszQyuk0ITt mg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pymfuepsv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Apr 2023 20:29:47 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33IIrven015637; Tue, 18 Apr 2023 20:29:45 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2108.outbound.protection.outlook.com [104.47.70.108]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pyjcc2e4s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Apr 2023 20:29:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xh8TclJ2lF24Ws3O6HNc/zC6f5OtDB2i89rSwWec0DTXdtbL+urWGHeGcPhapHwj7LqtSESeF7MqNE7412kIIuR5OhuaGiLQH9NnNNEOjxB9de5vTo/KgZBlxQZ9ZSINkCEpXaUtSO13h4+qj7uHNhcSSeHVjPeD9DTjr8V7a26r++egRBGceLTClko7HaTL078dPO2kVruXmukzcQ7Rp9gBKOmFnpetnQco5C7fYD5GeAsY8MSkygEabxoPDkeHqBo1pTB9RqacTfCZRqBg8l5/vuyqWd9erZSMvkJU9u3x0bkIr8+kOLsjB9ZmFSbN1B84BqdgtwyqLMBeiVKVAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JI7X3ejjGQoCkbIzLvFLK7b1SJse9JxmfNbj0u8XL7w=; b=Zi35hI78lg6/QttcUdZJUhVUUWE7Vk3ct2m/AATCujBeSgFPvxnSC2WvbS5BE8YLSaMWh3YfcM7/JBz9zt2/50pS9SomZmcQ/q5q55VylSTpiBb8P82M8BXzkk49ZhfwwtY1Ut+7q1LJoTeBbTdsQv1+6D7Kpd15Zi2E0xZD9hV5rNYO0mZEnWpmKBy2IupOvbF/4pUqV93FwhEHr/hpIQmBXXJzSGuJAfkPWQhdxxTP66iJyNIfCeoBv+up9MGk2JQGI8jBQxYPk2r5zhrGgGkMvkQpHsbmUKpdxBDzapq6KBCHWfw8KW/ucvUwY4OokObYFmj/KmbMNIIcyHdAXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JI7X3ejjGQoCkbIzLvFLK7b1SJse9JxmfNbj0u8XL7w=; b=aCSnyJov/V4InBllAuqkAsllmPwk0hDjZZfUkSPdzQJHamsUAwahVA6solAwY2E7KE9CKYA8PoN0+H3N61971SYNL/JhJiQMeq0S41eH8FuxVBFU24qom805nUplIMieSNQ2lCgF7y7grYtOkfGWrG9fIDzI9iyTMgmku7jU4os= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by SN7PR10MB6978.namprd10.prod.outlook.com (2603:10b6:806:34d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 20:29:39 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::ffb:de39:b76b:52eb]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::ffb:de39:b76b:52eb%3]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 20:29:39 +0000 Date: Tue, 18 Apr 2023 13:29:36 -0700 From: Mike Kravetz To: Hugh Dickins Cc: Andrew Morton , Mike Rapoport , Ard Biesheuvel , linux-ia64@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] ia64: fix an addr to taddr in huge_pte_offset() Message-ID: <20230418202936.GB4907@monkey> References: <732eae88-3beb-246-2c72-281de786740@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <732eae88-3beb-246-2c72-281de786740@google.com> X-ClientProxiedBy: MW2PR16CA0020.namprd16.prod.outlook.com (2603:10b6:907::33) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|SN7PR10MB6978:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a917ced-2e73-4e5b-6d3f-08db404ba205 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R/3Vvyf4dvtCeiId26duBwqymmotDP/y3D9sojZMjJtYRSsar2bMOs1xQ6o5UPgyEE5Iw5GpEpXZ7DzCeb4vmv4RuE2pnwlrCXp2U7oQms2npZ18iqJJVXXhqQPpuairHF29rJHeXShghTbBCswPts9CilFrkQv15y85ypTcW1l+AtMvEF25cu8Z9X/O/xpKCE8xnPSuDse42iL7HrE6kQyomGEdRxv4f828vrcBYpmhvxLHeQAH5BGm2pGrTfZfq70KLyjbrgCfe7SjuStsFYfYNmJFKLLCSCUtlWL4CLcg4gq3H13cKOwgXQ3nVbSoSn34EE3xahXBaGvXqrh2lydmIXl/7SgIzJz3QSjekaBoGA7Z0l+KXHZ16XvfAalaBt+XuzSAGcgh+YZQVmd/flzoM/nHYgXvcDnTEzligqQ9FtiECQYipwP1RTjS3dRVZcNj68jdXGtnv9IELRqjDsPEnJECVQK60Z952lhsf6lOGPdX75jDGiW8I6kyLHban0KINxphxLBGeqpONYsC2cKpAerKzCC6qH6PZyiYbb8nmN41VOhcSAQ3R2lijI8ejANWqdeKzO1Siw0YOX40IJ07JuH4ESM6vQRLAdbwmi8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199021)(9686003)(6506007)(86362001)(83380400001)(33716001)(6512007)(53546011)(1076003)(26005)(33656002)(186003)(2906002)(44832011)(5660300002)(6486002)(38100700002)(6666004)(8676002)(8936002)(66476007)(478600001)(54906003)(41300700001)(316002)(66556008)(66946007)(6916009)(4326008)(14583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cCJe1mPGOMuhVvm4qV8h8F3ehU4c3z5l6mGymq/uvk5ODPecxO2AmqLV/9qE?= =?us-ascii?Q?Qz6iJWVDeTa/DdJ4g/keBC5sSBqIfyeX2Et4q1QF/P43uUQtYLzTYt/RnaHr?= =?us-ascii?Q?oSc2BlZxiMtADezPB1DTJgU9HVQfpTgy4ooI5Z4w7gzs4AAIvvCt4DG9SeB5?= =?us-ascii?Q?EBO+ltA32js9PdqsCyPhy/tzjKM/SzrMuriKwXtYaU42adQDnzhQpYEZCtak?= =?us-ascii?Q?RSuO2XPSwgLaHfDuF+wBOvjFRXZI3mR0JysqZtwTgTW5B0jo5M/6wNXcpJyf?= =?us-ascii?Q?FYIyN4eQqyesUYsc2FVbQnot1D0+A+iqPbcXX+mxPtr5oscxsyUknduealTW?= =?us-ascii?Q?CK+yJD+KBnKk+HMfaPuXldgS10yVlJ89plobmhY++zkx/kxJnaAHMFKGY7NK?= =?us-ascii?Q?1aaCilgNUoJ8ZUWnRgmSbexKFLB1GCIHNjCZgvcNWvxTCD++5IwYbp3a0fVw?= =?us-ascii?Q?V0139dXqIehH4ghRG3HhejUUZWW2AA+lgigaJ4TWMAEjCfaKfPO3bBYkj7+G?= =?us-ascii?Q?x1YeK10cYa4fqo2zRaW1ukqjr8MrwTm8HAXqcEyYfto1EnLHxzQ+LXhazSI9?= =?us-ascii?Q?lH2dJfJOhmxIlUkH3W1pBaI5QeF+o7EosvLG0eJqCJnAyxfh8v5ee12dFc+Z?= =?us-ascii?Q?JwVEWdeOG4r5/SfvEL9S2dtaSY6npoj4NeRiZG3nx2webnqKzSYdCiNYDaC2?= =?us-ascii?Q?mXrLiN1DPOKKg+NzWv5oTDzl1KWToTmrE3WfdHYTjIcg/GfZBd6EqKWk2XRp?= =?us-ascii?Q?vSD4a4RaBVsFHpASEFBfyEeQeaAnapoFub9+4NtNMZ5bCyzQ6uJaVdZcofA8?= =?us-ascii?Q?INGQ/rYTBAufFbEE443FbKj0vfcHuygLAs3R63OsS5NWr64oT1DS/jnqwlVh?= =?us-ascii?Q?m/4tTXukcEBufPHZnUIlNbesXXYSiSVd+Np/lc7vCuVPjXGDVbpPFTupZb7w?= =?us-ascii?Q?U/9qbkklGJzAByE1zNTkn2DxdMYkrHlD9+lwAfWX8BK1z7Ah+nk0vWgCesvT?= =?us-ascii?Q?a3+WGzZvuE8rHO8GrEK+fo5SBDnJukxEMl0jsmtPTjDCzBoC+c+5WqsI96SB?= =?us-ascii?Q?h/jcQI6EO9dINeqi4UvxDKbzNgrxb7FKTcehE1pHaJsP8/xwIdwvZUNdLwmG?= =?us-ascii?Q?QOf77P2k2MWxAEgcni2vDluLuNvnvPu5Y+8hETwuQ0qN0mRUlZI6xGbdm0A4?= =?us-ascii?Q?5etN1bGo+QFRRfg8RyFxyx4Mq/odt0TKFUiRBD9zlGbweH9TrKQKS+wLa3ic?= =?us-ascii?Q?z2iLUOfkPJ63QGI4C+umUh+LemfO0SB/EArHoCFCDQ87B2Y5hm0+TWOnMKSA?= =?us-ascii?Q?f5o8hSsy68kbU2GTEr6qA7PrjJhO4yOlv6pnW//spKKDgfArimfICJwewQVE?= =?us-ascii?Q?Ik+iWKcGT5JywjQPtnYQuxLowfY3fqF8tdk9EOIPeJrldB18QkhR5SGx7poq?= =?us-ascii?Q?X6KrauI0fy4/6kbbZkGqAizQKseVGDspKBpnm34VCzAY+zlkyIy3xQcLxdLy?= =?us-ascii?Q?7vfNUX7yguheg6PLM2U23TfBYJNFiN/qsz5SWBg6TAaMS6yLAmR+Kby+O2ty?= =?us-ascii?Q?fjPNjoVJQzJWl0J74wbpY7VQD572b2imgVICqGQM7uJa3ve35Fvoy0OCjBa/?= =?us-ascii?Q?qQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?DFVbgGrlw5aQcjdFcdhABwDy7lrEbxV0spDdFSz9ZSLQbolgP8+9ACiU3Mls?= =?us-ascii?Q?WTZ8pvsmUbiJCeeMCTzflP67pmi6jsPfsuHpS0CbrJwyG++hKXm69uf+lDdr?= =?us-ascii?Q?+Qy5b/UyOWAj3sjWXG4p6QBjWXw7wbW2yhrzMppv2G9NTFxCJpXhtm3dqh3f?= =?us-ascii?Q?fXU5pbk+aH/W5gOAf2gzPY93Kid8QkXN/J+VfoCVoVNoyixzeBtkJUAkY7Oe?= =?us-ascii?Q?LOEI2K42Isvl1081AqTQViATVhIk7sWew1C7AG1YDk/8rJpctNxdFLTg1nY0?= =?us-ascii?Q?W8mjWk0akdg/WTzJeHSOOwHfIFsZjGGtkWMgYiJqGkUnW2/5+4qY+YQI3v2y?= =?us-ascii?Q?Msm4botL5KEMjGi5pojUuTDkpOILVluCyajnDrc3fXM3G0WKTRkWHvq9FJqh?= =?us-ascii?Q?G5rDkbZ2x0TvASPGKrroXbTvNiM8ovJuliSJ8Y55SqUw18eYVofQ6iXGsZby?= =?us-ascii?Q?5pIqgvv/5PfEmZ2gRj7U9cjILMiKVUMPP+yRq0BR6VyT5SdudX8S9WaJRQib?= =?us-ascii?Q?sKHMpV3F0iavNYh3EGXqSgo39+5VhlJMftC2Yai8sjDYeNdmPCo6SNQyXsRJ?= =?us-ascii?Q?d4EHS6sKh715WewIdFgQseM7eprG8lP3DKUYQVXJnJz1u2vEom9pXwyMW+ya?= =?us-ascii?Q?zUYosTBRGCDuIxExeyQ2+h3pHtDyQiozDDDVGLSSgVz9Y45ZifLK3J7K+H3T?= =?us-ascii?Q?OqTZlfRESc7QHvkZ4ypTOCbM73SI/np9oiFjb1O/ca/NtJ4BFY3cZSqbion4?= =?us-ascii?Q?Pi8xO7JbHcMnzGiqrBPv8pm3KWO4KHP7+2mgxMmcBw8w/xTfQzA/7sX4HsRJ?= =?us-ascii?Q?AIhfU/0S6m6fWuSbh3XkcSkq2V/d5jaCiDHS0DYJeZ7einfqnufxtLyxMeGO?= =?us-ascii?Q?OzvuLh3cWq+2EBf4wnmCpqB0B7EIrAJ7aIAesoNc+YECI3MKFPGCX0bXvLkL?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a917ced-2e73-4e5b-6d3f-08db404ba205 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 20:29:39.0201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tAciR3K95tGI71n1sb31Uphw4CgKeRSS3tOUogzgUJAEnoo2xb1UZjqhLB5mRgsEYwz2zi8WqT7AY17CrLOL4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6978 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-18_15,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=950 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304180169 X-Proofpoint-GUID: aLx5CdsZTw8PqFZQNtobigafy1jUlJNF X-Proofpoint-ORIG-GUID: aLx5CdsZTw8PqFZQNtobigafy1jUlJNF X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: sxq1fo4596yie9pzezoukds5sjuw67z3 X-Rspamd-Queue-Id: D22ADA000F X-HE-Tag: 1681849791-568793 X-HE-Meta: U2FsdGVkX1/dpM5cvnGtwZYoxDTewDvURpUN7s074OaX6WZH97OFg6CvKKHSKiVr2WsdqnU33Z5mPVYEiXZ35TAv5bY8qmdf7HsQARj1rtm+PIrCbdLXjEpAEcL9QW18Yi2I6XlShTgd1gA4K87KaxyEOKVRejcNqj2UAkOEePVCJAcqAKs+HAVvhq9U0WrvtIhFY0BzB4xGeH6Co2ARhsU/jFtqORuVPLiIRmO6bPD/eZXGWENYFA9LTtOu/tKHVLJR9t83Ob0yJiS9z/bRrlTwY9Z5nV/nHZebLH9CNB4D6SNmxe18AEI4JjbauROEywLsBVKjy70NLxVK3sKkaYuASiZlHN6t8ygAk8JIaG/kFfOyUii46s0fNZyf11zfQeHCoc7MAnjBTtXH08kz+FxwW5FhT+TC8nIPOW8Blwf4P8la3X5BSj1d6TcQPYDTSR5NbIZ5Cw0bsWCeOB7XhUgQaf3yP0Wg4cfkOWnGzFAHsZsUP2sszX3uFaRSg+x3NNVJgk1+H/bgI8z9PBrQ6n1AHiM7rUGEjJXFwYRUAMkuVdZhaWc9I/5RBRlMQArdiUm+k/YPafzTfCuCrp5SAbtZ2Q3vLIJpdNFkUlo6X4JIcv6IrPmJ0MkcqmaYYBUvHFYMqIiDExUvo3FUH1i9WdxP2JS6H4PGr/4TaYGs0tDYwQmDaEMdYZIs9bjuQcewQpLtWMJjwi6n+N8JJp4k7LXBPWVZgc1YX2RDBA0VmJ9XH7wVFkVRhDusNNNc3S5py7HCu817JowTgk7eId6FSa5Q67E3yllrjIkf94OfmoaUj1GZ9SglRH4OIYL4jyBdX3wnjlIvp35diVnxl1mh5yxWuCJxCilOFBBL8J9VjduYUPtVuXf6wF29iaBSrXuGi6OOgYEjJOXs2q+B6UVBtorRJ1dIwxkjQleS5vtR1cFMelkd2K3ElRiM4hiFDXh8le8PvbJxZXVACjXhLD6 ZNPIf295 3B84bUtUMXXsNlUqKq9je6WJEIwTsb07j4h5+VbBPHANz5WzBIq02t1srkyGm8m3h797v0qYEfiFRQYwKotvJsLDiSPO4X5SSK7SRUKQfjS/ctKX/at95DJxpLu0zxt4ZG+drn6uj7y7hvXK8wlXDYrPf9Yl3C6H2g1zBXvhahUukIV7PTtievjrj7jd4pwkODoNXlOEQS648LDC/WMTzGSNk1yf8D36Y9SLXj2uMm6mMUpsznB4m9Bz0ihDqN1/V44n00819MpThq2DhyeHDkuuZBYih8B9/xeDRm33K8/0hAZ1VADJ3tRev2Ej001OSU2VC3WS/bRS4i/+s7ODh8yxB+5vAoPNfZH9V4eGJcGZ2h0EGePGxfdtvS1TuC0+bM5g/XPH/eLD3ScziZip7TFMNbk8VgDfwdlpEtPtVSqyihauS9Q4ePrxPWvj5gMpOpwE3jDu/D5o9QJA7m8b+6IunmRcnBtB01ys5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04/16/23 22:17, Hugh Dickins wrote: > I know nothing of ia64 htlbpage_to_page(), but guess that the p4d > line should be using taddr rather than addr, like everywhere else. > > Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables") > Signed-off-by: Hugh Dickins --- > Just something noticed when visiting recently in the source: > thought we might fix it before ia64 is consigned to history; > I'm unable to say anything about the user-visible effects! Good eye! I know as little about ia64 as you. However, that single use of addr within the routine certainly looks wrong. Acked-by: Mike Kravetz -- Mike Kravetz > > arch/ia64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c > +++ linux/arch/ia64/mm/hugetlbpage.c > @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz) > > pgd = pgd_offset(mm, taddr); > if (pgd_present(*pgd)) { > - p4d = p4d_offset(pgd, addr); > + p4d = p4d_offset(pgd, taddr); > if (p4d_present(*p4d)) { > pud = pud_offset(p4d, taddr); > if (pud_present(*pud)) {