From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60B0C77B75 for ; Tue, 18 Apr 2023 22:02:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17AA48E0003; Tue, 18 Apr 2023 18:02:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12AFC8E0001; Tue, 18 Apr 2023 18:02:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35D08E0003; Tue, 18 Apr 2023 18:02:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE4C58E0001 for ; Tue, 18 Apr 2023 18:02:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ABAB0AC2BC for ; Tue, 18 Apr 2023 22:02:05 +0000 (UTC) X-FDA: 80695885410.13.8BEC38C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id AEDA41A0015 for ; Tue, 18 Apr 2023 22:02:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dU3s35zG; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681855323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yRR2e8B06lzCvJ5iOYoMxV3G9i7mewUP7f5jY1aaz5s=; b=8SCKXFtcJ71m1n21LzV0yqpbf1IYl4FYUJwvVDabUJPpAyRp21XBqRDR9TauzXwRc558B5 KFuBB1wCSuYJ1P1G6ZPNlJtCS28SoAKb8sHSG8vc13t6QcHO/8GY6X0GCuQtdqX2jv5wP4 gFxi4IaqG73DuDyijBmlWCpdHUmpb9A= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dU3s35zG; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681855323; a=rsa-sha256; cv=none; b=7PqAZsOeAQKgBj2Rpm06mguxbikzWEdCoOpqbW2NFQK2P+y6DqrQz1fLFoqJCsB1HbR98U JWGOFAEu56R+iHQIvQM4OYVjDF6ZbBe/87+e+9aTwuqiz7nbbjbDPzdPnWW5VGWyah3yc/ +pMMqoSYJljcgDUb2rLid2UWyQgKXQ8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC35863986; Tue, 18 Apr 2023 22:02:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C64CCC433EF; Tue, 18 Apr 2023 22:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681855322; bh=JNP1xB5GIvgJJmSbKQabnxhJhbq3MlZMoGbPthN+Vlw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dU3s35zGaGQzcQIfZFASfRNiGP2LdPGekM1pWmXlWZWgaUS9hn+0/k1HvMtL7uR1X kyh2TcXFLCX/PC+aWFRFmbDBTtbsC9VkH2l5BRRhbn5dPTAsrgzmlRn9Tjc9n+EMBk 0BDCNKFs9eKooI+KQaHxVeapVFr8SM6tVJLQrX5E= Date: Tue, 18 Apr 2023 15:02:00 -0700 From: Andrew Morton To: Marcelo Tosatti Cc: Christoph Lameter , Aaron Tomlin , Frederic Weisbecker , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org, Vlastimil Babka , Michal Hocko Subject: Re: [PATCH v7 00/13] fold per-CPU vmstats remotely Message-Id: <20230418150200.027528c155853fea8e4f58b2@linux-foundation.org> In-Reply-To: <20230320180332.102837832@redhat.com> References: <20230320180332.102837832@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AEDA41A0015 X-Stat-Signature: pnhqq1py8p9nagrnyofpj8crbugd5piu X-HE-Tag: 1681855323-790785 X-HE-Meta: U2FsdGVkX1+0w+3tEffXFlfNmq910MAWtaRTWv91T6zSOX3Tsx0ccr06IKa7jiWfJ92rB3Lt9LnsR6hX3v2x+Ka0uI/JzO0FGpA+oVndZ/0Vca3UkQwE330i5BnfubFojmDhKMsDdzCPKfc+mQR1vWfAEwfNh7F6Fj0vuLz7zUmPqmt37yH0qjSo7C+oGgyANUdPMcZrRnkkzG5X6uc5sQngy/ZN5karKnOSBXYoS3G2iPZAZwwBIob2ggErDVQ/IOts78OxyQzgc6MXaSsh096smV7Cb4Gm0I8rqFovlySzVbvNQv5yYa8QOktWKRepgH3WJ7P3drtgsVfmNpZJJgab5IigJd+S6JsSI0Y8ybf5qI0WJYK5N8qFzSwrmluSaLKCOQxyzvs4DJcNRcngAT0E0O9LUnHpdlpL998HVm9Y5FBIpULgDVh0hGF+OhRHFKEwtNFwdmDnC/xzzw1ai/qWsstUBiBjSH0eu5PxvWjJT7lDGUOBu7MLOpwZH3oHdperZL++ug7+VmiEq/BTvn3Ts1w+x+6mKQyJEdA2qxHzhoMaXMlGkZ4SEOelRFKJVWAtiWAEiFCTLFwnj6mKAKschWeD/zzuvTzrBEkenRELngUqyiGs00X30roi0G8iq/4FvjlLF7xW7yn+Aykj2S5zN9mjsFj/ag6ESfdY7gunnm00X3Dx9p9zYDb++P+3tbLwvhAOswcchWhMboHK5aUDwEBNCGOppJlnx4QuehelG8RkDEc5xL2eu5ublpjbKeea+9xe4HsPCzBga1QfrnmHJOkeyCVH6Vr9hVEWwZw8J5jGop7dBBgCFEkF4VaJGkp54wROHOCWBMbHCh6AbOyyy85Zm1HTygpZ1EXix5JAvVzPCWdlcrXhSJp27ZJ2hw3TpNajcFzY+ego2Ja2Tm5xQbYRPqvaIF/ui3VjpBw9hlyZOYH3LRXVK+H4CXhaiJN5FhbLJE0IK2keiWF wGcv0oNH sQ5kv6yCHxaRGQFcFY8X9z9z7dt8So55xw1H7ocrmK7q9Ha9c7uxWNmPKNsGsnt8rnmd/VZ3PVlheyo3DF7jkB8Y2nvbgTRiFZ9BHWrVPfxMPK/nbETnu6SWowh9Ggy0FsOZ9/h0LZFhhhmumEnn9kAlnRr000Oz0SSMymQo6ywXp/08tdt6rlHR71FobSw4SqIB3LxKc1AvkFJHA5MamRuMpS2pZ0WZpjgNUWE/gIUMk6hCAcx/7STd3fqt9NBg7VM/jP2pFsg3wjQjXPxES01RUPc7PQKk7bsr9yKD1E9A+XPbowy1b0UVTuCEERn4mOFc8x23x6TqfCcDG9Jg4bnNpQdtHFbwMd2Ila+0gEhdRs860C8l8yDgJCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Mar 2023 15:03:32 -0300 Marcelo Tosatti wrote: > This patch series addresses the following two problems: > > 1. A customer provided evidence indicating that a process > was stalled in direct reclaim: > > ... > > 2. With a task that busy loops on a given CPU, > the kworker interruption to execute vmstat_update > is undesired and may exceed latency thresholds > for certain applications. > I don't think I'll be sending this upstream in the next merge window. Because it isn't clear that the added complexity in vmstat handling is justified. - Michal's request for more clarity on the end-user requirements seems reasonable. - You have indicated that additional changelog material is forthcoming. - The alternative idea of adding a syscall which tells the kernel "I'm about to go realtime, so please clear away all the pending crap which might later interrupt me" sounds pretty good. Partly because there are surely other places where we can use this. Partly because it moves all the crap-clearing into special crap-clearing code paths while adding less burden to the commonly-executed code. And I don't think this alternative has been fully investigated and discussed.