From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 587BDC77B75 for ; Tue, 18 Apr 2023 21:28:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4713900003; Tue, 18 Apr 2023 17:28:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF7088E0001; Tue, 18 Apr 2023 17:28:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE58F900003; Tue, 18 Apr 2023 17:28:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B23BF8E0001 for ; Tue, 18 Apr 2023 17:28:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 88E67A023B for ; Tue, 18 Apr 2023 21:28:47 +0000 (UTC) X-FDA: 80695801494.04.B7B3096 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id D125C40011 for ; Tue, 18 Apr 2023 21:28:45 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TDvWQVGe; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681853325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bd0v93pTMpJnE+XmfBtuffRsA9igPcz4qeTPqwb8CFk=; b=GLveGr3chL+9NqV5M3xxCfma8R9WG5j8Pr6dJ3o5Cn9xFKsPaRRm6eESws23oXdeVzyxOH qvrNr2eSehu2X3YpQD2F2JwssCy+O7C/gNbhoNLbdWCUeYUP1V3k3qjV7xiMXBc2Zi8aso wSBmfB/6RkwcFAc0lsXhX0Tw6b90ypU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TDvWQVGe; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681853325; a=rsa-sha256; cv=none; b=3D2PjXr3a+yPXsHQaOw0ALdLNcSP1vcagJ8g3oFj3lnClTyrszKqSF5tr+GIJBE+wIpQz7 yg76ld06qBLwyAdY8AM1o3o4NSsX2UQGRCVRjQ1fn5I5OEQIB2tducZeBSapCjAdcArWyb F1xvcJ+d1F22BGiQMhGLs6LLQBJmw64= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0198A6395E; Tue, 18 Apr 2023 21:28:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 234BDC433EF; Tue, 18 Apr 2023 21:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681853324; bh=2SNZxN9hzt7Hcn612PhEVKLrSU4yAg5SPreBYxtfaP8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TDvWQVGeqhj3/mWi/MRa3z2d2YtdyfUdrfzN4bDApR8Tccgr04pUJspvHZgMWe2sH KAVTt5BWR0pdykBB6joWO8tyUNmSIdqamNfJ5Hu2MwsWjSat5dIAPM4t4AitEminqe RzukRKpSuFilmu6UtJ5QUqZB4vOQeLzDzp70LC/8= Date: Tue, 18 Apr 2023 14:28:43 -0700 From: Andrew Morton To: Ivan Orlov Cc: Zach O'Keefe , Yang Shi , himadrispandya@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, syzbot+9578faa5475acb35fa50@syzkaller.appspotmail.com, Mike Kravetz , "Kirill A. Shutemov" , Matthew Wilcox Subject: Re: [PATCH v2] mm: khugepaged: Fix kernel BUG in hpage_collapse_scan_file Message-Id: <20230418142843.4ef62be30f529458344fa0e0@linux-foundation.org> In-Reply-To: <5dc97e10-8c64-4818-2642-dd8edb21c016@gmail.com> References: <20230330155305.423051-1-ivan.orlov0322@gmail.com> <20230331013301.ecgkjymaf3ws6rfb@google.com> <20230416113335.caeafda1328fdd4bfe2406e8@linux-foundation.org> <5dc97e10-8c64-4818-2642-dd8edb21c016@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D125C40011 X-Rspam-User: X-Stat-Signature: xetcsgyx1cbptu55ibtzi8yk8hiq1t1q X-HE-Tag: 1681853325-222450 X-HE-Meta: U2FsdGVkX18upLfOMH+rSzGMQLV4ZA5Q9Zc3uBGmUSRMzUIzNZfte8v3RDp6KTl+MiiyKMFfmP81H3SDjtvHluKqA/cJjEIdTziGKv8lQBRocU8SmqgsmsN7da7QSGgvTFwroN/pr3J3moVK/qZhjjNl6tiiUGS6mUSmtLnxpGaeb8sA5fWPAK+S9/7KJAxXrQhGA9/9htkokK0Vxa1UV8TMicMxUZrQuQgPLrmEIbV9LJzz/xRWig+Jnsu9NS4bOJb6nBpnfCQQ8XN1jCgD8POm5TYGGMUaUD1sMaJ+cRVzSKL/pUIUiaWltAHYnMTWnIc/wP4np/EmF7je+04RYBJV7aaHIVoT4rfpBWKUk3TFzyW4krtBa2NWJklON8ITyOoaprVYb7a7YDHj2h74ZXVJf5rDeyla+D+rKi6Tuw81ZuT0rfZ4E8tUfTNFseAO3/H8w3t7+JOuCQjlV84uGFdqTN1795U8LV3xA8bVpRgEVExQwSEdKIXK75RqE/NEVaohScru2i/L0QFSEsfCDa/s3u9NQVzGrRJ0RYOiSBLI1yHiGTs+xgwXDVcquWvroArg2hm6Ekt1KKzTS8PF98FYpqHf8YTupIznK2dosSGHcFMglk5jm9eQr+jvDRrG1/xlBrS0aWn3VVs9xWvSkJBQnFCqB2U/Jyt36T0/6LGd/lfG78n2Vc++zLd1t0K3diavGYYqZYypjU4Mcqw/YC0RJfKgW/L7t71uubqj9me3KuK1M07gyY5lKeFiYmSKsjfckissnb36lqFw2zUIUJEZX9Spt6znIcQuUskfQhgQplsM1z+JMn0NkHTv4aEyup7dZrils8yJaG9Oq+4wZgLCSXGF5sIESC6W/HciUZOyDQCFCPX71JAaA09U2d0JUvZ0qnndfGkDQNNa1qUtzYd9yNEKIeE0d8DdJI08v/SOHL0GdnFMai42NW7SSMvYqVhYmzxB5+nnoLAf8J7 4ado2H+O r6rc6i/e0mTV2lir4jcGXFH6Tz4SESrZYCKEUx1r9TERUGWsNAkazl3829BDnn0r9zsgw2uO58x2NoMuqoIdvbhXFt7crfbe0eTc3hbWVlC3lM2J61N8trqaM9ZZuY3i+jAuObTEa1O182p9AlDePSKD1voMok89tkVjUbjhIeqlZIdEbJXUTl8ijoy+LfGz7Nx3Q8M7ungfq0QYCE8nPZAm6IsL/pMZvr8iKEfI1lZsD/ZdEQnLkHiBs6nalJ9Lh/75S72YNwyrPMbhbPKgrh7wfxoqZaIXeEliXVNPOs+I8Xl8yx8M0u5+mrYe8xogq7liDvtegYXMSKcsUPp191e+L0fhjEhXeLrtgnFHg8KDcMdOmII9RhieV4E1UvLcCwUGLj0PHX2+FSlC5k1w9ouLrDm2ZszWfbSDCkQnzwb2iuDVDNJonJXxB0LFFxvLTBFnh2jHENbU57NdmQ+dimHMJMwHoKZM6FnrjthhzMUMJQdFX39Efa2CGi2riwaFjKPldqC61aE0zRew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Apr 2023 22:28:51 +0400 Ivan Orlov wrote: > Tested today on the latest rc7, the bug still exists. OK, thanks. I'll send this patch upstream during the next merge window. If you, Zach or someone else decides to remove SCAN_STORE_FAILED and perhaps those WARN_ON_ONCE()es then we can address these things later.