From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E03C77B75 for ; Tue, 18 Apr 2023 21:18:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 695468E0002; Tue, 18 Apr 2023 17:18:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 645B28E0001; Tue, 18 Apr 2023 17:18:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50CF18E0002; Tue, 18 Apr 2023 17:18:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 411AD8E0001 for ; Tue, 18 Apr 2023 17:18:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07BBCABECB for ; Tue, 18 Apr 2023 21:18:57 +0000 (UTC) X-FDA: 80695776714.10.69EED02 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 094742001B for ; Tue, 18 Apr 2023 21:18:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZJrxSsXn; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681852735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nYIf8vY/HYZLlCUVI1RLk590C9jXoIf+4Okxbld77y0=; b=T5KcIQs36eLdfLBzlTJSWJsA6/Rbh1X2YjUjsDP0S3geLXOF6QShxHK63u38PLLOoUMjOV VCwLIWsM4G/Dun2kGvUElITQ3iQLotD/xHcNaDhQ07N8VawvhT4tlAw05SHaZ0tHBmDF2y Gua+lKVyN38Y/Hc6fR6pxczJF+u+rlU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZJrxSsXn; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681852735; a=rsa-sha256; cv=none; b=HzIyPxr1srjKrkLE7oAVSgkovxtMWY6pu/AdJavYdwH5Rn8QZqOak5Ai8OgdBbFwTvGwiW mjdoQWMsaVzDW6x1xEAvWg1PDqK9AOKlAf4YOWbQGMsmA7vjZyo3n1E2ksY2pGaMImYAZL pgoB4+wP+mpsBt+1fyd9UPUkt6dlyBo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 00738612AE; Tue, 18 Apr 2023 21:18:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 386F0C433D2; Tue, 18 Apr 2023 21:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681852733; bh=ZHLorItxEGVfcY4Q/q4ok59ZeKbJLntqIuzGqWM4Oz8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZJrxSsXnTHQnjbHNk2yl/WgKDDGRDFLxcfVRgtiByjNC7xDO1v8qYMnVfOxxpJRP3 wuodcAfVx0XI2XLHxp1xTZC98IQfMW0lLEy/j3GmEHQ3nuM7TuUidWfAeQCVu27G0p H7h/mRHFd4XMxzmSjglYoxgDpXj6J0li/x7ECAHk= Date: Tue, 18 Apr 2023 14:18:52 -0700 From: Andrew Morton To: Waiman Long Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joe Mario , Barry Marson , Rafael Aquini Subject: Re: [PATCH] mm/mmap: Map MAP_STACK to VM_STACK Message-Id: <20230418141852.75e551e57e97f4b522957c5c@linux-foundation.org> In-Reply-To: <20230418210230.3495922-1-longman@redhat.com> References: <20230418210230.3495922-1-longman@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 094742001B X-Stat-Signature: uzqsyq9swc3c7f7s7coba3qz8eiwgqtk X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681852734-208955 X-HE-Meta: U2FsdGVkX18X9P6Ae2+cL4je4r27y3pvq4rZfkwPL5ygsDCm3DpN/enPeGqeuvN5Jj/b4FJIj6H09bmdnJI70Jio3oVOhvgKfJuJdd0i6vNqjzUXmy11qHHvbwXqA3dOPAC7kqdjGwzsC41VV6nlJpr0WXWu7q69PICYtC6ETMASU2LTPe8Z8ReVUwKT4OTrXUFSpaFD4NO9Knc3uh9zfOd75diTI1qTApZ5xCXKdZNYkOEiDLbLubQERNIV5p1dFKvHb5HbYJfxGsp5f4piXSNXCjQYh4vRKCg6x4IbIc9yu+mHs3N3dgUuyUROslFS11knZEQ+l1bCCBz3EXtWW60JTvs6ZWlzirXIF8vgdzavgB6vGvF/1a/cXl5zz5qMI3q+DglYecMEnyDSUl1UoqH6Hwz4oXqMXkM0y1uz5r7WnLdbad+kEV4Ax4R6EntKIc+3FMSrh4f0GX9rZGFKrBqKSFhbM67/K3pjpXxCPc6Q0I5OyYK0WhiVSOn0JhJ6NS4hHSG6TdY05GRRwgf4KwMCcPT1jU9gqstnn8eo4krMtqheix6W1HLKRczJrqaGjqsYGxIJWmoEMxj0tD4o4T4eib1C87rwfgaiSHiiQljxSP1WMkTFS7hcbMX0PF6LpIzgqt0mLAbXcXmL+5wwVgH1Ch8s4Y9MM+D8WUErxd4zzv+xnGdyeSKqnRuOZbCB3Pfy9O3pQ7NKwGx25tVfDPHdclGe/MbskGBCq8/gAMEnDY8e2bl4/cjZaWIXa8+ILeMa0ySvzuy+FPJFqsq5z3oBxe0E48kDfia/5o25mHLiWnkgxkagGiXkV5d0df61sS/htkB6PGs/+SqoHnHmJYnQKXsTUFJ6ZK/RTPyfN4UgJF5XjHXZOD+W295lMnMKptLOvRKdjlbXjtfaOiUVcPqEFu7tV2prkG2WECdYkGyxeKqSjeeCU5kw1SlEfcpsWS4mHip1Ki0FPu6KWs9 KL/e+Iq8 ZRPPETRcABq46phQjTB/Yaen3HaUvF1+YeIzNqXRw/R2rJwdlEESdOOMGs8DoJScvRwP1V6OJOq+7bSC/TMWjy13GHLXaL+vVWcC7cOLhX5DJKucAIcvqps/CDrs+pEoeI1wXrBph7yAtUMexDt4ek305LCzRzBT2GvOnbxX0ZryX8DbA9xr43E9q0NyNEKg9DRI5fdLP8ZwyAfvF5+4U2VhyI+8K4Jb/kLbdXnFl0fQ1YkZC2OG5PnjS6iTfbY/Y0mavxUTGVA0nOulT7qNDFNszOw+JvI/XbDdAE0747gTKYn4buqlhX8GErmKUBfBSO86r8caz22wN8tJWrpgNfBxjkG4ZedAJ2KbVzTqdyJjt73RtnrTtQ6ue5A04u7wZKX28NPu/aYs8FVLtWOfsxBxwy3sFw/UCnV6F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Apr 2023 17:02:30 -0400 Waiman Long wrote: > One of the flags of mmap(2) is MAP_STACK to request a memory segment > suitable for a process or thread stack. The kernel currently ignores > this flags. Glibc uses MAP_STACK when mmapping a thread stack. However, > selinux has an execstack check in selinux_file_mprotect() which disallows > a stack VMA to be made executable. > > Since MAP_STACK is a noop, it is possible for a stack VMA to be merged > with an adjacent anonymous VMA. With that merging, using mprotect(2) > to change a part of the merged anonymous VMA to make it executable may > fail. This can lead to sporadic failure of applications that need to > make those changes. "Sporadic failure of applications" sounds quite serious. Can you provide more details? Did you consider a -stable backport? I'm unable to judge, because the description of the userspace effects is so thin, > One possible fix is to make sure that a stack VMA will not be merged > with a non-stack anonymous VMA. That requires a vm flag that can be > used to distinguish a stack VMA from a regular anonymous VMA. One > can add a new dummy vm flag for that purpose. However, there is only > 1 bit left in the lower 32 bits of vm_flags. Another alternative is > to use an existing vm flag. VM_STACK (= VM_GROWSDOWN for most arches) > can certainly be used for this purpose. The downside is that it is a > slight change in existing behavior. > > Making a stack VMA growable by default certainly fits the need of a > process or thread stack. This patch now maps MAP_STACK to VM_STACK to > prevent unwanted merging with adjacent non-stack VMAs and make the VMA > more suitable for being used as a stack. > > ... > > --- a/include/linux/mman.h > +++ b/include/linux/mman.h > @@ -152,6 +152,7 @@ calc_vm_flag_bits(unsigned long flags) > return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | > _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | > _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | > + _calc_vm_trans(flags, MAP_STACK, VM_STACK ) | > arch_calc_vm_flag_bits(flags); > } The mmap(2) manpage says This flag is currently a no-op on Linux. However, by employing this flag, applications can ensure that they transparently ob- tain support if the flag is implemented in the future. Thus, it is used in the glibc threading implementation to allow for the fact that some architectures may (later) require special treat- ment for stack allocations. A further reason to employ this flag is portability: MAP_STACK exists (and has an effect) on some other systems (e.g., some of the BSDs). so please propose an update for this?