[linux-next:master 12115/12616] mm/page_alloc.c:6244:9: error: too many arguments to function 'cpu_vm_stats_fold'

[linux-next:master 12115/12616] mm/page_alloc.c:6244:9: error: too many arguments to function 'cpu_vm_stats_fold'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   4aa1da8d99724f6c0b762b58a71cee7c5e2e109b
commit: 938b4fea29fd04e2e7dc7fbb15bacedeafaa765d [12115/12616] vmstat: add pcp remote node draining via cpu_vm_stats_fold
config: i386-randconfig-a016-20211118 (https://download.01.org/0day-ci/archive/20230419/202304190402.keC5huSY-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=938b4fea29fd04e2e7dc7fbb15bacedeafaa765d
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 938b4fea29fd04e2e7dc7fbb15bacedeafaa765d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304190402.keC5huSY-lkp@intel.com/

Note: the linux-next/master HEAD 4aa1da8d99724f6c0b762b58a71cee7c5e2e109b builds fine.
      It may have been fixed somewhere.

All errors (new ones prefixed by >>):

   mm/page_alloc.c: In function 'page_alloc_cpu_dead':
>> mm/page_alloc.c:6244:9: error: too many arguments to function 'cpu_vm_stats_fold'
    6244 |         cpu_vm_stats_fold(cpu, false);
         |         ^~~~~~~~~~~~~~~~~
   In file included from include/linux/mm.h:2116,
                    from mm/page_alloc.c:19:
   include/linux/vmstat.h:411:20: note: declared here
     411 | static inline void cpu_vm_stats_fold(int cpu) { }
         |                    ^~~~~~~~~~~~~~~~~


vim +/cpu_vm_stats_fold +6244 mm/page_alloc.c

  6223	
  6224	static int page_alloc_cpu_dead(unsigned int cpu)
  6225	{
  6226		struct zone *zone;
  6227	
  6228		lru_add_drain_cpu(cpu);
  6229		mlock_drain_remote(cpu);
  6230		drain_pages(cpu);
  6231	
  6232		/*
  6233		 * Spill the event counters of the dead processor
  6234		 * into the current processors event counters.
  6235		 * This artificially elevates the count of the current
  6236		 * processor.
  6237		 */
  6238		vm_events_fold_cpu(cpu);
  6239	
  6240		/*
  6241		 * Zero the differential counters of the dead processor
  6242		 * so that the vm statistics are consistent.
  6243		 */
> 6244		cpu_vm_stats_fold(cpu, false);
  6245	
  6246		for_each_populated_zone(zone)
  6247			zone_pcp_update(zone, 0);
  6248	
  6249		return 0;
  6250	}
  6251	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [linux-next:master 12115/12616] mm/page_alloc.c:6244:9: error: too many arguments to function 'cpu_vm_stats_fold'

[Andrew Morton]

On Wed, 19 Apr 2023 04:55:24 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   4aa1da8d99724f6c0b762b58a71cee7c5e2e109b
> commit: 938b4fea29fd04e2e7dc7fbb15bacedeafaa765d [12115/12616] vmstat: add pcp remote node draining via cpu_vm_stats_fold
> config: i386-randconfig-a016-20211118 (https://download.01.org/0day-ci/archive/20230419/202304190402.keC5huSY-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=938b4fea29fd04e2e7dc7fbb15bacedeafaa765d
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 938b4fea29fd04e2e7dc7fbb15bacedeafaa765d
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 olddefconfig
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304190402.keC5huSY-lkp@intel.com/
> 
> Note: the linux-next/master HEAD 4aa1da8d99724f6c0b762b58a71cee7c5e2e109b builds fine.
>       It may have been fixed somewhere.

Indeed, it's fixed in the very next patch,
"vmstat-add-pcp-remote-node-draining-via-cpu_vm_stats_fold-fix".