From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1540C77B72 for ; Tue, 18 Apr 2023 03:05:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE5426B0071; Mon, 17 Apr 2023 23:05:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6E836B0072; Mon, 17 Apr 2023 23:05:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0F188E0001; Mon, 17 Apr 2023 23:05:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BEE3C6B0071 for ; Mon, 17 Apr 2023 23:05:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8E6E2A0562 for ; Tue, 18 Apr 2023 03:05:51 +0000 (UTC) X-FDA: 80693022102.26.CF33989 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf23.hostedemail.com (Postfix) with ESMTP id B4C05140011 for ; Tue, 18 Apr 2023 03:05:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=eBXlVh5p; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681787149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kOJuZ4mIPzt5F0DJllOV4ZkHX5DeqvTCiU6JGDixwwQ=; b=WarFHHC0iWixWBzMqVHB+Jm52xrEM+lIWNNm2DlCMI4K2mhDk7X2c+lMe/lW8M2vbVpt+q 8td/1HDpaoE8OxI6frGHUVKJEW/fADU2bUqYog9FyRDHHgEltN0hUut6pjd1YwtXqn1wVo wzfcBxjKNct6LusR8pfqrWL9XMElaLg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=eBXlVh5p; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681787149; a=rsa-sha256; cv=none; b=WGTp49UmWDjrutkLGPl8u3m5KBenAJWRhY70N2X9qskTVqlgSywkU/shF0J4oRc2CrGHts hupCoDhe2xDcigTmZf08ILmD7Dt2dGp48hyV8wot09D9BVQhuPBMNbrZ5DomVhDYPmHC19 kPK9+24L76FtWkNkJEWPARTPrrAXxqc= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1a6674bcad4so12098955ad.1 for ; Mon, 17 Apr 2023 20:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681787148; x=1684379148; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kOJuZ4mIPzt5F0DJllOV4ZkHX5DeqvTCiU6JGDixwwQ=; b=eBXlVh5peYX73LusmM4JjASgjEcrYjgy5dKc/k9GHFgBzHwO9ZJjAQqpwb9iWc0igu YhUY3ZArQAGcg8vjPGKt/NR1ZpSbb0/RndHZFwDGEz4GiPa7e/5jjUZxZyOhAqFRk+xs kqinRj4JAQ2UsZuy1rEXL8Q5gNrTZlH1AIjZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681787148; x=1684379148; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kOJuZ4mIPzt5F0DJllOV4ZkHX5DeqvTCiU6JGDixwwQ=; b=URVN4fbXYilUEhIfhpbYFfdc0KRRzh4wv2eE6MfbVCp+30M1CyuHu5eN99Tz7hLLmR 9n2hYgWaGOPbevkeQkMAliliHs+zvpHwq2zOUJOWT2M6PesL/Qum5Q7Aw1y87TdobaVF asVor+bz1navpGgPWKDrNxyl/R2E4SETTHssRC5tnFn6hxVrtxmlu9g0KqCe9GbgTPo1 YjlSZ74PuhTeymEBmoFwNK1wlFMOPeyGNB6RIhmgr7EoUuxn64pcW5CVrO/TOpuI63Fo 05aeIItSqrHlwNDP6eW9SbeV4R9z9oT/95tA96K0TatmVJLtpiTR9Zo420o3S+QJg6p7 Sk9g== X-Gm-Message-State: AAQBX9eU6ezLa+IhKWQG86o0uh8qnRPesEP+voDdncg6kuJU33kTvTj6 tlBoEbhEgjVbTHfwVXMhMgBuzQ== X-Google-Smtp-Source: AKy350bHk3PY5dWCECEECusc5D+Fv4G9g4VDR/o4nC6ceUaXcOblYSMAODNymspLQvMLfoS2fwoXZQ== X-Received: by 2002:a17:903:11c4:b0:1a5:180d:c317 with SMTP id q4-20020a17090311c400b001a5180dc317mr762782plh.43.1681787148317; Mon, 17 Apr 2023 20:05:48 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id e4-20020a170902744400b001a681fb3e77sm8383003plt.44.2023.04.17.20.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 20:05:48 -0700 (PDT) Date: Tue, 18 Apr 2023 12:05:44 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , Minchan Kim , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2] zsmalloc: allow only one active pool compaction context Message-ID: <20230418030544.GS25053@google.com> References: <20230417135420.1836741-1-senozhatsky@chromium.org> <20230417174131.44de959204814209ef73e53e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417174131.44de959204814209ef73e53e@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B4C05140011 X-Stat-Signature: f6d1doywz6rb463cnscga3kex6z69hto X-HE-Tag: 1681787149-739907 X-HE-Meta: U2FsdGVkX18WxgRrpGewjMJ68hGm0V0ieQaiOIN3zTUHf4eAiuQgzlU3CpPD5AaAxVhPgKbtd8J83tbWrHZMy49AXknyvnDhyh0odxNifuoOUgC3kKPVLEXkloFRn3xqtyCnSDHYhz6eFXeGc/7zuvLmXlodY9dFZlM1MxdktXfmNah3/h46Zt3OK0SHs5Oz/dN/ksIx8wBZZqLpNVJZ2JHdUH/WuhL+gI0Tfr1Ztuk3r5bv4KXo1XaO460pIV0zUY+5cV/P6cE529F7MirVaIWATnoUVqHmveq/1Nmdz+w+wkTg+SR9c/eEFliNONM297bH0eO9XavtwPP4Vh6WaTCbWnhQgoUblwt0Iva59NnXk8HojjLLqTAawhxEbBrn1o9ZgPEMIN9esw97kPtrtPSi+SJA2bF50ZVCntlhO7+vsJXuElIE5AbgZdRILAxFSTCbADIZeNp5sfINcRxmwcJII7OyR2QZGDG+om0mSydWJ1A1r0noj9RmrzQOhfFZP7UA6WsYmysn2YaZ5pOpECrbxa80062YTMJQVtoZTMYzxG49jUu8xwlvAmpQuNxmX0AtGG54GvEGyZqTJwi06XDAAZRPrny3vYjJDlROJqWD3lNYRgsYxiHlVrA45DolwsQVATgD2UIntADylc/9ehGKd5wbLDGf6tEtNGP6Qf2ClG0t2VErXIEkMEBCyS8TVLlD6htIeA4VX+8EEPBP02GFxYnyMEmKqsN9s37s34UKVkvCgF6R6zazSTO02T7aYuoReUSTcWNV+6lX0rvx7I4SmbpnsHpwHnGa63SngNggXQyLA/w4f9FqbOfK0PNVQ+cyzupOvK/fMe5Ym+PoNCw/UB8GuBjBbSeNtKlLYVNi7SjmGgYErHnxCydcMNIBP1H5CfLpEqPsCcE7myNK3nIBpvkdbPzx2cLDyvp5hojRJh/EKoMRkpaMHN8CVJ9Kya8LMBL2eDwxHs79VkP cRPSy+oi WtJYIfeciiARdLkbTPYA38q+mA0Q7XmNpA0lT6FC2mksfgLgJS+3Jc9NA61jAuox2DyoEjqPgJLNIi2EFXnYNSviDkc+v95mMStLi2JtVHMs0mkZc4XUJnHiBbgJRu1rRdyWCPuDulaK+YRmyeiTeFmifi1cME763UYOnSnXczOdVg+Qf1FGX45WwN2tOQgIRSSFjufv5ZDgWCmKRUMYf4geJQ1GY46PPV7inqZsmaFLdYqOyNOf5jJq3SELQECmeSJ9Vs8U+D7Z64W/DcSeQcuEDlBhfN92mmyQN/cjKW3qA3PGQTnaVcSIDyz0ey5rxoJW4nVyajrb+f3mqhH4tRlY5rmMhfXfTGB6lOJmIaLiLVM946lJzUm5jrA7laib5v3Hg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/17 17:41), Andrew Morton wrote: > On Mon, 17 Apr 2023 22:54:20 +0900 Sergey Senozhatsky wrote: > > Introduce pool compaction mutex and permit only one compaction > > context at a time. This reduces overall pool->lock contention. > > That isn't what the patch does! Perhaps an earlier version used a mutex? Oh, yes. [..] > > @@ -2274,6 +2275,9 @@ unsigned long zs_compact(struct zs_pool *pool) > > struct size_class *class; > > unsigned long pages_freed = 0; > > > > + if (atomic_xchg(&pool->compaction_in_progress, 1)) > > + return 0; > > + > > A code comment might be appropriate here. OK. > Is the spin_is_contended() test in __zs_compact() still relevant? I'd say yes, pool->lock is "big pool lock", we use it for everything: zs_map_object() when we read objects, zs_malloc() when we allocate objects, zs_free() when we free objects, etc. > And.... single-threading the operation seems a pretty sad way of > addressing a contention issue. zs_compact() is fairly computationally > expensive - surely a large machine would like to be able to > concurrently run many instances of zs_compact()? Compaction is effective only when zspool suffers from internal fragmentation. Concurrent compaction threads iterate size classes in the same order and are likely to compete for pool->lock to just find out that previous pool->lock owner has compacted the class already and there isn't much left to do. As of concurrent compaction on big machines, the thing is - concurrent compaction doesn't really happen. We always have just one thread compacting size classes under pool->lock, the remaining compaction threads just spin on pool->lock. I believe it used to be slightly different in the past when we had per size-class lock instead of "global" pool->lock. Commit c0547d0b6a4b ("zsmalloc: consolidate zs_pool's migrate_lock and size_class's locks") has basically made compaction single-threaded.