From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A247C77B7C for ; Tue, 18 Apr 2023 06:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7430900002; Tue, 18 Apr 2023 02:32:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C23988E0002; Tue, 18 Apr 2023 02:32:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12A1900002; Tue, 18 Apr 2023 02:32:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A27618E0002 for ; Tue, 18 Apr 2023 02:32:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 67556AB432 for ; Tue, 18 Apr 2023 06:32:10 +0000 (UTC) X-FDA: 80693542020.06.CD6A123 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by imf24.hostedemail.com (Postfix) with ESMTP id 57F5718000B for ; Tue, 18 Apr 2023 06:32:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=iXeGBghF; spf=pass (imf24.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681799528; a=rsa-sha256; cv=none; b=r82842jW333Jjkc4MhsnBXwTSyBSR+KDfXaWemN2zHK9mmFcez6cB8zafiHOxH1dS1MxTr QTSPCG6RLL4h1NgMB+elIlujykiDcBSqL0pRJwHuBKmtjRANUEwAtILcO7b/EeUeNRVFOk 5f7U1q5FQ3mscIeyzys4fZtV2ztklAc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=iXeGBghF; spf=pass (imf24.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681799528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jnwKOCRsuLnztB+KT1haBu8YKUI0iN96QK5cHgHZ3Ck=; b=EmAQUXcmrQBxevTJJD1eozTqYAWQum9quDw8hh/gWoRw5XX5WWV9r5f3aRAtLTL+sgu7an ydIc03FoOAqEaecj5iGJ7NXdyuRd/JDjCgpIPL1Q7AuOCs04uVZWotd2M6vzjjwD23oyLB V58t2p3+iw/cY9tfC04ZQxvbXZ3p1ZQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1681799528; x=1713335528; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jnwKOCRsuLnztB+KT1haBu8YKUI0iN96QK5cHgHZ3Ck=; b=iXeGBghF5Q32+W10+T7FqF5MUrWyWWuITQUHSWaABpEjydhXbIEgllBq WFUk79eJ8DTN2gho8n4ooaJ2d8dlHuOJZ6JFHOwSB4nF+0wW8B4T2c2r+ 4oBl/s9z+WH3Fq/4I7PlMplJbxdg1LH4CnAELRwxW/MCM3ZD0UvzWPNr7 J69ca3ZiZLuq4lQqIpKviUSKj1IKtZJ4EDJEiOFdlgEnAZLGcssEpOoZv PETQ+2UJDNg5d2tucG09ub5Rg9RSG5J30ppFSjKt4jlBdtuMis3Sovbot G5Say7+oWZ0rbwv2UlQmCrTL7IIV/SFj9KU3896tenpcAFEYMo2YnzkhR Q==; X-IronPort-AV: E=Sophos;i="5.99,206,1677567600"; d="asc'?scan'208";a="210010487" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Apr 2023 23:32:07 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 17 Apr 2023 23:32:06 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 17 Apr 2023 23:32:04 -0700 Date: Tue, 18 Apr 2023 07:31:47 +0100 From: Conor Dooley To: Hal Feng CC: Stephen Boyd , , , , Michael Turquette , Paul Gazzillo , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Message-ID: <20230418-caliber-clavicle-e8c1beb3fb75@wendy> References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> <20230417-bolster-vitality-89d279146497@wendy> <0fe42faa3b34f82cc2fb73ae61460bf2.sboyd@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Auc3gasTttW5e2PO" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 57F5718000B X-Rspamd-Server: rspam01 X-Stat-Signature: 3y3ozcbhx6iwq6aeoqu16myaycjdud4k X-HE-Tag: 1681799528-574197 X-HE-Meta: U2FsdGVkX1/rXQvpZZXkRU+udEP4+EHwShss4AkGbw44HH1ZR+0TF4EPzCYPG6AsgZNWMMLJimgfveQcPiP6d3JFmemShq4q6Y5mq0DEcBocdmZS1OX89ekemKIlTz13feulysFbEeujjva3LfHAufQCMdb+SHfbPC8bFcquLanFzdNDbZG8KV2Rq0emFzNWGaYerxBmLNQ1PGSgJuRBUayKA46zoxQ/BqUi7vO3xKSaoG6MHIF8gjtZo0aEcZ1vIaddeJyTBGgtO96Ro3L/IbA6AxgB1ozuQg8HWxe011+1K8mNV1DKAk4atexkMkXQISZnEq8WOtu4bjybKvMtvRP246gwv8ywQXycg8985SctT9XgWcaDK7AIA/4dAEu8s9fQWiJboWU7DQ4Z8KvvvCfbn6PdrNIJbS/F3fxWXqfiQsIMtwSalaP9J4fSoGEdeJwANRjcwKVmS+YU02wn+G2u7f2rWEIMONNi0wAUOwXTSi2H1mSyXe1BOKmgF8PdQyGiNs3RRJbZaDc0u4alU/Nfhurld8JOLZ9ZViGOAMZhw94/37+ZTjoeLIZd677H8LeznnXgy5RGuQYps/qWzsA0VcQ+LtFvSMrkCWaV/jyzxbfA2oMukxvetrb2ic+f+/wPGTNuc7bvfoe2KpFJe4YhbZLF2dSxzWYrHByWRNNfA+uQpiCqTW0l55UILYvq49SO70zNIBlevGKX40G2tiHZKxgr4naHQEt6GwYrLXwo84laBaGh4c6tHJ77lBJg4ASfoc5jQyv+7bYt2bq+2abWogbM7ZxkK3nbJ8/XEJvibp0wKG2+B0Bz7fap/4dyK5uAC/h6hXp7FVvNIZ6iVDbzoSCtpzYvUCkFwP2fGW850NMY8C0RBEvw7xWcEEEyXgtCRZeF1QM61vq/00pS492QYrI+sVAYFoBXXfZfj6ei33V0ULH6+QeSPvDnyCkuN92DxVUy/74e4H5X7BO RNCPdvxj WA+ohXDRqxqiVNbvQ87o1tElhL8aR2mYfd1es7rCY4UpdmmoNc2QffrhMkXpI3WFE6b2yI+OQQjsOqT8Dj7l/Ddauic2ImwzSxuErwOs1/IdAmxrM6pyiwNHz/hPDt9VLVa8QVEJaEBxPFyHRFH15PPQGYtDupL9p1uYRU4nhXHmjkah/4dx0dCssrWRbUv0tHa7vaVq/JrQPS97e4UZrt7UI5Cz1LA8KuZ4VZWzqSQNe91EK8cWek7b+z0wuZJ02bZopZNH8ig57zdsW1tmC1ahQfrTLip/OOpVcvsKNTTLWoxqRdTmg9cPjuV0CZRA47Ft/YWmOjNzApx0b9p0Di6lhIwIyACwxVcEv89jtodFLNTNSQjw0BPiWXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Auc3gasTttW5e2PO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 18, 2023 at 10:14:06AM +0800, Hal Feng wrote: > On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: > > Quoting Conor Dooley (2023-04-17 03:18:35) > >> Aye, just the explicit dependency seems like it'd be less fragile and > >> more obvious in the future. > >=20 > > Agreed. Be explicit so we don't have to hunt down select dependencies. >=20 > With further consideration, on the other hand, if we set `if ARCH_STARFIV= E` > here, it can point out that we need the reset driver to boot up JH7110 > besides the clock drivers, and the reset driver is not a necessary option > for compilation test. So the reset driver is independent to the clock > drivers when you doing a compilation test. If ARCH_STARFIVE is enabled, both options (RESET_CONTROLLER & RESET_STARFIVE_JH7110) will be selected & you don't need to worry about people not realising this. Try it out & look at the option in menuconfig. > If we set `if RESET_CONTROLLER` here, the reset driver will be compiled > automatically when (ARCH_STARFIVE [=3Dn] && COMPILE_TEST [=3Dy] &&=20 > RESET_CONTROLLER [=3Dy] && CLK_STARFIVE_JH7110_SYS [=3Dy]). This is what we want, right? The more often it gets built by randconfig etc the better, especially for archs that are not RISC-V. Cheers, Conor. --Auc3gasTttW5e2PO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZD45UAAKCRB4tDGHoIJi 0gqZAP4zWJAbqDGJL6zo/fU0NWtQyqwb3ZmwLp+AV2ApCUFX4wEAqOy+AkXU9CQ1 b1QFGJkfN94a1mIqoBT5EPv8nfrnYwA= =J1Iw -----END PGP SIGNATURE----- --Auc3gasTttW5e2PO--