From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC8AC77B72 for ; Mon, 17 Apr 2023 23:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05EC08E0002; Mon, 17 Apr 2023 19:59:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00E636B0074; Mon, 17 Apr 2023 19:59:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E17BA8E0002; Mon, 17 Apr 2023 19:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D30046B0072 for ; Mon, 17 Apr 2023 19:59:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 99CEEC0428 for ; Mon, 17 Apr 2023 23:59:03 +0000 (UTC) X-FDA: 80692551366.09.7DD9B78 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf06.hostedemail.com (Postfix) with ESMTP id BD35A18000E for ; Mon, 17 Apr 2023 23:59:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=eV+wV0fE; spf=pass (imf06.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681775941; a=rsa-sha256; cv=none; b=YoyQYnKh5fprZEDtSoNl9zJ9ve0aAfcTuqmQ6CANa8zKVQfcMiXVbpyNpfAnh8kjW7l8dt hENSicXuBJ1RWH/rTPAttWMdCfQVW1dzk1qaIS6sbI75LsB/4cl+7Cnn0GI/wFM6WQVnxC ujJUFPu6eOTst7zZsfl8dEnYxfZ6u6g= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=eV+wV0fE; spf=pass (imf06.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681775941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RITZpfJt2wLFaKEtLmKDqjHQz+u5pMX2rxMOSSEHGY4=; b=iMrGwmHM/6wdFhaIR/F8onx88YXY60RannTSS8seCzkcE3qCRw2UnC8oX7sLeiMLxaSoE/ AnhhawDyvTk+Jw/bDH6Bl+CEFYN2HY2gQ4UA9hy3pU9BrHHlHn6dxO2i+mIAWdx8zT+aLx rdz3v6UIIKgdj5FJ+jjYOLkH4G92Odo= Received: by mail-pj1-f46.google.com with SMTP id g6so10667371pjx.4 for ; Mon, 17 Apr 2023 16:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681775940; x=1684367940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RITZpfJt2wLFaKEtLmKDqjHQz+u5pMX2rxMOSSEHGY4=; b=eV+wV0fE9fa5MwcZz3jX1qGVEUvr0bjd3uTCoFpCYZeK+6YZZpqEXVmSyY5elgt4h9 tQhjfoATVFX1GrjYBihNUFPCqa0H8wIvXDCW0Fr/ppaYUAY+QJBbtDcIPRAiPzLs27V5 KsxTwW4kKKHvgC2u9QxKxi03MaOOA0coCGpxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681775940; x=1684367940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RITZpfJt2wLFaKEtLmKDqjHQz+u5pMX2rxMOSSEHGY4=; b=Id9xoHBXqkIeRApgKZIzTZOhMqdwbxT+TnmBduDu2agO0H1MmXl2mqO84w66hwCOmk zvgp4tPd6g9lGsaFYXVtKVVbWkvmvdmk1WVta07C4i1cA0wTQoz2RW17/lOP6Ok/ohzu F/grAhOO1LejL904SYFtF2Fp8WMTVnz30hpcY20q33xz2nRpAFZ42tE0gyL+AYE/Y8n5 efEG6Noho/rJNhN9v7+Sf9M1++2GoiUBVjHy2DL8rlvTror5+sDBhvkwxj+Gzs3XwCf7 KfuTag2G2R6Z7ODbTLPiDT7bNoi5RJ3uokHePM1450qMyr9Oi7fFas4VvHnWtGlCjjaw IT/Q== X-Gm-Message-State: AAQBX9d02ZfIiGCnyW3o0SnEB9+yZ6kXznXmwQAXTFD/KzXIdHKWXHtn AKNYP5FlRxvYjA54+EcQERFK4w== X-Google-Smtp-Source: AKy350ZDxGjkza/NUyha2Thb5Pzfe1zhquy2390TvypFPir0Sup4XTpiK7+NpSf9eMXus+V8Wer5hg== X-Received: by 2002:a05:6a20:1790:b0:dd:cae3:641c with SMTP id bl16-20020a056a20179000b000ddcae3641cmr12691896pzb.55.1681775940331; Mon, 17 Apr 2023 16:59:00 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id y23-20020a63fa17000000b0051b93103665sm4218792pgh.63.2023.04.17.16.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 16:58:59 -0700 (PDT) Date: Tue, 18 Apr 2023 08:58:55 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2] zsmalloc: allow only one active pool compaction context Message-ID: <20230417235855.GR25053@google.com> References: <20230417135420.1836741-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: BD35A18000E X-Rspamd-Server: rspam01 X-Stat-Signature: jxaruqtpxcm1bc33bztfo8xnm4fpx1rw X-HE-Tag: 1681775941-998511 X-HE-Meta: U2FsdGVkX19t0AwmvUDhBrJmAcT6eHAkBAbFd1LwAKsCCjY3hsSwvLFgFD7hheM6iWzbz6TWoK8N0fi5kvEQKaWXF3qu4oKGY5Woqz1Zu+f07p/p/WQldXdk6awjuJQAXOH4yoNkN71wb+d5IdUTX3bK0TNunxCoC0VRzgGdCIln1TfJM9kp0ag197y3ynzxFfoAoTJGuwaYpxPoTbG+aQlg2uBdFxrRC5vItvKnn6KBNvBT0NTsB7oI0zMGnAo4tTfIpKETOxZsQQENc+jShaqOAgf3M2/Znqj6fcuFzI2nm7GUSFmmEbnSw7d+iSQP/JwEf1g7oQrcRem7m3tuQVC1JvyhiQ3+BR29kN3bxiUmvCK5u2svNtD8lavUnrwTn13dwvVYIASvqctOAkiIZs0hTEudPF4F51cvA/lt/E2FZGs1JEDge5Tw/zZudE7gjt/+C5xE6eNdrXp8ynmHjPgoR8hD9jQxr96KmZ7KeX6UK0KzLB/gTvJau7QW8tokpwdBgtb0atJnPB9jifNA7cayt3fN3JGBC/16QrjmWeavOY0F8qbiVKNEfuelM/KzuJJ0UKszOrHk6FsULJxYPr8LlMPHAq1bIlWP7ZZG4dzlMSZ5nu210u1Hr76DgB4iXiXLn/jL++uCUfySqZV6tScxqYOi9rfXiCauaf4vTllQgdD7Nx6KU+5YlddDFyPeTkgRjpoW0v0si7bzSonCstLRllx+1K/MyNIWtgT2MBfShGLpr6Ndo4OPom8NoPLW1t4x16f0c07t7Dti0SCAYPT1jyLwVQ3faBh1JEW7aBcCDRAA5gBysC76oXdQZIpv55kjQDeulau+Vv4ML/TpcdmW7Ws1zCzqubWBrytKMr62ty+DavK923vSH67u5T77jBFf0DzNnKTDO1d/yxET8mvWieFqgC5Oqi5FSa8lvc+EcegIuYVvyWXhvoNQoQXzc+ICpKosmZAw8roMilx E3ZB+JrC t+S+1Tr6lsZYjdw1jE6+RbsSn5p6Ybq1KptzTFi+isoBYPL9Pj6t0CPmSW3iuBak1pJxjRYkWlStlQ07RQuOW7o8yjiLae/dth1we2AAM7AtgeoKbvSm5ZGlFm8vyix4epP5uL+NLiGFqgcR7zAeB6XBo8jliwq+1Umdmhifl+34Gf4tMoNSwQk5sQ2VQ0bV/zU5truRHs7S3DHBqnMxTSFqivM0ioecxRYGCBE5CYzwN/z5IyGIbiwBtBBmz8GUEDtNtlP+nbqW/PFoIYyaevxjwACboxNPMhRtBYC4VBNqofiea6fesbyFDFMvOzEH+OHyrFTmyOfSu+B4FDIRouL7b0ENmB4nY5wHxaKMIZJ1oem+n4MdP2kAWOupYkpUvWuGN9+D9qlNLVe4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000815, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/17 11:32), Yosry Ahmed wrote: > > /proc/lock-stat after make -j$((`nproc`+1)) linux kernel for > > &pool->lock#3: > > > > Base Patched > > ------------------------------------------ > > con-bounces 2035730 1540066 > > contentions 2343871 1774348 > > waittime-min 0.10 0.10 > > waittime-max 4004216.24 2745.22 > > waittime-total 101334168.29 67865414.91 > > waittime-avg 43.23 38.25 > > acq-bounces 2895765 2186745 > > acquisitions 6247686 5136943 > > holdtime-min 0.07 0.07 > > holdtime-max 2605507.97 482439.16 > > holdtime-total 9998599.59 5107151.01 > > holdtime-avg 1.60 0.99 > > The numbers seem to be better when using an atomic vs. a mutex, is > this just noise or significant difference? (I am not familiar with > lock-stat). Pretty sure that's just noise. The test is make -j72 on a system that swaps out, so it's terribly noisy.