linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: "Mike Kravetz" <mike.kravetz@oracle.com>,
	"Andrea Arcangeli" <aarcange@redhat.com>,
	"Mika Penttilä" <mpenttil@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	peterx@redhat.com, "Axel Rasmussen" <axelrasmussen@google.com>,
	"Nadav Amit" <nadav.amit@gmail.com>,
	"David Hildenbrand" <david@redhat.com>
Subject: [PATCH v2 0/6] mm/hugetlb: More fixes around uffd-wp vs fork() / RO pins
Date: Mon, 17 Apr 2023 15:53:11 -0400	[thread overview]
Message-ID: <20230417195317.898696-1-peterx@redhat.com> (raw)

v2:
- Added R-bs
- Fix patch 1 issue on hugetlb swap entry [Mika]

This is a follow up of previous discussion here:

https://lore.kernel.org/r/20230324222707.GA3046@monkey

There, Mike correctly pointed out that uffd-wp bit can get lost too when
Copy-On-Read triggers.  Last time we didn't have a reproducer, I finally
wrote a reproducer and attached as the last patch.

When at it, I decided to also add some more uffd-wp tests against fork(),
and I found more bugs.  None of them were reported by anyone probably
because none of us cares, but since they're still bugs and can be
reproduced by the unit test I fixed them too in another patch.

The initial patch 1-2 are fixes to bugs, copied stable.

The rest patches 3-6 introduces unit tests to verify (based on the recent
rework on uffd unit test).  Note that not all the bugfixes in patch 1 is
verified (e.g. on changes to hugetlb hwpoison / migration entries), but I
assume they can be reviewed with careful eyes.

Thanks,

Peter Xu (6):
  mm/hugetlb: Fix uffd-wp during fork()
  mm/hugetlb: Fix uffd-wp bit lost when unsharing happens
  selftests/mm: Add a few options for uffd-unit-test
  selftests/mm: Extend and rename uffd pagemap test
  selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBS
  selftests/mm: Add tests for RO pinning vs fork()

 mm/hugetlb.c                                 |  31 +-
 tools/testing/selftests/mm/Makefile          |   8 +-
 tools/testing/selftests/mm/check_config.sh   |   4 +-
 tools/testing/selftests/mm/uffd-unit-tests.c | 318 +++++++++++++++++--
 4 files changed, 314 insertions(+), 47 deletions(-)

-- 
2.39.1



             reply	other threads:[~2023-04-17 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 19:53 Peter Xu [this message]
2023-04-17 19:53 ` [PATCH v2 1/6] mm/hugetlb: Fix uffd-wp during fork() Peter Xu
2023-04-17 19:53 ` [PATCH v2 2/6] mm/hugetlb: Fix uffd-wp bit lost when unsharing happens Peter Xu
2023-04-17 23:48   ` Andrew Morton
2023-04-18 15:14     ` Peter Xu
2023-04-17 19:53 ` [PATCH v2 3/6] selftests/mm: Add a few options for uffd-unit-test Peter Xu
2023-04-18 16:08   ` David Hildenbrand
2023-04-17 19:53 ` [PATCH v2 4/6] selftests/mm: Extend and rename uffd pagemap test Peter Xu
2023-04-17 19:53 ` [PATCH v2 5/6] selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBS Peter Xu
2023-04-17 19:53 ` [PATCH v2 6/6] selftests/mm: Add tests for RO pinning vs fork() Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417195317.898696-1-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=mpenttil@redhat.com \
    --cc=nadav.amit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox