From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5B9C77B72 for ; Mon, 17 Apr 2023 19:08:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 203D66B0071; Mon, 17 Apr 2023 15:08:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18CD06B0072; Mon, 17 Apr 2023 15:08:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 005908E0001; Mon, 17 Apr 2023 15:08:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E0E6A6B0071 for ; Mon, 17 Apr 2023 15:08:36 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A54B3C06C3 for ; Mon, 17 Apr 2023 19:08:36 +0000 (UTC) X-FDA: 80691819432.22.9F1F76C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id EA01840005 for ; Mon, 17 Apr 2023 19:08:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Eiy0UGNc; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681758515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gh8Hsv/RKqxFLYFspnVz2/Cs8kJzjy53Tv+GBe+0v40=; b=5Cpg93W30n/nlTI3cJh9D4BUafSGDMvKUe7vVv2L3jA/24IqyFg8p2K/Tpb4O6H43EY5Ts cLk0YFzYP2nD9N3ku6UV7PDj0L1n2WS5b8rN6NqyoeCPl+QgNCFIKAEo3voEDB+29Cb3eN AWe+ZaZ2MwaWNx4wEMRD0dHrVDflrhY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Eiy0UGNc; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681758515; a=rsa-sha256; cv=none; b=kB0+3GYzJAsoZXZlAQvwefcMMbhV/yUSmtzD7l4SU0xwkNsPs8aLyuiAb8W1iwZcE3ADLb x+tNYLaJpTX6UhWiOFDR/hHfEv0SzPY+/Rp6zEhKQvzzKOlYcd7MHtolK9nFOfDQleicps CS9aj29+5CB/tbHYwQCTUVThTS9K6mI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06491620A0; Mon, 17 Apr 2023 19:08:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D870C433EF; Mon, 17 Apr 2023 19:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681758513; bh=DvfaB+8rMKPdQmf0iRaItOKw+iFrC1CjBgL93/QX3ZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eiy0UGNc/HcVJVXw4mIuX/Mo1o8ZOgc5A6YcqzOEPvyuHIuR7UtLSAst0+UaRIxl2 uwPwwUJJa5mR9RgPBDelSAg6r0/BOFsNINI6ZmcGsFFXTpgin4TGiZcJ98Lg9f1jbq whnu1sNk7WhKnCfiCEVp/94k3Qzs9cucl3wIZyWgpRz0RierQGdlzM+twf9LdDEt32 T5I2Yqv67kvrnAdwtX2AIzh0+pfqhRlSljQVanLUT20E/pkDi6UMXG2M7HCsTjdGX6 kD7HyVEPVDgIZu5foW2jkkzpgt1fz58weRRl9edF2a5VXHMqumD0ogl63c5cGo5o0y /B+G++FcRroxg== From: SeongJae Park To: Vlastimil Babka Cc: SeongJae Park , Matthew Wilcox , akpm@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Date: Mon, 17 Apr 2023 19:08:31 +0000 Message-Id: <20230417190831.1744-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <17bbab58-3cde-e980-bdeb-b9de65848b2e@suse.cz> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: embxitf4ohhxuj5f8utncymba3jx8r19 X-Rspamd-Queue-Id: EA01840005 X-HE-Tag: 1681758514-244620 X-HE-Meta: U2FsdGVkX1+3smP8JmSDl0T00Ks2qY2T6VxymmoOy7nTeltVwXcFAogvUYTeKxzYhs4bwm6IuEUd1w6emYLzLdtWOmxcPYaIs9dCQeLw3KBYhLZCk2x6ehkmWmd7a8dZ7UBAgANHlwS0XCeK+vHHn3QZgml8sa9rjWSXwi5cM432J711Z5j3Gpkw85LRuVv0ZZCA+Ht0KhqELkv0kVJVYCB8XYD+xYTT2wm2jfvL/luMOQVAgDv9ipMaIrb40BsiaNviN/apzY71a5xFja2oLjMXr0hjTM/uURaUuM3pBjX6j3WNZa23f16s71qpfs7hO0I0cDxw4UIwI86GGw2+eTlf+L5E8RglX4NDef+XMyfUQjB9CernNehSdyMLuz7ZYHg3e754P29LkFNH2TduUhnpQpDejHVez80/2J3iLhvMuKyGBoEuB9fRTr8HHk8raOV6V5prPbHNJ5BqeclpheaC/BMNdOXHKCsbNoiqzSeXlMLO4iXcf2ctVf+Imlb4BSaCkp/xo0kfJIV/oyc0Zg5xn5O11jXlZBV9aRcUeByld5UeNxBsn8YnPvM9Ty2Rz68aOzPoJjh20DD3l5AJHQyMg86ddwruHvdB0s7vBew0Pq3wibrtoV1F1ENoXJfdfHwc6JjlaKpHC9ziTV12A+95Asu+/tIMwDu9fTZyvOkxTWNMbzIMnMyB8DoYZ6G5+ukfrP+JqVij8Z650OG7yFLbVJ2guXYu85FKtWFs6WGLUPUZH2MgAvBig52wXUfC0KX9dA7q8fhGMJphYNBbhekYS4sAsmOG6mQ59uq00yagy+pBFYxlC6bd4auioBDiK76vUlO9qHFDBMr+WbbQSdDXj6jQJt38ocHk3iypuOI2939YDPDbtW5PGzmBTJ1ryJGqIztiigjVg+KJaMFI5nPHTUkKvUqmK0cW/+iBAulUQYq3IdVT3bbWiUbCTDKNzhCOEmkPyL5KBYUjKs/ iEZant80 +XypIeoGYLhrs9B/TZjyABz+SfEr/93ZgXGGj5isauIwX0TrrD7nuznzobpytoh5i73eGvEMIXz5lYmy4nZDMl71ujyAHR9pPVkaO2PiruQRyPQ3+rkurSt+L2wfZoBQVN6rAxk8nAD8Zn08gXPzegUqhN2LkYMZSdNtIeWdWppHK/9+3u/Wn1WYcA6AUV0aibfJQUMkbQrcGle8bMinlZDU17sCa7BiOADOUgyvO+xLQ+pBVnW1bStXY8tVpEeNyy6eFbQd3EUX31F4MXnAzRwPzDQKutia5bYyewxrkmPTr7KeNU2/25pvGvF+MmULvp21m+TCglrIflAHUecz0mzpT5G6n3NuY20fMTNE7TSGJelBYLmVr2WIINaSjGHKA7Gn44pnnlOadSO/Lk1ZjSXOe/WdeJnfhzKZ3QLJfSrrNYzRUyoTaxifpWQn3vBUieG4UQmwfMwVjQ2E9xJ+y/GETBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Apr 2023 21:02:22 +0200 Vlastimil Babka wrote: > On 4/17/23 21:01, SeongJae Park wrote: > > On Mon, 17 Apr 2023 18:53:24 +0100 Matthew Wilcox wrote: > > > >> On Mon, Apr 17, 2023 at 05:26:57PM +0000, SeongJae Park wrote: > >> > Hi Vlastimil, > >> > > >> > On Mon, 17 Apr 2023 13:05:40 +0200 Vlastimil Babka wrote: > >> > > >> > > On 4/15/23 05:31, SeongJae Park wrote: > >> > > > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU > >> > > > >> > > Since "tiny RCU" means something quite specific in the RCU world, it can be > >> > > confusing to read it in this sense. We could say e.g. "... snippet uses a > >> > > single RCU read-side critical section for retries"? > >> > > >> > Looks much better, thank you for this suggestion! > >> > > >> > > > >> > > > read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has > >> > > > similar example code snippet, and commit da82af04352b ("doc: Update and > >> > > > wordsmith rculist_nulls.rst") has broken it. > >> > > > >> > > "has broken it" has quite different meaning than "has broken it up" :) I > >> > > guess we could just add the "up", unless someone has an even better wording. > >> > > >> > Good point, thank you for your suggestion! > >> > > >> > I will apply above suggestion on the next spin. > >> > >> For the last one, perhaps changing the tense would have more clarity: > >> > >> similar example code snippet, and commit da82af04352b ("doc: Update and > >> wordsmith rculist_nulls.rst") broke it up. > > > > Thank you for this suggestion, Matthew! Will send a new version. > > It's ok, I can just use that when picking the patches up without a new resend. Sorry, already sent[1]... Please use or ignore it on your convenience. [1] https://lore.kernel.org/linux-mm/20230417190450.1682-1-sj@kernel.org/ Thanks, SJ > > > Thanks, > > SJ >