From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5C4C77B76 for ; Mon, 17 Apr 2023 19:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D50988E0002; Mon, 17 Apr 2023 15:01:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFFC78E0001; Mon, 17 Apr 2023 15:01:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEFEA8E0002; Mon, 17 Apr 2023 15:01:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AB1188E0001 for ; Mon, 17 Apr 2023 15:01:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4C7428066A for ; Mon, 17 Apr 2023 19:01:37 +0000 (UTC) X-FDA: 80691801834.07.635B80E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 499D640023 for ; Mon, 17 Apr 2023 19:01:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=d1myIjNh; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681758093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WlwhzG5oPN8QfX+LWxClEppc/ZqoHFgC0JZbuUyx5do=; b=IfsfzbxoCWYeGHMjWw34Pk2gqYuWMLVCfd7q4FvlSX6wqlN/onPIRxWK6Ce3eFrNVU6qUS O6LEEpvlyWeFeXVvUSZSZC5tJ6Jz7nLmH8+DvnuoT45GdRz7dKa2aNqn/xSLey8/dHL99O SxszgpLBj0uOMGOI+RErkKAgJrDC7BE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=d1myIjNh; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681758093; a=rsa-sha256; cv=none; b=HLTt8NAPHWg37z73hPffqpAwoLg/rVod6+JO84h3Pecu2SdnGbpbi6sVEBJit124gYwF7f E5il1VH3tgVSFiM7JN1PKfgklC0zwcyY6rUVc68p5FiFRWvK2VIqK9P+hZI220YZvCHRQ3 Cfw4hX/hWp736CZUrOl+uu0BhM3LqHU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41F64623E8; Mon, 17 Apr 2023 19:01:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4134C433D2; Mon, 17 Apr 2023 19:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681758091; bh=XmPwWnyoTnixvrnBOL2nRZgx4VQqvaf1gkEpOzKe6MU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d1myIjNhaFl8VGvLbk5LulAkonJAJR358XvE8BCdZi0zONfP4AqfcLst04S9BfNjR jtpAAsv+owpct/B01rLXkpPdLAlOMAvb+5y1z0DRfATX0aVtPyPyOHopihXwCSV0sx 6Z4gx6x6DpCzk5YMyPji/doOPqYn1IC1ahqho1rg8xr56/wuDO0V2KDA4apnmW8sbg gtkvHTe8DGcqJK4uLWGt8LSbK4lDL/KlKkDXsb2aSER3WmqMGy0aZL+m1BlfjcuZea kuVI9kMX4fiQXC8OtXpFl+D0GnpHOGsUZejaePY7iDb6Qk0tdrI352LRILYGpU22I2 O3IEUTdOrinZw== From: SeongJae Park To: Matthew Wilcox Cc: SeongJae Park , Vlastimil Babka , akpm@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Date: Mon, 17 Apr 2023 19:01:29 +0000 Message-Id: <20230417190129.1454-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 499D640023 X-Rspam-User: X-Stat-Signature: dfk15p63eim5ukh6gspwegx1g9bujfcf X-HE-Tag: 1681758093-237492 X-HE-Meta: U2FsdGVkX19yWfcYr6o43XPS4Dz4z3iCFPO3vuMOcozWHEbnMB4CEp7qOGp83dp60YT26zz8u2QyJhoL0vd/hw7/KPGfbzamHouyZpF3SH9Y/URBnOhL3Rq2D87UEO/brZ/mBovhpTsMGVr1/TzkintzVm5ZfbJG1Fflq3iUVVyCkG3jcEukcM/9HtN5sIZg1xBnVNuejXZORd2aKrL8Vuzgs/lxCFZidffvRe+8SlTgE/6FyVDyqVF0xQFPVdgq3I60pGp4x3TvQH78tIpBXRtHsix6K5k/Qcehs5qYWKNzdmbuxEqdJjVe/8atgVQ3lfCSKRQ5ipGb4cv7dsl2R2LQHzLbzbkByPNqdyzzYkr1PFFex9LaeT4tP325bXuYA0JaHKHHMx+S2Ylb6rdIWOGcg3BHl+mBjhHkTj4exJSHXYti/hB8R2mSUlX/yJWXjmEGakRlIwCPXOc0RtXuoTyoHvgNN7EKYkpENdECPetYB78PVqEiZzDPnTLQPdMymcqZH4ofL4caY2RGtCcVZ+yfOwcqww1gYyc5ka3Q9W6M+9SLxIk7TadIk5AbjSv5GYitrVrYIdoc0GrdrICI0slNqRrcUzMmqvrSoySMWVdoQKJ+eReet98woJt28hHw8CZOfpovbeTT5yZqPm3eoUQB8uGaTE6GuHiqRfltC1q6KN0GAX+nxfY/Uzm0SPjeSJf0KXPY10HwCURm3vibLLXLzYCgpsf20iMskBp3Fo2m6fILZaZcThtV8x3zN6AmLmW4NaPm5wEiQUOr17HxFE/9hTdmEQ75YM7FGdEjyBaPvIea0ZHiLiKQnP8+O0VRV5VAqg7efqbUEC+oFzpxqa07qJmm5hmq5Wo7F+jcX0KJuTi+tFon8CmreBm9uzoTFZxO80SYSxtWzim570ipGIQ3rk34qEsXrJ2rXhvnR08nyEJI6ifSZ/9M2xgPSpbVne59a6CMGVLLqr49+qz /kzmYtww jpK925sMDYfcnocX1uPi5x4EWsL/FCMyJt+wBEjLE9+9U04oH6vuJilOWH+sBZqKLymUyfVt1Gdm++t6tQQmv5fVsliBfHgCBoTgcTIqN/RzYMKEj9Tc0pjxAfcf7F2OZVY9G/xU9yoy2VjsN804ZwEj3JZGpaxhv58DtEq6gdqRmDFsa+mH4VoF/vSOREeOIS9QlfHirvph9g0hNCbdjp8xrGt4JxUgs6hzUBh6zqA1cSeYYLE01kC0FjvRfF8Pse36KMKkAlsLb5bUlwk3yCzYwBXLLuO2t7c5J+i2TvzkIGjSZgG3gXYmyWAZXMjnshznlEEX01CMsEQCXvD1uNgfakV7zoc8ZPlxzooMTvfoGH6vLiG9my2rplD9jO3fE9cxRysOMu2X3cuYUbYJvRP6c6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Apr 2023 18:53:24 +0100 Matthew Wilcox wrote: > On Mon, Apr 17, 2023 at 05:26:57PM +0000, SeongJae Park wrote: > > Hi Vlastimil, > > > > On Mon, 17 Apr 2023 13:05:40 +0200 Vlastimil Babka wrote: > > > > > On 4/15/23 05:31, SeongJae Park wrote: > > > > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU > > > > > > Since "tiny RCU" means something quite specific in the RCU world, it can be > > > confusing to read it in this sense. We could say e.g. "... snippet uses a > > > single RCU read-side critical section for retries"? > > > > Looks much better, thank you for this suggestion! > > > > > > > > > read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has > > > > similar example code snippet, and commit da82af04352b ("doc: Update and > > > > wordsmith rculist_nulls.rst") has broken it. > > > > > > "has broken it" has quite different meaning than "has broken it up" :) I > > > guess we could just add the "up", unless someone has an even better wording. > > > > Good point, thank you for your suggestion! > > > > I will apply above suggestion on the next spin. > > For the last one, perhaps changing the tense would have more clarity: > > similar example code snippet, and commit da82af04352b ("doc: Update and > wordsmith rculist_nulls.rst") broke it up. Thank you for this suggestion, Matthew! Will send a new version. Thanks, SJ