From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D37DC77B76 for ; Mon, 17 Apr 2023 18:55:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 626766B0071; Mon, 17 Apr 2023 14:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D6738E0001; Mon, 17 Apr 2023 14:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C5ED6B0074; Mon, 17 Apr 2023 14:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3C6A96B0071 for ; Mon, 17 Apr 2023 14:55:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 11A9B1405DD for ; Mon, 17 Apr 2023 18:55:33 +0000 (UTC) X-FDA: 80691786546.22.0AB966B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 4FBF040017 for ; Mon, 17 Apr 2023 18:55:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nOK8sMjE; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681757730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jycDFvLYVeDmAHqm1HmQN40t3cR2kBxJszjWbQ9gDes=; b=qD62fnjDilve/HmXxUkQba3Qnvbz3aZHwVcBtyKwlS4uiOBCfL5eCR3N58VPIA+dgkBc2z eWOCYSsy1aoUb3qbsA/T8XTrTNcvMUh1cmIUyKedkAIzu7w32YSAW2J8mw5ho6QIVx+8nD AXaY460zogTani0YlpqJWtr2lY2n66s= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nOK8sMjE; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681757730; a=rsa-sha256; cv=none; b=7Djbms86SVS5qjrkN/aK1nAf34XMMPXCpEl7+l6JSH0epeWyFmgdZzqPS/pCfZ+pb0X+cT 3ZOblsYIKdwNsDmJrKEb1BNhUkt4MKE7Nfpx23DigiesW8Wnp2YJJGZvYR+Umor4h5I0c3 pafunoWZ0JQWAEhHeMUmelBK6yUbIAo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B901626BF; Mon, 17 Apr 2023 18:55:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 245CAC433EF; Mon, 17 Apr 2023 18:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681757728; bh=jpvGVC73BKKb3zx3vqvMtfK1QJtXKHouU9cI0yUXfAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nOK8sMjEU4Wb4MD/qUb4cZSsCxNFAA3MKO0hekNxrSMI973fsTIRwQbtfPWlHiUOZ CL1UxIVw2mK5N1SyVVJufbiWMVt9zAvrnGQrLsb2Y/VP+C5vRUX0/K+H772BxBrnqW gV76kKx1vWJgQ/GSQMsAmsvKeNWqBpQZAejLoQVL7+2ISot2MyJVxgxHl3mzMKqghK fSxQgS/yktU520k2AyHVAefJzS0Vv3xSOSgHn0ZyLM8JVhlOjLNY2YlcF7yE6WZqp2 nUASHScS5EGGleflSPArRKwjWGJOmiX0SIfs+JOLrRUXEE4PGZke7FTHmbREz9aX/P SCV2DFfCIIaFw== From: SeongJae Park To: Arnd Bergmann Cc: Andrew Morton , Arnd Bergmann , llvm@lists.linux.dev, Vineet Gupta , Mike Rapoport , Nathan Chancellor , Nick Desaulniers , Tom Rix , David Hildenbrand , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Suren Baghdasaryan , Naoya Horiguchi , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, SeongJae Park Subject: Re: [PATCH] [v2] mm: make arch_has_descending_max_zone_pfns() static Date: Mon, 17 Apr 2023 18:55:25 +0000 Message-Id: <20230417185525.1420-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230415081904.969049-1-arnd@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4FBF040017 X-Rspam-User: X-Stat-Signature: ngrg9sy7jmnpns58euk5p5bdbrdrob98 X-HE-Tag: 1681757730-763064 X-HE-Meta: U2FsdGVkX1+te4jTUVvhh88MIDVHetS1FdjugaE46A/SH49lVrRxiCcEs7IoapoK3tB0bnIvvEUIj4xxlBF1N7Eo4NWCnJOWFtxmsILwiMUKsGunD+3buV6v+xqpTs8ENg0dn/cDrnoXpsqRQS+Z3+97PCCACZSVXNrdgS/+OXOu3bAZTLs1PS/XAj7vf0tblqF/pf/Vj6VPt+9xRbakF9xz3adULiOJGQs3V821g3TzexfqJPnL7zNVTJFMRHv/SWwzFk66BTxmvz1alS5+JZah6p3k119CRKqolujlTDJ36d8d7aT0iu5kqF8irBAhZ1avlebVFKmeNoXfwtxZ6laaRnjYi/l9AdcV/CXgE49cjWf4ZivOrPaF8Eyrrm7LHdmYNS9srrZsisTns0oTB/yayVYd/pnYj7etiEiXrfm7bwhj+fnhrJyBuAYVbm/3Tejf20PcAy+N8+lHXl9K1ieZ4Iqtbgj87hdUcbmCIGISAiasJHigEQ2HgHEenoWGbzC2MMKXV7Fh6CDPJZDnXb/ARYinRbVkc7NnS0Lf3DlhkEE0JPXskjZ4p8TfUrrtOWZAX451Tx8NU9iSX46bOcM4wJGD4+7OhXHR/TVXb8dclT2acDMvBqYsJ+eQcWi2YfchqmzbvxAH5oPYUWhysz/QtanD1aOE4LUO/m7/WChOoXkI571ltFGOpfEF/Nqk3U6N6G7KvUOKmhE64EXq4pTs1wVex/Ly3hisLDsRs2k8VWb25E4tXPyw17pxFEZW8wjf74+zdQjiQBCBVoraefYHwlnKFhHFPddjaDgqnT5ifr8xL6SifVN2UlcVm6ZelRbbex+SVfIK0AWcvQB7DADxWFixGWDbfiuBkUqT64l2Zs5ktrE7/fGny8/WWDrPaFuYUC9WFTx6A6Mdhy1ekx6LzeiWXBUe791oWcQQe7ZFp8fnNt58ubL+PbH9B48y9qrQSUMa13Spt9lkwS0 HSbXHDwP 6JUkXFfIXBzP+7ClD9gGHi3XY0abc9zlMOpddzlZ9kEf85GbbfBBlZI3+UWzmUqyN2pkJKTojHLXhyhnn1kEBCcGgJGAhpLHnt15i4xklNukwv5Z9ROvSnnZg5rKd/8TkgWRSn0yqPsLewZWVYLQQEZXqU7b+h+AsuNYG9ykWCAHQ+1sME0zgt5TDdkXlI+2in6m0X35pMjzbWjdYDcBfsfap9izwIBJnqsbO9fLJt3E2jvgJDsbM7xBCuwK+1RtB6ChPrUBimRQ4XFKOxorIsiE/oLSBSJc+/9gzTJ2/kdTbFqOKa8KeWIbURoFf4Li27aJfAT4pzYRggohHU3hB4vv0CgrfTxy9VhYEE0wpuwtEQ4vjztrcpyi/D6p0egSFIjmVRQqn7RUa4VJxo0/0JV8yw/gnMiBCCL8b4aR/z2GFehI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 15 Apr 2023 10:18:20 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > clang produces a build failure on x86 for some randconfig builds > after a change that moves around code to mm/mm_init.c: > > Cannot find symbol for section 2: .text. > mm/mm_init.o: failed > > I have not been able to figure out why this happens, but the __weak > annotation on arch_has_descending_max_zone_pfns() is the trigger here. > > Removing the weak function in favor of an open-coded Kconfig option > check avoids the problem and becomes clearer as well as better to > optimize by the compiler. > > Fixes: 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c") > Cc: llvm@lists.linux.dev > Signed-off-by: Arnd Bergmann > --- > v2: fix logic bug reported-by: kernel test robot , > see https://lore.kernel.org/oe-lkp/202304151422.5e4d380b-oliver.sang@intel.com I was also encountering similar issue, and confirmed replacing the old version of this patch with this one fixes it. Tested-by: SeongJae Park Thanks, SJ > --- > arch/arc/mm/init.c | 5 ----- > include/linux/mm.h | 1 - > mm/mm_init.c | 4 ++-- > 3 files changed, 2 insertions(+), 8 deletions(-)