From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1461CC77B70 for ; Mon, 17 Apr 2023 13:07:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC9888E0003; Mon, 17 Apr 2023 09:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A527C8E0001; Mon, 17 Apr 2023 09:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F4268E0003; Mon, 17 Apr 2023 09:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 81A308E0001 for ; Mon, 17 Apr 2023 09:07:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E0DFAC0D9 for ; Mon, 17 Apr 2023 13:07:35 +0000 (UTC) X-FDA: 80690909670.12.993CCBB Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf01.hostedemail.com (Postfix) with ESMTP id 6113F40027 for ; Mon, 17 Apr 2023 13:07:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GRPh4oRa; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681736852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e2nbVjTG+rwOLIIWdYvkuFGThNWk4ROtsmXtB/FlaiQ=; b=oljdzr0OU3Av1GG3vNjGUNbtXSFUCClpeda4wx+2U64kIFKj2lqJKkzB14eg4qMG4oWCxl uW+ePor81Yz2TfKj2vNcaLleaneP45AsBtTZUK7xL2JXLKHlU1cDvqRDDok+NDJOO8Sw/i e2irVaGSdbniYsrdrlXfH/xMkAgP8lw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GRPh4oRa; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681736852; a=rsa-sha256; cv=none; b=CYGYhI/vzIGmsNHZY/vJ6zGeOZPb/pAvJKrc4E0XBD24PtftLuBvT7hrZRz3U5CcbKhlEx WE1A9/hIsRzlqNysjt4Awup1EIJCgsJlCFi5u7wnUxN1KvwRj5bTaTG2RG4hBjqE27C7XC 859vERkrGmr4UJZbOP/6WW6nhsv/FhU= Received: by mail-pj1-f53.google.com with SMTP id s6-20020a17090a698600b00247a7794e78so1692565pjj.0 for ; Mon, 17 Apr 2023 06:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681736851; x=1684328851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e2nbVjTG+rwOLIIWdYvkuFGThNWk4ROtsmXtB/FlaiQ=; b=GRPh4oRaAQNCW+Xy26biO1ezbnOT6FVEi2bJ554bozSaVO5cvtCICTkzvPcnKaOwMj xBlUjW0fh7gjbt+uO2YYE337FASfH1ycpy0PZgdtuTSxU06XN9eKc3BF2JbB84raTt0Q yeerFjzgOw4Ut0+51iZK/UC/WSwSc/EyymADM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681736851; x=1684328851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e2nbVjTG+rwOLIIWdYvkuFGThNWk4ROtsmXtB/FlaiQ=; b=dg/Bni/+clmYv4XEIS9ui0xoGKlOkOrcDcsHJtinId7qZMJ/C1CFXsRfCcZq9XOXUM wNmyq+03Q4gzEiygJYL9/Sn5XY/N1x/kgoLPplqSyDgeVp7mKnXQr50Q4ASbJBmzQMM5 o7ysW+tmKHikpBz1Q0lcdJNjePrZ9yz3AwARAHE0uvDClKE6CXaEv5mTC96mgYfR3H2G pRWsBhby6RdKmKMHz2jZ9npcAACgKPTgFyzPzh3uvNB3jrWjRtJvvgMKcMNDnD2s5v+Q 01mE+Omw3QEKR9a4cIVeIyrSCQX71vi6KfN5KNEdhM/Dl6e4SB9FmojCVsKG3/RI6svN IoJA== X-Gm-Message-State: AAQBX9c53ctegFZNN3ShUHdqeHmRzwScM1GXpfWZmeH2jOZ54Op4oDbM oePldrvtykSx3uQtuqwdJ6Ww8g== X-Google-Smtp-Source: AKy350a1Q+ozP5ds2WouV3VdrbzlHxFnlvwWwyTzWh+i79VACbeX/Z42ARrJ5Z6urwkNhi080uGLWQ== X-Received: by 2002:a17:902:fb04:b0:1a6:97fd:29e7 with SMTP id le4-20020a170902fb0400b001a697fd29e7mr11195216plb.27.1681736851187; Mon, 17 Apr 2023 06:07:31 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c10400b001a194df5a58sm3590623pli.167.2023.04.17.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 06:07:30 -0700 (PDT) Date: Mon, 17 Apr 2023 22:07:26 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Yu Zhao , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage() Message-ID: <20230417130726.GQ25053@google.com> References: <20230304034835.2082479-4-senozhatsky@chromium.org> <20230417050140.1653593-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6113F40027 X-Stat-Signature: cu5jit5mxd7wwzbt8t56ophb94bn7e8w X-HE-Tag: 1681736852-811836 X-HE-Meta: U2FsdGVkX1+fKuCe5YLWic3KKcOwZ7cKxb2zPxwBwm1bCOqubVOCfswY4QcbH+gsgpnLBGvdlD8Xpz3Amqa4S698qklME0vA5YsY2M5ZA9hkinA3+g+PtzW1p3S22kOWqNckB5u5WKUG0UVktfu7k4UECzA7KPzMneNtQ+D4+LXRoMLGVe88Xo1Q0Y5DOI3waw5UTBAHhlz8dLoqfX3ioCcyzgON3vl85mttUehMaVNKse93e5oeL5AJqhY2AydpChKMvT2I8sa6domZcw34kjyAs3pJstL8mlDJYWIrWihWXn6WNyAuUS4IwcNmi90e4L/dHEpeVPFcz6JM5MtomXLXEVZKzjC/aqTK2Hyecutj6WCTwXZfVm5qkxBStdpTnuvOzX4Oc6dgSeqcrMO5dFSZXgBXa6mjV0L7XFIJy7i2u2vqY+G2W7LpgrLneiGxtpL7mSsWIFKU5AYDk1Q8nHndVLxZs0aNwxVSOKFTfPuVQ57ZpXQp93y3VysNylncPTBxhEh5zGjaXdfY0zq6v0UXuuEd2D/9enfrn1oQEUFL3lJ6ZOR9LODPgL1gg29FMhLLmx1UQEyc2lC+cJ56nJkYrPjn2EER+ar3o8e4WhPUwbg1Kd77gTJpxgwBZlEcASWrsvtPKF03aGkwVEBoe8Ayr2GiNIUjXr8a3113Yz1y5o+dVgan4IcUEnP3iU3bgkCBHyQ4SxPT3yKS/7oeYnW8Z6MeuGBglyAIMSaJUmyllehCcsmQrViZ67eTUhiccNeBqc1QmkfXdkF1LaWOudw6t0PhdGXw658hVN8R7YhTNtaVHTHeKeLlNNRMK9/hwctuPNthuvZjwG1Dfa+PcwH7hFav1NCnaxKbKvQfICo/EVudL6Egz/Xeo02oLaTjY9TrPlKzaMEAO5/uXiy7q9G5+30uuFTp1HBU+6ej6RJorKMMMDgl+ysV/YMeO1sGdXSR6CQYlj32NXOPPm5 sJ67Tn7n Y0C66qm2N+zKY2OcoiZspNbLi5KndGpfrdkjEir6CVEBvsu47W7+x8vT2gLIjO8Tmj5NLjdfL3vUkeVnidqDh/fC76ul3FyDh0SU96bdlcLqeAqkiyQ+0Rwl5O7Zv38P1jCp9atSDgaaduPSmt3OsfC51/QXkUEErRwjP/A2o/PaakyH3WuV0He/A+hMewdyFrc6vxznZpCYrcNWhTawsfOge6mXSJn0WTKbTyjlnHCKiPZaOkoFWxKutgXiLz06Ie5+C1qJZhzB+WOvi/lNEuPT+LN7gb6Y6n/r1sRi5OuyZdSnJlCsOU4jwAJXj8wI3U2OHEKArSthlIwwc6PtlTwpTM7hyOpuzUQq37N7KgOZkgZBj3wIpJV/XA7UBkVfCjRC9VHDcgKcaXOM77VNAIuI3owg1OkCmvFrCq2pTU3JkOLfJJUvf36ZJRGWQWbECOxApimNG132zxyf+HWc0H1BcNAn3+hZUNXFHBVj1WBZTBM0ZG+NKaTWL5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On (23/04/17 04:43), Yosry Ahmed wrote: > wrote: > > > > Fixup. > > I think the original patch landed in mm-stable already, so we might > want a proper commit log and fixes tag. > > I suspect we want: > Fixes: 5a845e9f2d66 ("zsmalloc: rework compaction algorithm") Oh, OK, let me send out a proper patch, just in case. > > > > Reported-by: Yu Zhao > > Signed-off-by: Sergey Senozhatsky > > Otherwise, LGTM. > > Reviewed-by: Yosry Ahmed Thanks.