From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD70AC77B77 for ; Mon, 17 Apr 2023 11:12:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DB75900004; Mon, 17 Apr 2023 07:12:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 264428E0001; Mon, 17 Apr 2023 07:12:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DE2B900004; Mon, 17 Apr 2023 07:12:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC8018E0001 for ; Mon, 17 Apr 2023 07:12:51 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BC443A05A7 for ; Mon, 17 Apr 2023 11:12:51 +0000 (UTC) X-FDA: 80690620542.23.CF16C6E Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf26.hostedemail.com (Postfix) with ESMTP id D68C7140013 for ; Mon, 17 Apr 2023 11:12:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SZ12pbss; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681729970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ym2iTUwYVaWcJIA6dTtqLmrSL3SannhpVhMnxRPf3Fc=; b=B/uBk6GTvW7k4AZabkz3Gp7+OIjsgRg0CWMMrZHRb35VWPVgIWkaVG3Wy36SAPjyayM8kD D/IEQG8WgtQ3ep3hadm8w2CX4691lavtIKrvlxiWSJ5ZY1Ac3fE5kCsp5yoYfLSAI73kb2 HkxMM3LjSyAaZ4ncm8cj7vcN5/hBoKQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SZ12pbss; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681729970; a=rsa-sha256; cv=none; b=4GI+nHUzquzDAKa80EdzDoiBMiIWS2ZSr8m3Jq4MN8WQYvT6k/YuBSGpf3iY97kvJEYN90 77BTCx6rDAc+lFjleRR6jcoYr++h8gAgXt3TvLa5/SEX06ePxUJHwtSxlirFBGKF1zQPN1 OWLoOp6rF91HVPrgDtTUuWZ2av+kj5Y= Received: by mail-pl1-f171.google.com with SMTP id n17so9270570pln.8 for ; Mon, 17 Apr 2023 04:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681729969; x=1684321969; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ym2iTUwYVaWcJIA6dTtqLmrSL3SannhpVhMnxRPf3Fc=; b=SZ12pbssbjHUow9znkGHEbDHYBaDRi91wqJMnjeC+2m3PX/022btfKCJ260Z2TZdqK hP+SU4Xt7nufTLUqOQ7Qzwb8z2dNLitHsYzdEjw8DXN+1jKzjMe20d9pady+jbrvNSvV COJ9CPh+1FhrqGQe29HsgZtVXCR0MtrvgmAJc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681729969; x=1684321969; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ym2iTUwYVaWcJIA6dTtqLmrSL3SannhpVhMnxRPf3Fc=; b=TWr0CyDgbkfPUdgvate2fPxvgT+Vxy/hoLOjDGsJgIKoB9cG0dpLnV2yWIt7A4NLAz 9MlEEKH3/w8kDZ59nmgbQI5sccEn6Bw8x2Y019BiW5b5KAo6jZet736LFO2fDJ88cJT+ g5YiKtHkpKN0iroyFwPJr01YDZBxTP9Q/31+dqVMI7h7WKQqiXkjyBZ7M83Rbo5rNj5J PiVxac6xdO5dJFnckcFEXf91t/4wFjfUrk5sUU6Xm/eyy4WoYSLHdBQdlY8LmhJS5fru 3msWrCgyiqfHeoJzEcVUHYPPO+GwyjwukX9Zs17wU+X1EwQEplrTZEoY66s8c6Nv6Y/J yQUg== X-Gm-Message-State: AAQBX9flbiD9FThQbRt2Auxt3MWxauTUAZhxNBWvodByBvDg0m8kgAvw G1IKSYNQSxtxEQT+GL0AE4AlwA== X-Google-Smtp-Source: AKy350YWn3KpPdVRwVstuqwc5G/3ig3SKTF2ExoN3zDvfo327CiLjLu1Tz0B5K5epY34HwTtVNdTnw== X-Received: by 2002:a17:902:eb89:b0:19c:d309:4612 with SMTP id q9-20020a170902eb8900b0019cd3094612mr11599882plg.6.1681729968673; Mon, 17 Apr 2023 04:12:48 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 20-20020a170902ee5400b001a19bac463fsm7458297plo.42.2023.04.17.04.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 04:12:48 -0700 (PDT) Date: Mon, 17 Apr 2023 20:12:43 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Yu Zhao , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Message-ID: <20230417111243.GN25053@google.com> References: <20230304034835.2082479-1-senozhatsky@chromium.org> <20230416151853.GK25053@google.com> <20230417024446.GL25053@google.com> <20230417035232.GM25053@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D68C7140013 X-Stat-Signature: s4hzrmgguqpowhu473b9icnhakzc6mg7 X-HE-Tag: 1681729969-8083 X-HE-Meta: U2FsdGVkX19Xtz8TGE4/0bJ1AeRG7O7sxnVID/BLI0AvOdJLJte6Tb93vedeQ47VxY4H1EfarNY58mtEe8JcDv4axJYDrxevJaYxLuM9CtHDaLxYB5mmmV+WSZp24Qa6IYJk3hc1VhDvoxM4zOXqcIFjQNaLJ1Ype1jmAs4Py1KPzH8EEvgOsJqVBbE/xCgTgPAwkD1RIjx4sfpMvNT+NjUr0gWYTNS6FKEZjyoS1pFVQsydARFxW1CA8BbKH90BY/DCPWcAsZohUgr+CnnC7Nkhv0xAyAqFXJXcpnYO91KA7AYm2PGpV0lkT5zlBdBYcd2hIjvuEOz6ebG13qk6+SZaigwfCoaIUJUjkZJ9QoxfzqbeN7OSOc1JeQKMQEsYbZYKcS0sdRkiWjJt5rGUR8URprgZ9ycvmPz78yI3mGe9SjqXNRu0UfNrJOkq/AoAz7d2bqWte40l68jzDswKAa9TK67TD6sCwPgm27DpYIT6y9dP5yr9r/Rw+mLJPPuU32o3Rj4qrNUbtJV9/tZqYyDgE88ZcIaF/OyC/OstkDVMZmOC6WAe0NQ0uN1ctPwOii+3f7tuwE+U50snXkzmx2pNuxAEhtaoP6KJgnS168jzK2Do1ABbHIUeH3nCHNRl2kPzLI3ifpBB9R8zNAuHeemxk0d4Yscotdy1yHKEnV2fftub/kp+AvpgTYiYgKZLWU8QPkJ9ow+eq9aOsNlzl9E2kik5TuRpqUo3awqyUtQVajKq6BJXIQLUXCFCXqKtAKXEUZz+UhJWnvyTq2afv5IE//nPOroxXEjeX1ZaDL6uYYMPG+O6eAa/i/bUDpHg4m+TkaN6Jb7lkZ/7RSTbE+Lj5qZM5JkdAelbRXpTDvhj2rA+K486ERMmIxzgbzLCmQR5W1eVj6SY8xZmML/RURbJtsCd46Gst7muYmNfhMAASMPfzsjjiEQwTXESCnw7HYynns7zzYswhphVPOj v0JZik2G 7VzwVtR0fFQVjKiDC9RcdbyZUKYpvT5KFAs/lrMd8VBs1svz4MCbiPLKgIY00kZHseGS+Ln+vsPcTwZDavO09Zb+Xoll0lqbMN8dguNFBmHmYLMBRJmvBrPds8GlN33ophC24Os2pG5DDKapkKWHtmlX6PvLPl7CYZ0LMi0ybvQmICq6r1f4vCGgjaraYPGAgdAt8MTY9hgkmrVLfLqVfBO5nZmOHcqCQbvX4CjigQdfyYy+VFKBVKIw8U7GoBhaY89o21wtWusQ5t8B3c6ikK0BRmsbzOWXQXUFfxKJefsI+XGIbY6d0SutyAVfuuCzpxvpG30BakoEXxrTEab/z730zz/r2qS1+P0GU41Hf0kduvDEFFbPho4xarw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.005803, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/17 01:29), Yosry Ahmed wrote: > > @@ -2239,8 +2241,8 @@ static unsigned long __zs_compact(struct zs_pool *pool, > > if (fg == ZS_INUSE_RATIO_0) { > > free_zspage(pool, class, src_zspage); > > pages_freed += class->pages_per_zspage; > > - src_zspage = NULL; > > } > > + src_zspage = NULL; > > > > if (get_fullness_group(class, dst_zspage) == ZS_INUSE_RATIO_100 > > || spin_is_contended(&pool->lock)) { > > For my own education, how can this result in the "next is NULL" debug > error Yu Zhao is seeing? > > IIUC if we do not set src_zspage to NULL properly after putback, then > we will attempt to putback again after the main loop in some cases. > This can result in a zspage being present more than once in the > per-class fullness list, right? > > I am not sure how this can lead to "next is NULL", which sounds like a > corrupted list_head, because the next ptr should never be NULL as far > as I can tell. I feel like I am missing something. That's a good question to which I don't have an answer. We can list_add() the same zspage twice, unlocking the pool after first list_add() so that another process (including another zs_compact()) can do something to that zspage. The answer is somewhere between these lines, I guess. I can see how, for example, another DEBUG_LIST check can be triggered: "list_add double add", because we basically can do list_add(page, list) list_add(page, list) I can also see how lockdep can be unhappy with us doing write_unlock(&zspage->lock); write_unlock(&zspage->lock); But I don't think I see how "next is NULL" happens (I haven't observed it).