From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260E5C77B61 for ; Mon, 17 Apr 2023 03:52:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F17C8E0002; Sun, 16 Apr 2023 23:52:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A13D8E0001; Sun, 16 Apr 2023 23:52:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48FB08E0002; Sun, 16 Apr 2023 23:52:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 395888E0001 for ; Sun, 16 Apr 2023 23:52:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EDB7212039E for ; Mon, 17 Apr 2023 03:52:44 +0000 (UTC) X-FDA: 80689511448.14.643ECB0 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 1B026180008 for ; Mon, 17 Apr 2023 03:52:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AUGJzuQS; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681703563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WTaC8jFgNYlM5AivUFM1gcPJigYzK2LIKWBXEllK3W4=; b=gKHwjFdH/YFj9SpXN3o5NvYYcrXRN9G2K7Ak2zbWD+eXEjUCQzULXBeJ/R/CCa+lpyHx76 3m9Mu7eT9YCdSoN3cZCzn3VleKEqkXNu37u/D5zJnUfmmb1440wTjyYFulWxPEkkck5E1n Vs7WupsRwAr8VARs/ayvdiAMWj8L2Tg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AUGJzuQS; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681703563; a=rsa-sha256; cv=none; b=psyNHVfczqnPA2ppKjrDo010m9v4Ru1+0pghQ2MX5AEOzM16vDbCYGEg5BTZ1Dlt+ixhhh xpZPn88pnNp7g3v38GlgynfyWgjiLXCXT6uSAA48v8HBsH7qqHDn2cDcqzvYj5c/uDbzY8 HNv3qhpzdZ17lv27EXPKNh4FfGMLTCk= Received: by mail-pl1-f172.google.com with SMTP id i8so15281739plt.10 for ; Sun, 16 Apr 2023 20:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681703562; x=1684295562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WTaC8jFgNYlM5AivUFM1gcPJigYzK2LIKWBXEllK3W4=; b=AUGJzuQSHCt5UDqx0rTAL9Yy+SUketTabUza7NWFbx6ye/lM2ccblA2XDccgSL6t0A Y0tGvwJJABKr8V7HPsklXM+p2dKulUFjWF8Qy60OijlGaqN+Z/M4Jcf8PM4YMNS9oIKP nF1cg82F10dUw8LMDAoo69tRUlBsBHQ9Y5kcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681703562; x=1684295562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WTaC8jFgNYlM5AivUFM1gcPJigYzK2LIKWBXEllK3W4=; b=Imlp7/9xkpVc+V/DfEqJmrpQ+zlQl0XcO+41w2zPUQgdjtU/3drcNTWuSt5PSQeyoi Z1o27KmXuHMUnW+R4VFvf25x8wJg8tmV34t6wYzQpzxeOoXWp8I6LnKwx30MAl4QvBrD hgXQgSa+CpCEmZase+HXbQ12iuKIL/v1/Gu1/ZByfhpz/JBIPS/ciZ/zJo+Med9EgRcU lyx+Vwl+DgdJjz1Eirr35yZ5cYHpHx82ERU69y71KLpNpIC1Vi8U/DLgM5vZvnqjy9yA 8D1BJIVZBCOVaK972xhyXToexrkQ3gWKQpRacLry7W5RA49RgvOmb+l1n2GbvP3heVto vHNA== X-Gm-Message-State: AAQBX9cVtSPFkb7WJBjtJ/H9PtEmYhNS4EZC84+6fC5ltvFOnYGliwii 5lYS6A6bq5wONovhJceqzfSqcw== X-Google-Smtp-Source: AKy350ZjJaBAPjIQ0A+KuGsO0zL6zvEp0Xd2pzMmZYTQAp9T09sikxUohuI9HvTgFyfudYcq/ylLLA== X-Received: by 2002:a17:902:cec1:b0:1a1:e33f:d567 with SMTP id d1-20020a170902cec100b001a1e33fd567mr13736769plg.52.1681703561783; Sun, 16 Apr 2023 20:52:41 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id p7-20020a170903248700b001a68d45e52dsm6090709plw.249.2023.04.16.20.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 20:52:41 -0700 (PDT) Date: Mon, 17 Apr 2023 12:52:32 +0900 From: Sergey Senozhatsky To: Yu Zhao Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Message-ID: <20230417035232.GM25053@google.com> References: <20230304034835.2082479-1-senozhatsky@chromium.org> <20230416151853.GK25053@google.com> <20230417024446.GL25053@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1B026180008 X-Stat-Signature: 5osp9b5bdocm3jfukoxio6ecyt16tuge X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681703562-171603 X-HE-Meta: U2FsdGVkX1/g4dMSuhYwIbKLw7mECChHj3T88Cg78SV/bnBzKWKnZFG9vMIUwwPU1/663r/rXorTRTr8AHB8wFpA85pn8+GdqoWJb521GX+/H+gfgRXrp+9bkJJwAq3GAKP7iUyup9hGuExL+SIpCIK0orhqdB1u0pbVIV/a+1OkEnq8VSaMzCGERY4nTKnQH5aWA+kyG1ryQLG96ohG/8Shlud+A/H14sXmkoSqJv61Ey4ixWwtWKe8CcE4O/am7/ZF5gXMyNL5zEfWSJmUGvf08uVZxoDty4HxMdgXCX3RTnVQr+VL70W/1ip7MY5MN7twMuKiLHAnAIrvZIu2+SImWUVkPDd1UNAfvtvi1LM7YMqlRGtGU85g1uPRj2IGtzMP+7TFHG8Ia/Xsd7MAjeNPb9599cz9EuB333r2OBGwTLZ/xWD2mAFTzlXJ9ApG+RC4+NvCg0fgjEIS6mhyluPZpTJXOYnMpUOYLvTiuknnaCaWoYLb9VcZgucIMyYZGMDJeSLphlZjQfHw1z1H1e3bq9vkAoZHv64v7tDhVxi+PPJfc1g+T3wnN6V2xkK1nIMr7g7l/K8rLZSPmqn4Ko7EAdM0aa/Pz9WQvl5Bn4+xLgIKyY/3qnP0W1tpyc0FYKVGRWepaZjoFdaAWc+7EeehMMj+tOb9PwoRdYGBuEsXNslFSOlaty2y6Flctj0ohrPAchBKow7VlRyTyb1YayFcmzNIGCZPI65cIJ2S/OAd3FsCCpffq/fHt8pNBdRuJAYXsQwF5htgzHlkrrFoD0imZTLLXs/od56RF3htTD/2/+nu2tUmBojHhj9LakqdNzzVRl7D8xpxfLKr/rRArl4GvIsCMABV+KTpJOsyBJdV8QJn5p75K8fH+pCVAR/pYdmfTLnJYjSvqYWtRWQYGVZzlWtwcbqQgVr7uHXDwTy8cV7HSBJSXs4ZzGFI2ItQg2fZsq4/ONHl3wLbW5w 5ty2RhEX s6zyr3Sgts5NVDrI3nUfVMxGJpxhXd4VzYAvZkLJ+tQ1fY0nQ/Je/wisn4DTxxOlneWY2LSuXAGZutNvSa4lh8hfuhLb3VzxBzyGoNqRreIVt3COdpaboT5Qb7oa38OEy62JLHLWw3EST7Rb9tdTYFEoQcHtTEIfIGCZ4XkbC6r2d4TD8bI8C0iPx0S8dd9GPEnc0Fb5PnE7cT53egb1sD8MBd7ZUy50IjBIjDCyTlvWRhFIhD6fBJ0AIujon9ow1a/YkkGRw8RgkdaJ6ZQNmwCDhbam9BVKhhdpEgUT2Bes6fWkLy+yf3gVQVc367ERToOVp18rIa55WBaq44PQpGklaloVzaCUuQA1Y+o69d7OSJWNMatfkMLDplw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001610, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/16 20:55), Yu Zhao wrote: > > Do you run some specific test? > > E.g., > tools/testing/selftests/kvm/max_guest_memory_test -c 112 -m 800 -s 800 > with 112 CPUs and ~770GB DRAM + 32GB zram. Hmm ... Something like this maybe? The src zspage pointer is not NULL-ed after non-empty zspage is put back to corresponding fullness list. --- @@ -2239,8 +2241,8 @@ static unsigned long __zs_compact(struct zs_pool *pool, if (fg == ZS_INUSE_RATIO_0) { free_zspage(pool, class, src_zspage); pages_freed += class->pages_per_zspage; - src_zspage = NULL; } + src_zspage = NULL; if (get_fullness_group(class, dst_zspage) == ZS_INUSE_RATIO_100 || spin_is_contended(&pool->lock)) {