From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997C5C77B70 for ; Mon, 17 Apr 2023 09:54:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAAE78E0002; Mon, 17 Apr 2023 05:54:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5A868E0001; Mon, 17 Apr 2023 05:54:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A496F8E0002; Mon, 17 Apr 2023 05:54:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96EFF8E0001 for ; Mon, 17 Apr 2023 05:54:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B27CC0487 for ; Mon, 17 Apr 2023 09:54:34 +0000 (UTC) X-FDA: 80690423268.03.74E2958 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by imf12.hostedemail.com (Postfix) with ESMTP id 31C0740009 for ; Mon, 17 Apr 2023 09:54:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=sQ8AmxbA; spf=pass (imf12.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.154.123 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681725271; a=rsa-sha256; cv=none; b=ev8OL0HmGPfrm/sXlqbqLTSBwna1JcfQWvxvmYpM40G3WjbpxZ/ulXggSZXeHcevUJUPuR TwXRWISQlheghlCTapCTmFHQUr284cV7d74TRS68bnBHl661f7/i95dNa9mo+S/Qu4d8Ew jz8cCim5qHK/+bzKJKZAA4Q5vX7C/XM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=sQ8AmxbA; spf=pass (imf12.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.154.123 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681725271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kRqq00UiLAMenfSZNE0Z4R5AXxYz1Udz0biepttGqRA=; b=xib3Q0ip38B3hCeyAEKtqkpKmYP5+sxAQD87n2T52GnM1veM+6Jg1umwfOdG4uXKsQ24GN oMgTVPyrHC7Ss8KI2M2dtXzxOW26LuHhu9pidRmejiwuQkg9e5KRE+AL0bPJYBrmotJVAY pHLPJCamjFAVhnbPEicKgPKl7Zy4eB0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1681725271; x=1713261271; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7IKmUrUbmAjjOroL5Mi4bl0RbwHdhJ3Qea7NbVaNjsA=; b=sQ8AmxbAg+qu9zRgyhOsmGYzgfC5/28/JofnGzZbMJGtkvU5+31HNzgX w316J68v5CsCOEXM1J6AA5kg1dUWehvv1cr6kItG2pN62/KHXEnQlxkr6 F0wY2xS6Xqp+iIUr1DMPOkQeQkncmDBmcinvoFGCe8/bH+EzQwI+3RluK rNXAaduXf7SUZiet6Y1FJaIpFNTlFj6b2asAJNKzjmd9D0e0CFflx28Xl wq2zWaIwahpItGNL0IafBsgZFslIvKj36mhvksYPzthAIJU0Ic30k7Kek PoMvJZ6+cRVlLKPTbRawwjQc/PdbfVGCh4guEmJ9yw0MYvJj9a2qbLYum A==; X-IronPort-AV: E=Sophos;i="5.99,203,1677567600"; d="asc'?scan'208";a="147379595" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Apr 2023 02:54:28 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 17 Apr 2023 02:54:27 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 17 Apr 2023 02:54:25 -0700 Date: Mon, 17 Apr 2023 10:54:09 +0100 From: Conor Dooley To: Hal Feng CC: , , , Stephen Boyd , Michael Turquette , Paul Gazzillo , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Message-ID: <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4HqbxmHeCq5x71ZE" Content-Disposition: inline In-Reply-To: <20230417074115.30786-2-hal.feng@starfivetech.com> X-Rspam-User: X-Rspamd-Queue-Id: 31C0740009 X-Rspamd-Server: rspam01 X-Stat-Signature: 5jjctht6gmnuj6a8ojtm37fthyynehs5 X-HE-Tag: 1681725270-200615 X-HE-Meta: U2FsdGVkX19LtfWRFTNzAs8q4m91OfyP9XoTy2FsXzShvKQIOOwxuifC56eYwTphYC14p3Io1oUEwprWjNlLcUB7PjcKS6h18lykHEHiry6exvHA0bCJ0bRIULAZCkimeFGpbPKisQZror0hnYIhbZXdSYxO1rciXRyPWpnnBMVaMH2OjPfRAZNethSF8h/TUPiPWvFzoIl57LuXLNFd3yLWfA/UtDiTqlyhXwGJRZkodxX3QbHZLlq42Z2j10sWPpUElHAu9wPyd8JM83rgg4kQ8IuNlJJcjaGli1Wmxo64xA/XSppmICzhl7wrosNfvIpgBZsiFjoXOwfRZOWQjK3Blqzfv8o7j9T6h7DWJcRyXcKz78i7sE3rxQqDCdUNsVJeiWWXCAAAQvcxi8Kzl3mPZLTUeXRV0aJWLxoVMtxxIs7Ks15FRvphiyQVUtzhnl3nQ4UhCwlwQrwwnRKZldqKN+8+BGMmFpajgU03hDu6O3TwoNbKfLvYgATfCk2bFyNQv4SJNLiNYixblAOAaGb7V+ZomZ9ZbWFa1cCy8gUQpTu/61tOyBwSCxfY9tBZ1xXRAHCXIhdwZk0mxhld4vFcFXUVie7FbXL9KswvK13aqRdUea7i5tbfQ1bb1lZeITITAlu5C7EM6whVd2zGppTtYEE4VqtL6BmsBxPwWfGWjb74hvAXtvJElUL267OSILPhE9pMWq0Nw1b2qL+452v9SNinFZq2ffxbPGE8CQobRFZQbqJxLIKhhU85dahGbMinl2FyNc7POvAZA4oAKu+YR1kUr4To5D1IWRZuE1xk6lw7VgkW74EH1GwkX1BpjGul+0MfkRsagfzcmWpao/lNIZqtVTu3JpskQTSZyWjEEeXy+nnYuLU1HVT8sR1LVGfVYuEylnSWAKTTMgY1PjmbAIdhYfJBy0DYLuS8GfkmvG3//H6QHlImAggnyrQNDIo/ZZnUE9vmChTFvnS McJSf8dh r6GWfiX3yoo+cOY7hi6FFCngs8E/RDbBU/Z4mYIy3GlDsmHmqUOhGHm9czYW7xfURuPgyodp1I9cXtKNUHRuWv5FIMOViyGplPXBEbXOJTH6dj8vy73gKwvSNYUNhFmjck8oFJyv5AKKsC4tYWCiVTp/y6oLymb7Ei45sey2wQmXWsWvQO9zaAxP+v6NLFD/PTqm6dK//feaB++yImL3UmbutgLqgSBugrPyJ0A4B/+EPTa+ZdcNVFA9izG8BRmIbb8QA6ajEfIIQ99noMXXsyTW8skbatE0T6L7Kcrrnf8P6/n4N/khUirPTtcmGO/XuWDnnyVRwzKVHYEmIRv4MHJlJF0PXEf75fPA96aSk+24elSY3so1TdC1OygCc33dlgrcpbMDY2rTlBTdupl0KLta5gGv+qoTKuca7rSjFvYQHXunLHWkPgRfo+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --4HqbxmHeCq5x71ZE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: > When (ARCH_STARFIVE [=3Dn] && COMPILE_TEST [=3Dy] && RESET_CONTROLLER [= =3Dn]), > RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > and CLK_STARFIVE_JH7110_AON. >=20 > Considering RESET_STARFIVE_JH7110 is not a necessary option for compilati= on > test, we should select it only if ARCH_STARFIVE=3Dy. Also, delete redunda= nt > selected options of CLK_STARFIVE_JH7110_AON because these options are > already selected by the dependency. >=20 > Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock dri= ver") > Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock = driver") > Signed-off-by: Hal Feng > --- > drivers/clk/starfive/Kconfig | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > index 71c1148ee5f6..3fad4adee841 100644 > --- a/drivers/clk/starfive/Kconfig > +++ b/drivers/clk/starfive/Kconfig > @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > depends on ARCH_STARFIVE || COMPILE_TEST > select AUXILIARY_BUS > select CLK_STARFIVE_JH71X0 > - select RESET_STARFIVE_JH7110 > + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE Hmm, I don't really follow the logic above. Why not just make the if be `if RESET_CONTROLLER` rather than ARCH_STARFIVE? I'm probably missing some obvious reason why not. Cheers, Conor. > default ARCH_STARFIVE > help > Say yes here to support the system clock controller on the > @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS > config CLK_STARFIVE_JH7110_AON > tristate "StarFive JH7110 always-on clock support" > depends on CLK_STARFIVE_JH7110_SYS > - select AUXILIARY_BUS > - select CLK_STARFIVE_JH71X0 > - select RESET_STARFIVE_JH7110 > default m if ARCH_STARFIVE > help > Say yes here to support the always-on clock controller on the > --=20 > 2.38.1 >=20 --4HqbxmHeCq5x71ZE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZD0XQAAKCRB4tDGHoIJi 0rY9AP9ofdEH/qXRLOt97E7lHIo0soJkVo2xSIy6xiugYzf6MgEA8rXhn0dYFMRe 3LI6GDM5MHGdtnwkhboCM7rEtr+jvAo= =rK9S -----END PGP SIGNATURE----- --4HqbxmHeCq5x71ZE--