From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F1AC77B76 for ; Mon, 17 Apr 2023 10:19:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDB3D8E0002; Mon, 17 Apr 2023 06:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8A398E0001; Mon, 17 Apr 2023 06:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52DE8E0002; Mon, 17 Apr 2023 06:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A36A38E0001 for ; Mon, 17 Apr 2023 06:18:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 64287ABF64 for ; Mon, 17 Apr 2023 10:18:59 +0000 (UTC) X-FDA: 80690484798.04.37809FC Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by imf13.hostedemail.com (Postfix) with ESMTP id 43D7F20014 for ; Mon, 17 Apr 2023 10:18:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=uZYxqMf9; spf=pass (imf13.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.154.123 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681726737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ekZOdnYqwb3ccNJESGsYpOGeQxVS4zR0INVEjcQyyuQ=; b=vsr3l2yI4+ko9xlKmNMFiWjnEt7C/CKnEN4bVEnDJEEkXYqxqX98Q7OmNkYwkuWHEd9M5g 0jnL9S5znyJelWTsC7/1EVpeN6gKZ/Hb9sqJK8LJ/L5FLHaFvoVdze7gRDAOPHzGjcloPf pCopWPl4/up7vzI2cT+oBHG9p1/S84M= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=uZYxqMf9; spf=pass (imf13.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.154.123 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com; dmarc=pass (policy=quarantine) header.from=microchip.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681726737; a=rsa-sha256; cv=none; b=jwDQZROs8G1b+Fr9GN5bsql+in5YrrEN58T9xUf09mtfm07+GsJ+RB177hcRbnFEuy074F MQdK1+kLXc59w6PSJkp8tB/iW+PQoTw4Lj1xkGF/XXJUqPnuGlR0fqi26WPrYZMQ6QDm0t kQOCMR7a+TR/suZFgXUcAVimchNPT44= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1681726737; x=1713262737; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=j90NrPShotCaZx7oLA6qnGzplSr/mn/dLWX6fn/QM3M=; b=uZYxqMf9By+gwbVHAsFl7jlJxn8s4tjTxeAy/iOte6bHnjoKprGFoNCR oLkzK8kg8bKI7ij55XkSE6uvhLDPpnTSMC4PED5u2wR/mDhgkDUsM7y1E qnP3Uuhnvs+ZqHH94Foj8sdrYOkip9PfwUHbd1dfPNr3krlXPx4FzlfOb aptD3V2Efk9jWL/lZVM+CTHCY58UiPwv+pZTqALTX+ewapkMCLul5eaqZ WOvJzgQLiKJGIKw1dTukbHYSAsHvwcu0LeRrxmyHkFiwrbWHsDMOosBk4 If2iiRZD1G1RfK5DQLImMn79KnVNSyhzyeRNPlxx9HkNZdzyjd8dbITYn A==; X-IronPort-AV: E=Sophos;i="5.99,203,1677567600"; d="asc'?scan'208";a="206819426" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Apr 2023 03:18:54 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 17 Apr 2023 03:18:53 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 17 Apr 2023 03:18:51 -0700 Date: Mon, 17 Apr 2023 11:18:35 +0100 From: Conor Dooley To: Hal Feng CC: , , , Stephen Boyd , Michael Turquette , Paul Gazzillo , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Message-ID: <20230417-bolster-vitality-89d279146497@wendy> References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UNJQkeLLzUY54mLk" Content-Disposition: inline In-Reply-To: <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 43D7F20014 X-Stat-Signature: 7iw7sdy9nx743j8dhhmhcpkqjssc7pin X-Rspam-User: X-HE-Tag: 1681726736-980002 X-HE-Meta: U2FsdGVkX1+us5C0I8UkojpAukotRXupPQY5EkBu4LgSObaRbm188IlHXJOlu5/bJ3/s/FDdgmOm7krdQQZzcEW4aHNzgwd48OJXSPx5EVu0PXed9cl1qDffWqLaMMgP6bsoTwAyu1qDXdNlvfvCFJYdsHhWFPfQayf1edaNX3H2jIFgYjS9UqCz4GBirbVKnRsp2u0t3/sQhx/acrH2Z4DQIpM85NZ+U1F4ClF0Lay8WC0maNKb6yp0sZe2eHrtRuxRX7aDtuKTHXnmRvpDcaGy9DxmDhUr4v7y7LMjrTEKXQO9VwSx4vapLi68L1ZCrBjCcRGvYf1jbEbh4yO6ZUjxD0O6bomLBj0JCK8AUAtcDA3VG9ncZU30eWczaNcqWZBLtvr4GEdIgSvfgynFGfE3PQHKqML2+nCLKBP6XPk/mGpvkxNKKfa03hRdTDDLPJP3otFVg5oKNdQbnw3GobVAGk/8VBQm+sK1UQaxBCvLiu4BeqD4vYTkKAuxhwQNZJ+h6uS2ERH3k6zUKAUSpr0O31Up83dMboBbKWZlduuUuGTciq7GcFcwLcvc9y+Ql/I5Zlo0IqaNZ0LKCuvBroAgCcez8VaeAbApSWtQnSWGB+eJ4QEbXXItu/Seuv+mBTTrfQ9Rf8retnruSiGZjEjkQKodZ//XKrnkFzAFe84xAKPyoa6S+HMpRpOwHg8yI7YNIkfRwmB/owme3NF7hz8cn/EZtBRNMDAY/1IVKpm93W3HI9394uu5fzKxgSQrlg+cffcQCQ+G0v1U+cyhViJM6L9Cl6RVCOF80O/nDKH/lbY0WEtxI1I5PM6pVHWohHfaRitw3SVqv+W5Plh2LpwTah7wRkqgH6VTNb++RWO6kEVbIx8sKO/NSPo36GJdKEWd6HcDhYKzgRDtNwHAopQKleP4/rgExaYm7NoJm7ENBMdfLYoRMyTtgtETDw/M0u9qmbJM2WvL/qPDk2L KE8F1Sbe ezLnQxSu/yYbRBk/BpsIIxHO8l6tEFdANvGrKxYOwlGtcFz7yiPSGq7UGMVyERQ529gGqeg1KOqYtLXZiMoZ4uEtKFcB1ZzbLbrXsVDVQogq67dyJvyI0wwXnHTkzHPB1+ebYDMAx0tRz4qaRkQfGFXbxZ3uB1/urQpAAwvIh7w+VlhD9CkZtpxLt1e+gBSLc7YJwzraiwGhVcJ/KZEb5vO/1yRor7/GpkEE3lyDyC6kVEue6DvWvXO3hRACz3J7k8SYhnKfRFJEBQNKamk3IfVD0rHmxoZd7cwtYQC+di5LoYkknDUj0+HtDITdd8yz3dpWmwap45/A0rAS4UZYR945EllNHi1B0Ys4Eoeqb/pPDvmCxvLOih1t+H6oakR4G6nKmWwvCknrTRsC0WCnAWORiSz8SnfHxugtemrR7YO5kB98jdLpeDLQL5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --UNJQkeLLzUY54mLk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote: > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: > >> When (ARCH_STARFIVE [=3Dn] && COMPILE_TEST [=3Dy] && RESET_CONTROLLER = [=3Dn]), > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > >> and CLK_STARFIVE_JH7110_AON. > >>=20 > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compil= ation > >> test, we should select it only if ARCH_STARFIVE=3Dy. Also, delete redu= ndant > >> selected options of CLK_STARFIVE_JH7110_AON because these options are > >> already selected by the dependency. > >>=20 > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock = driver") > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clo= ck driver") > >> Signed-off-by: Hal Feng > >> --- > >> drivers/clk/starfive/Kconfig | 5 +---- > >> 1 file changed, 1 insertion(+), 4 deletions(-) > >>=20 > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconf= ig > >> index 71c1148ee5f6..3fad4adee841 100644 > >> --- a/drivers/clk/starfive/Kconfig > >> +++ b/drivers/clk/starfive/Kconfig > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > >> depends on ARCH_STARFIVE || COMPILE_TEST > >> select AUXILIARY_BUS > >> select CLK_STARFIVE_JH71X0 > >> - select RESET_STARFIVE_JH7110 > >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE > >=20 > > Hmm, I don't really follow the logic above. > > Why not just make the if be `if RESET_CONTROLLER` rather than > > ARCH_STARFIVE? > > I'm probably missing some obvious reason why not. >=20 > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. Aye, just the explicit dependency seems like it'd be less fragile and more obvious in the future. --UNJQkeLLzUY54mLk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZD0c+wAKCRB4tDGHoIJi 0t0qAP0bDI0dkJnvMY43FLoFsCdFD9aKvpBWdIVKMFuU7DdCRgD+LYUvWpnj9rcQ r3DR0VCbP4gpvyqBUR/uXruV26OQjgA= =HWYz -----END PGP SIGNATURE----- --UNJQkeLLzUY54mLk--