From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081B9C77B76 for ; Sun, 16 Apr 2023 18:45:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FAF96B0072; Sun, 16 Apr 2023 14:45:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AB326B0074; Sun, 16 Apr 2023 14:45:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 499796B0075; Sun, 16 Apr 2023 14:45:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 382146B0072 for ; Sun, 16 Apr 2023 14:45:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 058B91401F3 for ; Sun, 16 Apr 2023 18:45:46 +0000 (UTC) X-FDA: 80688133092.11.7521B79 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 481ED40017 for ; Sun, 16 Apr 2023 18:45:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TGHaQhkl; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681670744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ALbeCvDwTBhIYzQfFlODyCRColA8qSdVAnv7geSz/4U=; b=6aGnTPCiel1qRVkvKGtK7mW6Id0Q61un4vJnAKLqduNoBkx6zBrNW6JFfvAfjr/Bhbc9zB HjuSBbcT8Myccp3TkHojQ1bxvzCd2WL3QN5RXY/s7/DeVjqLoFs3N3mLisbuI8Q+Ak8DZm 6wi0w0Ie1H01BCsmPP2BpBxI+MpBVIA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TGHaQhkl; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681670744; a=rsa-sha256; cv=none; b=JiEcH3bZjd+Iy6sVYpzdPKC2g2wKErmW1fE0xO8rHiQFZBc3paF61UeJG0QridXWMrV1v0 sZRThn9icqgoB/QYO8LYjS9WLdLovWOeaTSgxDwiE939BbokOBJLJclsJC0tNLyal9Dgbr RB5JUW44hcW2bm2/XlZ6ZS2/ogfbtDc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 414A360E95; Sun, 16 Apr 2023 18:45:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21DDCC433D2; Sun, 16 Apr 2023 18:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681670742; bh=bkKWtC6NefsrTWOS00rB7CNAs9nNkai4VlH/PsdMTIY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TGHaQhklY+LkjT0j6HAzM2+mxOTBdYmAsbuAZ3ObzoyKMTFo1uXLTY1kit7VoLk2N NL7kpz6IkkV8pqUULIH2WIgB6m8ya6F1u3UehUsoNtS4io2CyDcILuXl1qntLEBKM2 0tfJg4UOA/SwBfK2S/Xnss9lUm7hnoSLsgcAc16Y= Date: Sun, 16 Apr 2023 11:45:41 -0700 From: Andrew Morton To: Hugh Dickins Cc: Zi Yan , Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org, "Kirill A . Shutemov" , Ryan Roberts , Michal =?ISO-8859-1?Q?Koutn=FD?= , Roman Gushchin , Zach O'Keefe , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 0/7] Split a folio to any lower order folios Message-Id: <20230416114541.5d5a71c91bb1d04597038e00@linux-foundation.org> In-Reply-To: <49ee481e-452f-61c7-2da5-28de2cf3de2@google.com> References: <20230403201839.4097845-1-zi.yan@sent.com> <20230404144727.e613116684dbd65a4b4745c1@linux-foundation.org> <49ee481e-452f-61c7-2da5-28de2cf3de2@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: t77m1aquegxe7hbtpxh9yxj8xm731s7b X-Rspamd-Queue-Id: 481ED40017 X-HE-Tag: 1681670744-366610 X-HE-Meta: U2FsdGVkX18w2BjShxZs4fkVLbh3yb6h2b3etTc3F8Ep4WOW8qtzGQ8EUxUDLjU4BKZKowCt3ed9AKL47FX4KdatoYlM76Kq209U49zBPZ2iDDbWKcPlw9ppRb18XIREGH5uAzPbezTFDkxVVPrkj76X082u78QU4QybaDoLwc+S9rFjPfx057yyqXDUDQ2gqAGEGtjzW/PluCbJWS5j5erBlr6JStg8aQGL3Dkzv2jQ/Hum20phvhP0CXq0973tPbnxGacpNZlDsvjpKCGon9FS8M5HSi65u/B+zTzU8SUK8dlUIFpHUHxGJwk6n2PnbzYELU5k3liPXTmTQAyttoqo9Lc96smLsjT7nD3RuqiY82KsNJkN5/oGzN+0U7RZCNm1FK2KHnAu1/Askf2vYrC+40ifbK9lAtJ7q2SrLCuUM6KGyqK90V5EfGZpfkNVLuUqbqxRodo8SRiJKlL7LpewBpVKXdoo/DA1iAvmdQgQ2kufsnaBa8/cS/sGxv6jjvvjcXAvBoYjlHRzgpW7L8otIvvSaWiTJXS4wUwhp2bfYs9xcgs61B95mDa7vjcK9WQw/o6EX9Fo5M2l3sgoFVwklemBYfxyWqR0DBEUOsb125nAIMtTiQnw+MHivyrbO7H94l4SiyEmewqfk1CTSwviKvXWnzkw0AmKcAG7zmpGesqBBVBrDDPATCmiLN+vmUX/HwDCtRRg6OynpplgEWvVdRSqH+SucyN97rMhonSyXuCDXwxfw2ksxdM5i0JYmEqwphoCzc9axKkthAsVzl/cySEE4RKTEYh7rhH2+ZPgcWAp0vkQJo+kjodP0tY1ZXEQ/yBcTbQqRWhbD4bGaeotzr2BnR5ID/OGZv0zZrQ57Ld/L7qiwnZ0wLC2JBM74KAwzdVFO1PX6H/SwRTTOzQbNiZDfzmFKwEdI6NurmRUIAMLFcqRiewAT70ZMEQqZdEHSx4pvCVLwcjPWOr MGUvYOBH 2i0U/3/RHixdzVrVWkmLxnI2GwXPCTqwPU5C78ylvDHWEvgxk7AR0xxDej8jrdtBdLzVRvSPCmFzOLx7JLm8rC+3uRko75eGlQsbdTDHHXiavz2yLbm/XeDRuDnaYfKHiHfHbCq9a38gpNPj7uvDbxAhtOoQCNhMRP9kq+i7g02F7inSZe8GRkNv+OvTqsiHXBhCbaZ2FmGNMynSM5BA9ec5Ifb0movDzuzqx1qmythUlls+y2wP8eakA/QCZecxIrj7D2Ba92zT1IV4/8b86dl7wCkCUwpRRXe0xCaTtyiEm/4xaCZubVfJp4qm/wed33cqXokJGgrKZ14k2vBqETF+gBcHW1C0SVgEP5F4Qm+heagqnw27AHLNdYAV+VGIqcF+iPsEWGsU+H9p6kpAw95d1PHM1qyQTD1ZYbpc16Yxjd0E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 16 Apr 2023 11:11:49 -0700 (PDT) Hugh Dickins wrote: > On Tue, 4 Apr 2023, Andrew Morton wrote: > > On Mon, 3 Apr 2023 16:18:32 -0400 Zi Yan wrote: > > > > > File folio supports any order and people would like to support flexible orders > > > for anonymous folio[1] too. Currently, split_huge_page() only splits a huge > > > page to order-0 pages, but splitting to orders higher than 0 is also useful. > > > This patchset adds support for splitting a huge page to any lower order pages > > > and uses it during file folio truncate operations. > > > > This series (and its v1 & v2) don't appear to have much in the way of > > detailed review. As it's at v3 and has been fairly stable I'll queue > > it up for some testing now, but I do ask that some reviewers go through > > it please. > > Andrew, please don't let this series drift into 6.4-rc1. I have it still parked awaiting some reviewer input. > I've seen a bug or two (I'll point out in response to those patches), > but overall I don't see what the justification for the series is: done > because it could be done, it seems to me, but liable to add surprises. > > The cover letter says "splitting to orders higher than 0 is also useful", > but it's not clear why; and the infrastructure provided seems unsuited > to the one use provided - I'll say more on that truncation patch. OK, I'll drop the series for this cycle.