From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953E0C77B73 for ; Sat, 15 Apr 2023 20:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3D956B0072; Sat, 15 Apr 2023 16:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ECB76B0075; Sat, 15 Apr 2023 16:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B4286B0078; Sat, 15 Apr 2023 16:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7AFAB6B0072 for ; Sat, 15 Apr 2023 16:25:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 39CE6AB8E3 for ; Sat, 15 Apr 2023 20:25:00 +0000 (UTC) X-FDA: 80684754360.19.98B4B5D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 8A385C0016 for ; Sat, 15 Apr 2023 20:24:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hh7ylH3T; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681590298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Fh86MTMMukNXJ3L5dbobRvHZ3IVjWTpYE45r+vkJNg=; b=yBH1T/FwZGkSF0+GHgv7MYEMHi31WkR209zrZ1PH1MgextyIdXavrirm+F9QctKBdnvGjp yAywbwZ6UQ2Mfuq6ez+cESVIMf6dmjDYkjJCpTQnslaN0f73Khs35w8+5L+Q2vD+yMCNTU dQBDoNskkV3HxyOjPTxpTs7Md4hMinc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hh7ylH3T; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681590298; a=rsa-sha256; cv=none; b=t2xhufWzcSEv9aZzpy/g8UiOTOMSIXhpwszO3d/1lGF3pnyWXUCiEK4IAs28Nqi3va9+Sc SDOEQ2FnFbNpeQaNLeyVrlCz6c4RMvr1J38bTpwpPp3uaWHnEjSylunflTonX++nPG3T/o RJhZtcF9A+nyxZUAnGz6rabFQG1ZzYs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 734C3610AA; Sat, 15 Apr 2023 20:24:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85F80C433D2; Sat, 15 Apr 2023 20:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681590296; bh=OcdAMD4h6vpRlUyg25ns5nyLBp7B81xMjeVUfm1e5Pc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hh7ylH3TAq8W+WTOkeAwm1IeWriB8dot0jW5WMO7AtG6BP4uRV0KABZBdRADOcIbO 3LhmL10ZA1Y7B8OBivvjbt3josXwGA5KV60XNwIjrgKOoW258ThaqYPaC6pddAYmf1 K7b8veYM3k/iC6b1kPJVmBPXCY0/5znYRxpK1is8iO1li7HWaJSV3IYRn0Pxy84lI/ clOdkgVvpgiXXwSxHeGIO1Z6gPNNaRy+T87AF6fT0JNg8fXOnDflMrfQSxr2gZ7VCY kj0EHIBhfhbKgT3dj1w3hQ6KXQfQkVlBJGWRHh6CwhFYqT0cQg0GYPCzw4hRRx8lH7 be2qVaGntfg/A== From: SeongJae Park To: SeongJae Park Cc: Ricardo Pardini , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: linux: change tools/vm to tools/mm breaks "make clean" in tools dir Date: Sat, 15 Apr 2023 20:24:54 +0000 Message-Id: <20230415202454.13558-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230415173915.6915-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 6t7q3o6akf5o9nwaqgz8fxr61931nxce X-Rspam-User: X-Rspamd-Queue-Id: 8A385C0016 X-Rspamd-Server: rspam06 X-HE-Tag: 1681590298-635798 X-HE-Meta: U2FsdGVkX180coX3ZhZtjKwfYgC/MLl/BhQj9KKErweivdh65JbPFEYZT26TxBig97y2Llu3CN4Z9ddn3qQDArf514lxO+7/p3IGY8qampoMuTP/J1OfS6iihVB6ff1wgOu0puy60Q17Ycgv4WUz7pZ1B9NvyuLZM4gXXVhirzZyp9SwLHGzRoK9Jq5bA/99qEhCDSHDEsb3p8VQ8/pEjzxqRTjf+8tybE7H1/jkk02tVac7VS0CXQEfWO/QGdEbCtyC5i5D1LeFGSyyzSxJvCKM68vUVxMxz6bz/k77/z67ob7ev2piFYkayx8R823uBqLXKd0xlZwgsU/di5pKXOoS8aSoGbD9IjujA7w+lvlR7Uv3UAjHmUDGMPScPpiZ0KzltnfM76MDIRfCx5fmtTrvIJYNMEwXTyIooLfh2ao3ltJAOtAK6jdVtlzA5k82T4G5NtIX+TC5EkYtj8fkp3/a/56PCJCJZFQ7VNBTUaOviOYJfE7BUsNNNerdPJmazg6XOQcROnohVlPWPOPhDZ/vdNlf2/d91mrKOGcnJYM5LMs+6gJNYk8R0IiR+EpqfUDtvnaEdwn6Z3WFC9E/BpSRi81rxEsggQBkQefgNBXY5fiBKx35Slrr3fNkl7aeqL6tuf+8Zz2SOdTN7dh7RdyhbsjJoL3jxcOokFOlOKKMZhBpKdcitZrRkU22lQtF61IYldaWneNHoHmUWPizLemM8qrhJK6HCnsvX0LyA2Zbmx3GuB1Ai+KQsCNW7H75zulC5f31ZCKhxCXv6w7O/Az8uOyLPEgFcWSbLMiJzznTNywO7yfkA5sOjwfVZi3/+lqJv6y3uUDOy4Sv/IQb6GktN1pnp8RaHVl81p1rx6ntoF4AyRbsuQfTEDPR8Ih9YU7fTaoZNxWLTYDzwGK8jpwKPiKt+9j0Pal3nOP6Gp06TAO2I9SY+KIISN4u10mOa9i/AScznQ+bU/Yxm8F qvOXzMlK 03TorsnwNh0dbqDtsQK5QFB1v3Jr0pSZEHuKYmsAt8miJhdseZYHIhefzecwFTeMlyNBVhb06BP561ybuqNS0S+jBFLVopqjew1Pw2TR8rBZpJWxSa+E0M/16BeMbcf3iwoVsDbY5OBiKMrpIKmZhSEb8UCDQjOQREw0eIBAfMijQcLlLtlInByI0kZFt/8nUP11ELBNXO7Ph7RjxmKMLpSm5XJPNVweNezsmokBoWPvYlkgGNaK82A81F3UnsFOhsi62cK9xX/gzOsc6W0z8EJx4gZtrOtR2PYSHYDCC0Mth1SB2ROTl0WCwpHEZqIUhf4c42Vcjsv8O4Dc/VIYql632aBs0AzPwNRhdFmiDaRufpfKxGC+K+UCS9Zd/fFgoyrkaeauGY6xEM2eH9GY8qjMfrBPYThz6fMM6hDJ8E8NNg1TxNFtJMM7s8GLdFn7sCRCvqohNm3NXebLQiTeoCVoFvq+o06S6Fapr24DfXiWedWdaFgUjlDrWEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, I got below breat bug report from Ricardo via personal mail. Forwarding to mailing lists under Ricardo's approval for sharing the context. Thanks, SJ On Sat, 15 Apr 2023 17:39:15 +0000 SeongJae Park wrote: > Hi Ricardo, > > On Sat, 15 Apr 2023 18:55:41 +0200 Ricardo Pardini wrote: > > > Hey SJ, here's a hack I had to do. I'm not on the mailing list, sorry. > > No problem. If you don't mind, please feel free to send any mail to the > mailing list even if you don't subscribe. You can also read the mails from > archives like lore.kernel.org. > > > I figure the tools/Makefile needs love after the vm->mm rename, wanted > > to give you a heads up. > > > > + # Small detour: in v6.3-rc1, in commit > > https://github.com/torvalds/linux/commit/799fb82aa132fa3a3886b7872997a5a84e820062, > > + # the tools/vm dir was renamed to tools/mm. > > Unfortunately tools/Makefile still expects it to exist, > > + # and "make clean" in the "/tools" dir fails. Drop in > > a fake Makefile there to work around this. > > > > From https://patch-diff.githubusercontent.com/raw/armbian/build/pull/5059.patch > > Thank you very much for this report! I confirmed the issue can be reproduced > on my machine and fixed with below patch. If you see no problem with the > patch, I will post it to the mailing list. > > > Thanks, > SJ > > > > > Cordially, > > > > -- > > Ricardo Pardini > > Armbian > > > ================================== 8< ========================================== > > From de3d8d9a84e1b37aeefb01935dc8d5a390829a6c Mon Sep 17 00:00:00 2001 > From: SeongJae Park > Date: Sat, 15 Apr 2023 17:27:18 +0000 > Subject: [PATCH] tools/Makefile: do missed s/vm/mm/ > > Commit 799fb82aa132 ("tools/vm: rename tools/vm to tools/mm") missed > renaming 'vm' in 'tools/Makefile' to 'mm'. As a result, 'make clean' > under 'tools/' directory fails as below: > > $ make -C tools clean > DESCEND vm > make[1]: Entering directory '/linux/tools/vm' > make[1]: *** No rule to make target 'clean'. Stop. > make[1]: Leaving directory '/linux/tools/vm' > make: *** [Makefile:173: vm_clean] Error 2 > make: Leaving directory '/linux/tools' > > Do the missed rename. > > Reported-by: Ricardo Pardini > Fixes: 799fb82aa132 ("tools/vm: rename tools/vm to tools/mm") > Signed-off-by: SeongJae Park > --- > tools/Makefile | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tools/Makefile b/tools/Makefile > index e497875fc7e3..37e9f6804832 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -39,7 +39,7 @@ help: > @echo ' turbostat - Intel CPU idle stats and freq reporting tool' > @echo ' usb - USB testing tools' > @echo ' virtio - vhost test module' > - @echo ' vm - misc vm tools' > + @echo ' mm - misc mm tools' > @echo ' wmi - WMI interface examples' > @echo ' x86_energy_perf_policy - Intel energy policy tool' > @echo '' > @@ -69,7 +69,7 @@ acpi: FORCE > cpupower: FORCE > $(call descend,power/$@) > > -cgroup counter firewire hv guest bootconfig spi usb virtio vm bpf iio gpio objtool leds wmi pci firmware debugging tracing: FORCE > +cgroup counter firewire hv guest bootconfig spi usb virtio mm bpf iio gpio objtool leds wmi pci firmware debugging tracing: FORCE > $(call descend,$@) > > bpf/%: FORCE > @@ -118,7 +118,7 @@ kvm_stat: FORCE > > all: acpi cgroup counter cpupower gpio hv firewire \ > perf selftests bootconfig spi turbostat usb \ > - virtio vm bpf x86_energy_perf_policy \ > + virtio mm bpf x86_energy_perf_policy \ > tmon freefall iio objtool kvm_stat wmi \ > pci debugging tracing thermal thermometer thermal-engine > > @@ -128,7 +128,7 @@ acpi_install: > cpupower_install: > $(call descend,power/$(@:_install=),install) > > -cgroup_install counter_install firewire_install gpio_install hv_install iio_install perf_install bootconfig_install spi_install usb_install virtio_install vm_install bpf_install objtool_install wmi_install pci_install debugging_install tracing_install: > +cgroup_install counter_install firewire_install gpio_install hv_install iio_install perf_install bootconfig_install spi_install usb_install virtio_install mm_install bpf_install objtool_install wmi_install pci_install debugging_install tracing_install: > $(call descend,$(@:_install=),install) > > selftests_install: > @@ -158,7 +158,7 @@ kvm_stat_install: > install: acpi_install cgroup_install counter_install cpupower_install gpio_install \ > hv_install firewire_install iio_install \ > perf_install selftests_install turbostat_install usb_install \ > - virtio_install vm_install bpf_install x86_energy_perf_policy_install \ > + virtio_install mm_install bpf_install x86_energy_perf_policy_install \ > tmon_install freefall_install objtool_install kvm_stat_install \ > wmi_install pci_install debugging_install intel-speed-select_install \ > tracing_install thermometer_install thermal-engine_install > @@ -169,7 +169,7 @@ acpi_clean: > cpupower_clean: > $(call descend,power/cpupower,clean) > > -cgroup_clean counter_clean hv_clean firewire_clean bootconfig_clean spi_clean usb_clean virtio_clean vm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean tracing_clean: > +cgroup_clean counter_clean hv_clean firewire_clean bootconfig_clean spi_clean usb_clean virtio_clean mm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean tracing_clean: > $(call descend,$(@:_clean=),clean) > > libapi_clean: > @@ -211,7 +211,7 @@ build_clean: > > clean: acpi_clean cgroup_clean counter_clean cpupower_clean hv_clean firewire_clean \ > perf_clean selftests_clean turbostat_clean bootconfig_clean spi_clean usb_clean virtio_clean \ > - vm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \ > + mm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \ > freefall_clean build_clean libbpf_clean libsubcmd_clean \ > gpio_clean objtool_clean leds_clean wmi_clean pci_clean firmware_clean debugging_clean \ > intel-speed-select_clean tracing_clean thermal_clean thermometer_clean thermal-engine_clean > -- > 2.25.1