From: SeongJae Park <sj@kernel.org>
To: akpm@linux-foundation.org
Cc: vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
SeongJae Park <sj@kernel.org>
Subject: [PATCH 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
Date: Sat, 15 Apr 2023 00:37:53 +0000 [thread overview]
Message-ID: <20230415003754.1852-3-sj@kernel.org> (raw)
In-Reply-To: <20230415003754.1852-1-sj@kernel.org>
The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU
read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has
similar example code snippet, and commit da82af04352b ("doc: Update and
wordsmith rculist_nulls.rst") has broken it. Apply the change to
SLAB_TYPESAFE_BY_RCU example code snippet, too.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/slab.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/slab.h b/include/linux/slab.h
index b18e56c6f06c..a2fd57322c9c 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -53,15 +53,16 @@
* stays valid, the trick to using this is relying on an independent
* object validation pass. Something like:
*
+ * begin:
* rcu_read_lock();
- * again:
* obj = lockless_lookup(key);
* if (obj) {
* if (!try_get_ref(obj)) // might fail for free objects
- * goto again;
+ * goto begin;
*
* if (obj->key != key) { // not the object we expected
* put_ref(obj);
+ * rcu_read_unlock();
* goto again;
* }
* }
--
2.25.1
next prev parent reply other threads:[~2023-04-15 0:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 0:37 [PATCH 0/2] mm/slab: trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet SeongJae Park
2023-04-15 0:37 ` [PATCH 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code SeongJae Park
2023-04-15 0:37 ` SeongJae Park [this message]
2023-04-15 2:51 ` [PATCH 2/2] mm/slab: break up RCU readers " Matthew Wilcox
2023-04-15 3:04 ` SeongJae Park
2023-04-15 3:23 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230415003754.1852-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox